Re: [PATCH] SCSI-wd33c93: Deletion of a check before the function call wd33c93_setup

[Dan Carpenter]

On Wed, Jun 24, 2015 at 05:33:50PM +0200, SF Markus Elfring wrote:
 From: Markus Elfring elfr...@users.sourceforge.net
 Date: Wed, 24 Jun 2015 17:15:17 +0200
 
 The wd33c93_setup() function performs also input parameter validation.
 Thus the test around the call is not needed.
 

Guys, you should be aware that Markus auto generates his patches and he
doesn't even do a cursory review.

I find it acceptable that some of my update suggestions do not fit
to your quality expectations at the moment. -- Markus Elfring
(https://lkml.org/lkml/2015/1/22/446)

regards,
dan carpenter

--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] SCSI-wd33c93: Deletion of a check before the function call wd33c93_setup

[SF Markus Elfring]

From: Markus Elfring elfr...@users.sourceforge.net
Date: Wed, 24 Jun 2015 17:15:17 +0200

The wd33c93_setup() function performs also input parameter validation.
Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring elfr...@users.sourceforge.net
---
 drivers/scsi/wd33c93.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/wd33c93.c b/drivers/scsi/wd33c93.c
index 9e09da4..e5ed956 100644
--- a/drivers/scsi/wd33c93.c
+++ b/drivers/scsi/wd33c93.c
@@ -1939,7 +1939,7 @@ wd33c93_init(struct Scsi_Host *instance, const 
wd33c93_regs regs,
int val;
char buf[32];
 
-   if (!done_setup  setup_strings)
+   if (!done_setup)
wd33c93_setup(setup_strings);
 
hostdata = (struct WD33C93_hostdata *) instance-hostdata;
-- 
2.4.4

--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html