RE: [PATCH] aacraid: don't assign cpu_to_le32(constant) to u8

[Salyzyn, Mark]

ACK

Sincerely -- Mark Salyzyn

 -Original Message-
 From: Stephen Rothwell [mailto:[EMAIL PROTECTED] 
 Sent: Wednesday, October 31, 2007 12:02 AM
 To: AACRAID
 Cc: linux-scsi@vger.kernel.org; LKML
 Subject: [PATCH] aacraid: don't assign cpu_to_le32(constant) to u8
 
 Noticed on PowerPC allmod config build:
 
 drivers/scsi/aacraid/commsup.c:1342: warning: large integer 
 implicitly truncated to unsigned type
 drivers/scsi/aacraid/commsup.c:1343: warning: large integer 
 implicitly truncated to unsigned type
 drivers/scsi/aacraid/commsup.c:1344: warning: large integer 
 implicitly truncated to unsigned type
 
 Signed-off-by: Stephen Rothwell [EMAIL PROTECTED]
 ---
  drivers/scsi/aacraid/commsup.c |6 +++---
  1 files changed, 3 insertions(+), 3 deletions(-)
 
 -- 
 Cheers,
 Stephen Rothwell[EMAIL PROTECTED]
 
 diff --git a/drivers/scsi/aacraid/commsup.c 
 b/drivers/scsi/aacraid/commsup.c
 index 240a0bb..b9682a8 100644
 --- a/drivers/scsi/aacraid/commsup.c
 +++ b/drivers/scsi/aacraid/commsup.c
 @@ -1339,9 +1339,9 @@ int aac_check_health(struct aac_dev * aac)
   aif = (struct aac_aifcmd *)hw_fib-data;
   aif-command = cpu_to_le32(AifCmdEventNotify);
   aif-seqnum = cpu_to_le32(0x);
 - aif-data[0] = cpu_to_le32(AifEnExpEvent);
 - aif-data[1] = cpu_to_le32(AifExeFirmwarePanic);
 - aif-data[2] = cpu_to_le32(AifHighPriority);
 + aif-data[0] = AifEnExpEvent;
 + aif-data[1] = AifExeFirmwarePanic;
 + aif-data[2] = AifHighPriority;
   aif-data[3] = cpu_to_le32(BlinkLED);
  
   /*
 -- 
 1.5.3.4
 
-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] aacraid: don't assign cpu_to_le32(constant) to u8

[Stephen Rothwell]

Noticed on PowerPC allmod config build:

drivers/scsi/aacraid/commsup.c:1342: warning: large integer implicitly 
truncated to unsigned type
drivers/scsi/aacraid/commsup.c:1343: warning: large integer implicitly 
truncated to unsigned type
drivers/scsi/aacraid/commsup.c:1344: warning: large integer implicitly 
truncated to unsigned type

Signed-off-by: Stephen Rothwell [EMAIL PROTECTED]
---
 drivers/scsi/aacraid/commsup.c |6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

-- 
Cheers,
Stephen Rothwell[EMAIL PROTECTED]

diff --git a/drivers/scsi/aacraid/commsup.c b/drivers/scsi/aacraid/commsup.c
index 240a0bb..b9682a8 100644
--- a/drivers/scsi/aacraid/commsup.c
+++ b/drivers/scsi/aacraid/commsup.c
@@ -1339,9 +1339,9 @@ int aac_check_health(struct aac_dev * aac)
aif = (struct aac_aifcmd *)hw_fib-data;
aif-command = cpu_to_le32(AifCmdEventNotify);
aif-seqnum = cpu_to_le32(0x);
-   aif-data[0] = cpu_to_le32(AifEnExpEvent);
-   aif-data[1] = cpu_to_le32(AifExeFirmwarePanic);
-   aif-data[2] = cpu_to_le32(AifHighPriority);
+   aif-data[0] = AifEnExpEvent;
+   aif-data[1] = AifExeFirmwarePanic;
+   aif-data[2] = AifHighPriority;
aif-data[3] = cpu_to_le32(BlinkLED);
 
/*
-- 
1.5.3.4

-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html