Re: [PATCH] megaraid_sas: insert missing space in kernel message

2015-06-09 Thread Johannes Thumshirn 
On Tue, Jun 09, 2015 at 04:53:43PM +0100, Colin King wrote:
> From: Colin Ian King 
> 
> The printk format specifier string is missing a space between
> the %p format specifier and the "on the defer" text. Minor fix,
> add the missing space.
> 
> Signed-off-by: Colin Ian King 
> ---
>  drivers/scsi/megaraid/megaraid_sas_base.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c 
> b/drivers/scsi/megaraid/megaraid_sas_base.c
> index 890637f..4889ef6 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_base.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_base.c
> @@ -3148,7 +3148,7 @@ megasas_internal_reset_defer_cmds(struct 
> megasas_instance *instance)
>   cmd = instance->cmd_list[i];
>   if (cmd->sync_cmd == 1 || cmd->scmd) {
>   printk(KERN_NOTICE "megasas: moving cmd[%d]:%p:%d:%p"
> - "on the defer queue as internal\n",
> + " on the defer queue as internal\n",
>   defer_index, cmd, cmd->sync_cmd, cmd->scmd);
>  
>   if (!list_empty(&cmd->list)) {
> -- 
> 2.1.4
> 

Reviewed-by: Johannes Thumshirn 

-- 
Johannes Thumshirn   Storage
jthumsh...@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH] megaraid_sas: insert missing space in kernel message

2015-06-09 Thread Sumit Saxena 
>-Original Message-
>From: Colin King [mailto:colin.k...@canonical.com]
>Sent: Tuesday, June 09, 2015 9:24 PM
>To: Kashyap Desai; Sumit Saxena; Uday Lingala; James E.J. Bottomley;
>megaraidlinux@avagotech.com; linux-scsi@vger.kernel.org
>Cc: linux-ker...@vger.kernel.org
>Subject: [PATCH] megaraid_sas: insert missing space in kernel message
>
>From: Colin Ian King 
>
>The printk format specifier string is missing a space between the %p
format
>specifier and the "on the defer" text. Minor fix, add the missing space.
>
>Signed-off-by: Colin Ian King 
>---
> drivers/scsi/megaraid/megaraid_sas_base.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
>b/drivers/scsi/megaraid/megaraid_sas_base.c
>index 890637f..4889ef6 100644
>--- a/drivers/scsi/megaraid/megaraid_sas_base.c
>+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
>@@ -3148,7 +3148,7 @@ megasas_internal_reset_defer_cmds(struct
>megasas_instance *instance)
>   cmd = instance->cmd_list[i];
>   if (cmd->sync_cmd == 1 || cmd->scmd) {
>   printk(KERN_NOTICE "megasas: moving
>cmd[%d]:%p:%d:%p"
>-  "on the defer queue as
internal\n",
>+  " on the defer queue as
internal\n",
>   defer_index, cmd, cmd->sync_cmd, cmd-
>>scmd);
>
>   if (!list_empty(&cmd->list)) {
Acked-by: Sumit Saxena 

>--
>2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] megaraid_sas: insert missing space in kernel message

2015-06-09 Thread Colin King 
From: Colin Ian King 

The printk format specifier string is missing a space between
the %p format specifier and the "on the defer" text. Minor fix,
add the missing space.

Signed-off-by: Colin Ian King 
---
 drivers/scsi/megaraid/megaraid_sas_base.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c 
b/drivers/scsi/megaraid/megaraid_sas_base.c
index 890637f..4889ef6 100644
--- a/drivers/scsi/megaraid/megaraid_sas_base.c
+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
@@ -3148,7 +3148,7 @@ megasas_internal_reset_defer_cmds(struct megasas_instance 
*instance)
cmd = instance->cmd_list[i];
if (cmd->sync_cmd == 1 || cmd->scmd) {
printk(KERN_NOTICE "megasas: moving cmd[%d]:%p:%d:%p"
-   "on the defer queue as internal\n",
+   " on the defer queue as internal\n",
defer_index, cmd, cmd->sync_cmd, cmd->scmd);
 
if (!list_empty(&cmd->list)) {
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html