Re: [PATCH] mptscsih: remove bogus interpretation of request->ioprio

[Martin K. Petersen]

> "Christoph" == Christoph Hellwig  writes:

Christoph> Having an I/O priority does not mean we should send all
Christoph> requests as HEAD OF QUEUE tags.

Applied to 4.10/scsi-queue.

-- 
Martin K. Petersen  Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mptscsih: remove bogus interpretation of request->ioprio

[Hannes Reinecke]

On 10/13/2016 10:46 AM, Christoph Hellwig wrote:
> Having an I/O priority does not mean we should send all requests as
> HEAD OF QUEUE tags.
> 
> Reported-by: Adam Manzanares 
> Signed-off-by: Christoph Hellwig 
> ---
>  drivers/message/fusion/mptscsih.c | 11 +++
>  1 file changed, 3 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/message/fusion/mptscsih.c 
> b/drivers/message/fusion/mptscsih.c
> index 6c9fc11..08a807d 100644
> --- a/drivers/message/fusion/mptscsih.c
> +++ b/drivers/message/fusion/mptscsih.c
> @@ -1366,15 +1366,10 @@ mptscsih_qcmd(struct scsi_cmnd *SCpnt)
>   /* Default to untagged. Once a target structure has been allocated,
>* use the Inquiry data to determine if device supports tagged.
>*/
> - if ((vdevice->vtarget->tflags & MPT_TARGET_FLAGS_Q_YES)
> - && (SCpnt->device->tagged_supported)) {
> + if ((vdevice->vtarget->tflags & MPT_TARGET_FLAGS_Q_YES) &&
> + SCpnt->device->tagged_supported)
>   scsictl = scsidir | MPI_SCSIIO_CONTROL_SIMPLEQ;
> - if (SCpnt->request && SCpnt->request->ioprio) {
> - if (((SCpnt->request->ioprio & 0x7) == 1) ||
> - !(SCpnt->request->ioprio & 0x7))
> - scsictl |= MPI_SCSIIO_CONTROL_HEADOFQ;
> - }
> - } else
> + else
>   scsictl = scsidir | MPI_SCSIIO_CONTROL_UNTAGGED;
>  
>  
> 
Reviewed-by: Hannes Reinecke 

Cheers,

Hannes
-- 
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de   +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] mptscsih: remove bogus interpretation of request->ioprio

[Christoph Hellwig]

Having an I/O priority does not mean we should send all requests as
HEAD OF QUEUE tags.

Reported-by: Adam Manzanares 
Signed-off-by: Christoph Hellwig 
---
 drivers/message/fusion/mptscsih.c | 11 +++
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/drivers/message/fusion/mptscsih.c 
b/drivers/message/fusion/mptscsih.c
index 6c9fc11..08a807d 100644
--- a/drivers/message/fusion/mptscsih.c
+++ b/drivers/message/fusion/mptscsih.c
@@ -1366,15 +1366,10 @@ mptscsih_qcmd(struct scsi_cmnd *SCpnt)
/* Default to untagged. Once a target structure has been allocated,
 * use the Inquiry data to determine if device supports tagged.
 */
-   if ((vdevice->vtarget->tflags & MPT_TARGET_FLAGS_Q_YES)
-   && (SCpnt->device->tagged_supported)) {
+   if ((vdevice->vtarget->tflags & MPT_TARGET_FLAGS_Q_YES) &&
+   SCpnt->device->tagged_supported)
scsictl = scsidir | MPI_SCSIIO_CONTROL_SIMPLEQ;
-   if (SCpnt->request && SCpnt->request->ioprio) {
-   if (((SCpnt->request->ioprio & 0x7) == 1) ||
-   !(SCpnt->request->ioprio & 0x7))
-   scsictl |= MPI_SCSIIO_CONTROL_HEADOFQ;
-   }
-   } else
+   else
scsictl = scsidir | MPI_SCSIIO_CONTROL_UNTAGGED;
 
 
-- 
2.10.1.382.ga23ca1b

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html