Re: [PATCH] scsi: cxlflash: fix assignment of the backend operations
Cédric,
> commit cd43c221bb5e ("scsi: cxlflash: Isolate external module
> dependencies") introduced the use of ifdefs to avoid compilation
> errors when one of the possible backend driver, CXL or OCXL, is not
> compiled.
>
> Unfortunately, the wrong defines are used and the backend ops are
> never assigned, leading to a kernel crash in any case when the
> cxlflash module is loaded.
Applied to 4.18/scsi-fixes, thank you!
--
Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: cxlflash: fix assignment of the backend operations
On Thu, Jul 05, 2018 at 07:26:23AM +0200, Cédric Le Goater wrote:
> commit cd43c221bb5e ("scsi: cxlflash: Isolate external module
> dependencies") introduced the use of ifdefs to avoid compilation
> errors when one of the possible backend driver, CXL or OCXL, is not
> compiled.
>
> Unfortunately, the wrong defines are used and the backend ops are
> never assigned, leading to a kernel crash in any case when the
> cxlflash module is loaded.
>
> Signed-off-by: Cédric Le Goater
Odd, I know Uma tested this but perhaps not with a clean build...
Thanks for catching this Cedric!
Acked-by: Matthew R. Ochs
[PATCH] scsi: cxlflash: fix assignment of the backend operations
commit cd43c221bb5e ("scsi: cxlflash: Isolate external module
dependencies") introduced the use of ifdefs to avoid compilation
errors when one of the possible backend driver, CXL or OCXL, is not
compiled.
Unfortunately, the wrong defines are used and the backend ops are
never assigned, leading to a kernel crash in any case when the
cxlflash module is loaded.
Signed-off-by: Cédric Le Goater
---
drivers/scsi/cxlflash/main.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/cxlflash/main.h b/drivers/scsi/cxlflash/main.h
index 2a3977823812..a39be94d110c 100644
--- a/drivers/scsi/cxlflash/main.h
+++ b/drivers/scsi/cxlflash/main.h
@@ -107,12 +107,12 @@ cxlflash_assign_ops(struct dev_dependent_vals *ddv)
{
const struct cxlflash_backend_ops *ops = NULL;
-#ifdef CONFIG_OCXL
+#ifdef CONFIG_OCXL_BASE
if (ddv->flags & CXLFLASH_OCXL_DEV)
ops = _ocxl_ops;
#endif
-#ifdef CONFIG_CXL
+#ifdef CONFIG_CXL_BASE
if (!(ddv->flags & CXLFLASH_OCXL_DEV))
ops = _cxl_ops;
#endif
--
2.13.6
