[PATCH] scsi: pcmcia: nsp_cs: remove module init/exit function prototypes
This driver now uses the module_pcmcia_driver() macro to supply the init/exit code. The nsp_cs_{init,exit} prototypes should be removed. Reported-by: kbuild test robot fengguang...@intel.com Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: YOKOTA Hiroshi yok...@netlab.is.tsukuba.ac.jp Cc: James E.J. Bottomley jbottom...@parallels.com Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: linux-scsi@vger.kernel.org Cc: linux-ker...@vger.kernel.org --- drivers/scsi/pcmcia/nsp_cs.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/scsi/pcmcia/nsp_cs.h b/drivers/scsi/pcmcia/nsp_cs.h index afd64f0..ea5122f 100644 --- a/drivers/scsi/pcmcia/nsp_cs.h +++ b/drivers/scsi/pcmcia/nsp_cs.h @@ -326,10 +326,6 @@ static struct Scsi_Host *nsp_detect(struct scsi_host_template *sht); /* Interrupt handler */ //static irqreturn_t nspintr(int irq, void *dev_id); -/* Module entry point*/ -static int __init nsp_cs_init(void); -static void __exit nsp_cs_exit(void); - /* Debug */ #ifdef NSP_DEBUG static void show_command (struct scsi_cmnd *SCpnt); -- 1.8.1.4 -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] scsi: pcmcia: nsp_cs: remove module init/exit function prototypes
On Mon, 2013-04-15 at 09:42 -0700, H Hartley Sweeten wrote: This driver now uses the module_pcmcia_driver() macro to supply the init/exit code. The nsp_cs_{init,exit} prototypes should be removed. This reasoning is bogus. Why the driver actually has all these static prototypes in its header file is entirely unclear to me, but singling these two out for the reason you state above is wrong (both the reason and picking only two of them). Hiroshi, you're the maintainer, what do you want to do ... since the driver is ancient, I'm happy to leave it untouched, or if you want to tidy it up, I see no reason to have any static prototypes in the header file. Thanks, James -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html