[PATCH] scsi: qla2xxx: Use PTR_ERR_OR_ZERO to replace the open coded version

2018-11-27 Thread Wen Yang 
PTR_ERR_OR_ZERO has implemented the same function, so use inlined function
instead of open coded equivalent.

Signed-off-by: Wen Yang 
CC: "James E.J. Bottomley" 
CC: "Martin K. Petersen" 
CC: qla2xxx-upstr...@qlogic.com
CC: linux-scsi@vger.kernel.org
CC: Wen Yang 
CC: linux-ker...@vger.kernel.org
---
 drivers/scsi/qla2xxx/tcm_qla2xxx.c | 5 +
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/scsi/qla2xxx/tcm_qla2xxx.c 
b/drivers/scsi/qla2xxx/tcm_qla2xxx.c
index 65053c066680..633f258085c7 100644
--- a/drivers/scsi/qla2xxx/tcm_qla2xxx.c
+++ b/drivers/scsi/qla2xxx/tcm_qla2xxx.c
@@ -1577,10 +1577,7 @@ static int tcm_qla2xxx_check_initiator_node_acl(
   sizeof(struct qla_tgt_cmd),
   TARGET_PROT_ALL, port_name,
   qlat_sess, tcm_qla2xxx_session_cb);
-   if (IS_ERR(se_sess))
-   return PTR_ERR(se_sess);
-
-   return 0;
+   return PTR_ERR_OR_ZERO(se_sess);
 }
 
 static void tcm_qla2xxx_update_sess(struct fc_port *sess, port_id_t s_id,
-- 
2.19.1

[PATCH] scsi: qla2xxx: Use PTR_ERR_OR_ZERO

2017-08-29 Thread Himanshu Jha 
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR

Signed-off-by: Himanshu Jha 
---
 drivers/scsi/qla2xxx/tcm_qla2xxx.c | 5 +
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/scsi/qla2xxx/tcm_qla2xxx.c 
b/drivers/scsi/qla2xxx/tcm_qla2xxx.c
index 3f82ea1..bf33350 100644
--- a/drivers/scsi/qla2xxx/tcm_qla2xxx.c
+++ b/drivers/scsi/qla2xxx/tcm_qla2xxx.c
@@ -1522,10 +1522,7 @@ static int tcm_qla2xxx_check_initiator_node_acl(
   sizeof(struct qla_tgt_cmd),
   TARGET_PROT_ALL, port_name,
   qlat_sess, tcm_qla2xxx_session_cb);
-   if (IS_ERR(se_sess))
-   return PTR_ERR(se_sess);
-
-   return 0;
+   return PTR_ERR_OR_ZERO(se_sess);
 }
 
 static void tcm_qla2xxx_update_sess(struct fc_port *sess, port_id_t s_id,
-- 
2.7.4