RE: [PATCH 0/4] mpt2/mpt3 static checker fixups

2014-06-25 Thread Sreekanth Reddy 
James,

This Patch set seems to be fine. Please consider this patch set as
Acked-by:  Sreekanth Reddy 

Regards,
Sreekanth

>-Original Message-
>From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-
>ow...@vger.kernel.org] On Behalf Of Joe Lawrence
>Sent: Monday, June 02, 2014 8:04 PM
>To: linux-scsi@vger.kernel.org
>Cc: Dan Carpenter; Sreekanth Reddy; Joe Lawrence
>Subject: [PATCH 0/4] mpt2/mpt3 static checker fixups
>
>Hello Sreekanth, Dan,
>
>These are a few minor smatch and sparse static checker fixes for the LSI
>mpt2 and mpt3 drivers.  The first three fix real potential bugs and the
last
>cleans up a noisy complaint from sparse.
>
>Joe Lawrence (4):
>  mpt2sas: correct scsi_{target,device} hostdata allocation
>  mpt3sas: correct scsi_{target,device} hostdata allocation
>  mpt3sas: fix possible memory leak in mpt3sas_send_trigger_data_event
>  mpt2sas: annotate ioc->reply_post_host_index as __iomem
>
> drivers/scsi/mpt2sas/mpt2sas_base.c  |9 +
> drivers/scsi/mpt2sas/mpt2sas_base.h  |2 +-
> drivers/scsi/mpt2sas/mpt2sas_scsih.c |6 --
> drivers/scsi/mpt3sas/mpt3sas_scsih.c |   10 +++---
> 4 files changed, 17 insertions(+), 10 deletions(-)
>
>--
>1.7.10.4
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body
>of a message to majord...@vger.kernel.org More majordomo info at
>http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/4] mpt2/mpt3 static checker fixups

2014-06-02 Thread Joe Lawrence 
On Mon, 2 Jun 2014 09:33:07 -0700
Christoph Hellwig  wrote:

> On Mon, Jun 02, 2014 at 10:34:28AM -0400, Joe Lawrence wrote:
> > Hello Sreekanth, Dan,
> > 
> > These are a few minor smatch and sparse static checker fixes for the LSI
> > mpt2 and mpt3 drivers.  The first three fix real potential bugs and the
> > last cleans up a noisy complaint from sparse.
> 
> Can you check if any of these also applies to drivers/message/fusion?
> There is tons of copy & paste between all three drivers unfortunately.

The fixes in this patchset don't apply to drivers/message/fusion,
however there are a half-dozen or so warnings that I could take a look
at if the driver is still maintained.

-- Joe
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/4] mpt2/mpt3 static checker fixups

2014-06-02 Thread Christoph Hellwig 
On Mon, Jun 02, 2014 at 10:34:28AM -0400, Joe Lawrence wrote:
> Hello Sreekanth, Dan,
> 
> These are a few minor smatch and sparse static checker fixes for the LSI
> mpt2 and mpt3 drivers.  The first three fix real potential bugs and the
> last cleans up a noisy complaint from sparse.

Can you check if any of these also applies to drivers/message/fusion?
There is tons of copy & paste between all three drivers unfortunately.

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 0/4] mpt2/mpt3 static checker fixups

2014-06-02 Thread Joe Lawrence 
Hello Sreekanth, Dan,

These are a few minor smatch and sparse static checker fixes for the LSI
mpt2 and mpt3 drivers.  The first three fix real potential bugs and the
last cleans up a noisy complaint from sparse.

Joe Lawrence (4):
  mpt2sas: correct scsi_{target,device} hostdata allocation
  mpt3sas: correct scsi_{target,device} hostdata allocation
  mpt3sas: fix possible memory leak in mpt3sas_send_trigger_data_event
  mpt2sas: annotate ioc->reply_post_host_index as __iomem

 drivers/scsi/mpt2sas/mpt2sas_base.c  |9 +
 drivers/scsi/mpt2sas/mpt2sas_base.h  |2 +-
 drivers/scsi/mpt2sas/mpt2sas_scsih.c |6 --
 drivers/scsi/mpt3sas/mpt3sas_scsih.c |   10 +++---
 4 files changed, 17 insertions(+), 10 deletions(-)

-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html