Re: [PATCH 01/29] ncr5380: Use printk() not pr_debug()

[Hannes Reinecke]

On 10/02/2014 08:56 AM, Finn Thain wrote:
 Having defined NDEBUG, and having set the console log level, I'd like to see
 some output. Don't use pr_debug(), it's annoying to have to define DEBUG as
 well.
 
 Signed-off-by: Finn Thain fth...@telegraphics.com.au
 
 ---
 
 Use of pr_debug() here was a bad idea of mine. Joe was right when
 he questioned it.
 
Reviewed-by: Hannes Reinecke h...@suse.de

Cheers,

Hannes
-- 
Dr. Hannes Reinecke   zSeries  Storage
h...@suse.de  +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 01/29] ncr5380: Use printk() not pr_debug()

[Finn Thain]

Having defined NDEBUG, and having set the console log level, I'd like to see
some output. Don't use pr_debug(), it's annoying to have to define DEBUG as
well.

Signed-off-by: Finn Thain fth...@telegraphics.com.au

---

Use of pr_debug() here was a bad idea of mine. Joe was right when
he questioned it.

---
 drivers/scsi/NCR5380.h |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Index: linux/drivers/scsi/NCR5380.h
===
--- linux.orig/drivers/scsi/NCR5380.h   2014-10-02 16:55:29.0 +1000
+++ linux/drivers/scsi/NCR5380.h2014-10-02 16:55:49.0 +1000
@@ -296,7 +296,8 @@ struct NCR5380_hostdata {
 #endif
 
 #define dprintk(flg, fmt, ...) \
-   do { if ((NDEBUG)  (flg)) pr_debug(fmt, ## __VA_ARGS__); } while (0)
+   do { if ((NDEBUG)  (flg)) \
+   printk(KERN_DEBUG fmt, ## __VA_ARGS__); } while (0)
 
 #if NDEBUG
 #define NCR5380_dprint(flg, arg) \


--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html