Re: [PATCH 05/30] blk_end_request: changing um (take 4)

2007-12-12 Thread Jeff Dike
On Tue, Dec 11, 2007 at 05:42:53PM -0500, Kiyoshi Ueda wrote:
 This patch converts um to use blk_end_request interfaces.
 Related 'uptodate' arguments are converted to 'error'.
 
 As a result, the interface of internal function, ubd_end_request(),
 is changed.

Looks OK to me...

Jeff

-- 
Work email - jdike at linux dot intel dot com
-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH 05/30] blk_end_request: changing um (take 4)

2007-12-11 Thread Kiyoshi Ueda
This patch converts um to use blk_end_request interfaces.
Related 'uptodate' arguments are converted to 'error'.

As a result, the interface of internal function, ubd_end_request(),
is changed.

Cc: Jeff Dike [EMAIL PROTECTED]
Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED]
Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED]
---
 arch/um/drivers/ubd_kern.c |   16 
 1 files changed, 4 insertions(+), 12 deletions(-)

Index: 2.6.24-rc4/arch/um/drivers/ubd_kern.c
===
--- 2.6.24-rc4.orig/arch/um/drivers/ubd_kern.c
+++ 2.6.24-rc4/arch/um/drivers/ubd_kern.c
@@ -475,17 +475,9 @@ static void do_ubd_request(struct reques
 /* Only changed by ubd_init, which is an initcall. */
 int thread_fd = -1;
 
-static void ubd_end_request(struct request *req, int bytes, int uptodate)
+static void ubd_end_request(struct request *req, int bytes, int error)
 {
-   if (!end_that_request_first(req, uptodate, bytes  9)) {
-   struct ubd *dev = req-rq_disk-private_data;
-   unsigned long flags;
-
-   add_disk_randomness(req-rq_disk);
-   spin_lock_irqsave(dev-lock, flags);
-   end_that_request_last(req, uptodate);
-   spin_unlock_irqrestore(dev-lock, flags);
-   }
+   blk_end_request(req, error, bytes);
 }
 
 /* Callable only from interrupt context - otherwise you need to do
@@ -493,10 +485,10 @@ static void ubd_end_request(struct reque
 static inline void ubd_finish(struct request *req, int bytes)
 {
if(bytes  0){
-   ubd_end_request(req, 0, 0);
+   ubd_end_request(req, 0, -EIO);
return;
}
-   ubd_end_request(req, bytes, 1);
+   ubd_end_request(req, bytes, 0);
 }
 
 static LIST_HEAD(restart);
-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html