Re: [PATCH 05/32] target: Rename some list heads used as nodes

2013-12-16 Thread Nicholas A. Bellinger
On Fri, 2013-12-13 at 15:58 -0800, Andy Grover wrote:
 Since everything's a list_head, naming it _node makes it clearer it's
 to put the struct on a list, not a list head itself.
 
 Rename ua_nacl_list to ua_nacl_node
 Rename alua_port_list to alua_port_node
 Rename lu_gp_mem_list to lu_gp_mem_node
 Rename tg_pt_gp_mem_list to tg_pt_gp_mem_node
 Rename sep_list to sep_node
 Rename tg_pt_gp_list to tg_pt_gp_node
 Rename se_session sess_list to sess_node
 Rename se_node_acl acl_list to acl_node
 
 Signed-off-by: Andy Grover agro...@redhat.com
 ---
  drivers/target/iscsi/iscsi_target.c   |2 +-
  drivers/target/iscsi/iscsi_target_login.c |4 +-
  drivers/target/sbp/sbp_target.c   |6 ++--
  drivers/target/target_core_alua.c |   52 ++--
  drivers/target/target_core_configfs.c |4 +-
  drivers/target/target_core_device.c   |   18 +-
  drivers/target/target_core_pr.c   |8 ++--
  drivers/target/target_core_tpg.c  |   20 +-
  drivers/target/target_core_transport.c|8 ++--
  drivers/target/target_core_ua.c   |   28 
  drivers/target/target_core_xcopy.c|6 ++--
  drivers/target/tcm_fc/tfc_conf.c  |2 +-
  include/target/target_core_base.h |   16 
  13 files changed, 87 insertions(+), 87 deletions(-)

Holding off on this one for the moment, as it conflict's with Hannes's
patches for ALUA + Referrals.

--nab

--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH 05/32] target: Rename some list heads used as nodes

2013-12-13 Thread Andy Grover
Since everything's a list_head, naming it _node makes it clearer it's
to put the struct on a list, not a list head itself.

Rename ua_nacl_list to ua_nacl_node
Rename alua_port_list to alua_port_node
Rename lu_gp_mem_list to lu_gp_mem_node
Rename tg_pt_gp_mem_list to tg_pt_gp_mem_node
Rename sep_list to sep_node
Rename tg_pt_gp_list to tg_pt_gp_node
Rename se_session sess_list to sess_node
Rename se_node_acl acl_list to acl_node

Signed-off-by: Andy Grover agro...@redhat.com
---
 drivers/target/iscsi/iscsi_target.c   |2 +-
 drivers/target/iscsi/iscsi_target_login.c |4 +-
 drivers/target/sbp/sbp_target.c   |6 ++--
 drivers/target/target_core_alua.c |   52 ++--
 drivers/target/target_core_configfs.c |4 +-
 drivers/target/target_core_device.c   |   18 +-
 drivers/target/target_core_pr.c   |8 ++--
 drivers/target/target_core_tpg.c  |   20 +-
 drivers/target/target_core_transport.c|8 ++--
 drivers/target/target_core_ua.c   |   28 
 drivers/target/target_core_xcopy.c|6 ++--
 drivers/target/tcm_fc/tfc_conf.c  |2 +-
 include/target/target_core_base.h |   16 
 13 files changed, 87 insertions(+), 87 deletions(-)

diff --git a/drivers/target/iscsi/iscsi_target.c 
b/drivers/target/iscsi/iscsi_target.c
index d70e911..2844aff 100644
--- a/drivers/target/iscsi/iscsi_target.c
+++ b/drivers/target/iscsi/iscsi_target.c
@@ -4703,7 +4703,7 @@ int iscsit_release_sessions_for_tpg(struct 
iscsi_portal_group *tpg, int force)
}
 
list_for_each_entry_safe(se_sess, se_sess_tmp, se_tpg-tpg_sess_list,
-   sess_list) {
+   sess_node) {
sess = (struct iscsi_session *)se_sess-fabric_sess_ptr;
 
spin_lock(sess-conn_lock);
diff --git a/drivers/target/iscsi/iscsi_target_login.c 
b/drivers/target/iscsi/iscsi_target_login.c
index 4eb93b2..99cd298 100644
--- a/drivers/target/iscsi/iscsi_target_login.c
+++ b/drivers/target/iscsi/iscsi_target_login.c
@@ -180,7 +180,7 @@ int iscsi_check_for_session_reinstatement(struct iscsi_conn 
*conn)
 
spin_lock_bh(se_tpg-session_lock);
list_for_each_entry_safe(se_sess, se_sess_tmp, se_tpg-tpg_sess_list,
-   sess_list) {
+   sess_node) {
 
sess_p = se_sess-fabric_sess_ptr;
spin_lock(sess_p-conn_lock);
@@ -534,7 +534,7 @@ static int iscsi_login_non_zero_tsih_s2(
 
spin_lock_bh(se_tpg-session_lock);
list_for_each_entry_safe(se_sess, se_sess_tmp, se_tpg-tpg_sess_list,
-   sess_list) {
+   sess_node) {
 
sess_p = (struct iscsi_session *)se_sess-fabric_sess_ptr;
if (atomic_read(sess_p-session_fall_back_to_erl0) ||
diff --git a/drivers/target/sbp/sbp_target.c b/drivers/target/sbp/sbp_target.c
index 24884ca..e1ceae5 100644
--- a/drivers/target/sbp/sbp_target.c
+++ b/drivers/target/sbp/sbp_target.c
@@ -99,7 +99,7 @@ static struct sbp_session *sbp_session_find_by_guid(
struct sbp_session *sess, *found = NULL;
 
spin_lock_bh(tpg-se_tpg.session_lock);
-   list_for_each_entry(se_sess, tpg-se_tpg.tpg_sess_list, sess_list) {
+   list_for_each_entry(se_sess, tpg-se_tpg.tpg_sess_list, sess_node) {
sess = se_sess-fabric_sess_ptr;
if (sess-guid == guid)
found = sess;
@@ -135,7 +135,7 @@ static int sbp_login_count_all_by_lun(
int count = 0;
 
spin_lock_bh(tpg-se_tpg.session_lock);
-   list_for_each_entry(se_sess, tpg-se_tpg.tpg_sess_list, sess_list) {
+   list_for_each_entry(se_sess, tpg-se_tpg.tpg_sess_list, sess_node) {
sess = se_sess-fabric_sess_ptr;
 
spin_lock_bh(sess-lock);
@@ -161,7 +161,7 @@ static struct sbp_login_descriptor *sbp_login_find_by_id(
struct sbp_login_descriptor *login, *found = NULL;
 
spin_lock_bh(tpg-se_tpg.session_lock);
-   list_for_each_entry(se_sess, tpg-se_tpg.tpg_sess_list, sess_list) {
+   list_for_each_entry(se_sess, tpg-se_tpg.tpg_sess_list, sess_node) {
sess = se_sess-fabric_sess_ptr;
 
spin_lock_bh(sess-lock);
diff --git a/drivers/target/target_core_alua.c 
b/drivers/target/target_core_alua.c
index fdcee32..2ac2f11 100644
--- a/drivers/target/target_core_alua.c
+++ b/drivers/target/target_core_alua.c
@@ -91,7 +91,7 @@ target_emulate_report_target_port_groups(struct se_cmd *cmd)
 
spin_lock(dev-t10_alua.tg_pt_gps_lock);
list_for_each_entry(tg_pt_gp, dev-t10_alua.tg_pt_gps_list,
-   tg_pt_gp_list) {
+   tg_pt_gp_node) {
/*
 * Check if the Target port group and Target port descriptor 
list
 * based on tg_pt_gp_members count will fit into the response 
payload.
@@ -141,7