Re: [PATCH 07/71] ncr5380: Split NCR5380_init() into two functions

2015-11-19 Thread Hannes Reinecke 
On 11/18/2015 09:35 AM, Finn Thain wrote:
> This patch splits the NCR5380_init() function into two parts, similar
> to the scheme used with atari_NCR5380.c. This avoids two problems.
> 
> Firstly, NCR5380_init() may perform a bus reset, which would cause the
> chip to assert IRQ. The chip is unable to mask its bus reset interrupt.
> Drivers can't call request_irq() before calling NCR5380_init(), because
> initialization must happen before the interrupt handler executes. If
> driver initialization causes an interrupt it may be problematic on some
> platforms. To avoid that, first move the bus reset code into
> NCR5380_maybe_reset_bus().
> 
> Secondly, NCR5380_init() contains some board-specific interrupt setup code
> for the NCR53C400 that does not belong in the core driver. In moving this
> code, better not re-order interrupt initialization and bus reset. Again,
> the solution is to move the bus reset code into NCR5380_maybe_reset_bus().
> 
> Signed-off-by: Finn Thain 
> 
Reviewed-by: Hannes Reinecke 

Cheers,

Hannes
-- 
Dr. Hannes ReineckezSeries & Storage
h...@suse.de   +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 07/71] ncr5380: Split NCR5380_init() into two functions

2015-11-18 Thread Finn Thain 
This patch splits the NCR5380_init() function into two parts, similar
to the scheme used with atari_NCR5380.c. This avoids two problems.

Firstly, NCR5380_init() may perform a bus reset, which would cause the
chip to assert IRQ. The chip is unable to mask its bus reset interrupt.
Drivers can't call request_irq() before calling NCR5380_init(), because
initialization must happen before the interrupt handler executes. If
driver initialization causes an interrupt it may be problematic on some
platforms. To avoid that, first move the bus reset code into
NCR5380_maybe_reset_bus().

Secondly, NCR5380_init() contains some board-specific interrupt setup code
for the NCR53C400 that does not belong in the core driver. In moving this
code, better not re-order interrupt initialization and bus reset. Again,
the solution is to move the bus reset code into NCR5380_maybe_reset_bus().

Signed-off-by: Finn Thain 

---
 drivers/scsi/NCR5380.c  |   34 --
 drivers/scsi/NCR5380.h  |1 +
 drivers/scsi/arm/cumana_1.c |2 ++
 drivers/scsi/arm/oak.c  |2 ++
 drivers/scsi/dmx3191d.c |2 ++
 drivers/scsi/dtc.c  |2 ++
 drivers/scsi/g_NCR5380.c|2 ++
 drivers/scsi/pas16.c|2 ++
 drivers/scsi/t128.c |2 ++
 9 files changed, 35 insertions(+), 14 deletions(-)

Index: linux/drivers/scsi/NCR5380.c
===
--- linux.orig/drivers/scsi/NCR5380.c   2015-11-18 19:33:09.0 +1100
+++ linux/drivers/scsi/NCR5380.c2015-11-18 19:33:10.0 +1100
@@ -777,8 +777,7 @@ static void lprint_opcode(int opcode, st
 
 static int NCR5380_init(struct Scsi_Host *instance, int flags)
 {
-   int i, pass;
-   unsigned long timeout;
+   int i;
struct NCR5380_hostdata *hostdata = (struct NCR5380_hostdata *) 
instance->hostdata;
 
if(in_interrupt())
@@ -831,18 +830,26 @@ static int NCR5380_init(struct Scsi_Host
NCR5380_write(C400_CONTROL_STATUS_REG, CSR_BASE);
}
 #endif
+   return 0;
+}
 
-   /* 
-* Detect and correct bus wedge problems.
-*
-* If the system crashed, it may have crashed in a state 
-* where a SCSI command was still executing, and the 
-* SCSI bus is not in a BUS FREE STATE.
-*
-* If this is the case, we'll try to abort the currently
-* established nexus which we know nothing about, and that
-* failing, do a hard reset of the SCSI bus 
-*/
+/**
+ * NCR5380_maybe_reset_bus - Detect and correct bus wedge problems.
+ * @instance: adapter to check
+ *
+ * If the system crashed, it may have crashed with a connected target and
+ * the SCSI bus busy. Check for BUS FREE phase. If not, try to abort the
+ * currently established nexus, which we know nothing about. Failing that
+ * do a bus reset.
+ *
+ * Note that a bus reset will cause the chip to assert IRQ.
+ *
+ * Returns 0 if successful, otherwise -ENXIO.
+ */
+
+static int NCR5380_maybe_reset_bus(struct Scsi_Host *instance)
+{
+   int pass;
 
for (pass = 1; (NCR5380_read(STATUS_REG) & SR_BSY) && pass <= 6; 
++pass) {
switch (pass) {
@@ -850,7 +857,6 @@ static int NCR5380_init(struct Scsi_Host
case 3:
case 5:
printk(KERN_INFO "scsi%d: SCSI bus busy, waiting up to 
five seconds\n", instance->host_no);
-   timeout = jiffies + 5 * HZ;
NCR5380_poll_politely(instance, STATUS_REG, SR_BSY, 0, 
5*HZ);
break;
case 2:
Index: linux/drivers/scsi/NCR5380.h
===
--- linux.orig/drivers/scsi/NCR5380.h   2015-11-18 19:33:04.0 +1100
+++ linux/drivers/scsi/NCR5380.h2015-11-18 19:33:10.0 +1100
@@ -318,6 +318,7 @@ static void NCR5380_print(struct Scsi_Ho
 static int NCR5380_probe_irq(struct Scsi_Host *instance, int possible);
 #endif
 static int NCR5380_init(struct Scsi_Host *instance, int flags);
+static int NCR5380_maybe_reset_bus(struct Scsi_Host *);
 static void NCR5380_exit(struct Scsi_Host *instance);
 static void NCR5380_information_transfer(struct Scsi_Host *instance);
 #ifndef DONT_USE_INTR
Index: linux/drivers/scsi/arm/cumana_1.c
===
--- linux.orig/drivers/scsi/arm/cumana_1.c  2015-11-18 19:33:05.0 
+1100
+++ linux/drivers/scsi/arm/cumana_1.c   2015-11-18 19:33:10.0 +1100
@@ -240,6 +240,8 @@ static int cumanascsi1_probe(struct expa
 
NCR5380_init(host, 0);
 
+   NCR5380_maybe_reset_bus(host);
+
 priv(host)->ctrl = 0;
 writeb(0, priv(host)->base + CTRL);
 
Index: linux/drivers/scsi/arm/oak.c
===
--- linux.orig/drivers/scsi/arm/oak.c   2015-11-18