Re: [PATCH 09/28] blk_end_request: changing ps3disk (take 3)

2007-12-03 Thread Kiyoshi Ueda 
Hi Geert,

On Sun, 2 Dec 2007 10:34:56 +0100 (CET), Geert Uytterhoeven [EMAIL PROTECTED] 
wrote:
 On Fri, 30 Nov 2007, Kiyoshi Ueda wrote:
  This patch converts ps3disk to use blk_end_request().
  ^^^
 Patch subject and description are inconsistent with actual change.
 
  Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED]
  Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED]
  ---
   drivers/block/ps3disk.c |6 +-
   1 files changed, 1 insertion(+), 5 deletions(-)
  
  Index: 2.6.24-rc3-mm2/drivers/block/ps3disk.c
  ===
  --- 2.6.24-rc3-mm2.orig/drivers/block/ps3disk.c
  +++ 2.6.24-rc3-mm2/drivers/block/ps3disk.c
  @@ -280,11 +280,7 @@ static irqreturn_t ps3disk_interrupt(int
  }
   
  spin_lock(priv-lock);
  -   if (!end_that_request_first(req, uptodate, num_sectors)) {
  -   add_disk_randomness(req-rq_disk);
  -   blkdev_dequeue_request(req);
  -   end_that_request_last(req, uptodate);
  -   }
  +   __blk_end_request(req, uptodate, num_sectors  9);
   ^

Thank you for the comment.
The description meant the blk_end_request family, not actual function,
blk_end_request().  But as you pointed out, it is misleading.
I'll change the description of all related patches.

Thanks,
Kiyoshi Ueda
-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 09/28] blk_end_request: changing ps3disk (take 3)

2007-12-02 Thread Geert Uytterhoeven 
On Fri, 30 Nov 2007, Kiyoshi Ueda wrote:
 This patch converts ps3disk to use blk_end_request().
 ^^^
Patch subject and description are inconsistent with actual change.

 Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED]
 Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED]
 ---
  drivers/block/ps3disk.c |6 +-
  1 files changed, 1 insertion(+), 5 deletions(-)
 
 Index: 2.6.24-rc3-mm2/drivers/block/ps3disk.c
 ===
 --- 2.6.24-rc3-mm2.orig/drivers/block/ps3disk.c
 +++ 2.6.24-rc3-mm2/drivers/block/ps3disk.c
 @@ -280,11 +280,7 @@ static irqreturn_t ps3disk_interrupt(int
   }
  
   spin_lock(priv-lock);
 - if (!end_that_request_first(req, uptodate, num_sectors)) {
 - add_disk_randomness(req-rq_disk);
 - blkdev_dequeue_request(req);
 - end_that_request_last(req, uptodate);
 - }
 + __blk_end_request(req, uptodate, num_sectors  9);
^

With kind regards,
 
Geert Uytterhoeven
Software Architect

Sony Network and Software Technology Center Europe
The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium
 
Phone:+32 (0)2 700 8453 
Fax:  +32 (0)2 700 8622 
E-mail:   [EMAIL PROTECTED] 
Internet: http://www.sony-europe.com/

Sony Network and Software Technology Center Europe  
A division of Sony Service Centre (Europe) N.V. 
Registered office: Technologielaan 7 · B-1840 Londerzeel · Belgium  
VAT BE 0413.825.160 · RPR Brussels  
Fortis Bank Zaventem · Swift GEBABEBB08A · IBAN BE39001382358619

[PATCH 09/28] blk_end_request: changing ps3disk (take 3)

2007-11-30 Thread Kiyoshi Ueda 
This patch converts ps3disk to use blk_end_request().

Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED]
Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED]
---
 drivers/block/ps3disk.c |6 +-
 1 files changed, 1 insertion(+), 5 deletions(-)

Index: 2.6.24-rc3-mm2/drivers/block/ps3disk.c
===
--- 2.6.24-rc3-mm2.orig/drivers/block/ps3disk.c
+++ 2.6.24-rc3-mm2/drivers/block/ps3disk.c
@@ -280,11 +280,7 @@ static irqreturn_t ps3disk_interrupt(int
}
 
spin_lock(priv-lock);
-   if (!end_that_request_first(req, uptodate, num_sectors)) {
-   add_disk_randomness(req-rq_disk);
-   blkdev_dequeue_request(req);
-   end_that_request_last(req, uptodate);
-   }
+   __blk_end_request(req, uptodate, num_sectors  9);
priv-req = NULL;
ps3disk_do_request(dev, priv-queue);
spin_unlock(priv-lock);
-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html