Re: [PATCH 09/28] hptiop: Simplify reset handling

2017-06-28 Thread Johannes Thumshirn

Reviewed-by: Johannes Thumshirn 
-- 
Johannes Thumshirn  Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850


[PATCH 09/28] hptiop: Simplify reset handling

2017-06-28 Thread Hannes Reinecke
The Highpoint driver only has one reset function, and that is
a host reset. So stop pretending we're doing anything else.

Signed-off-by: Hannes Reinecke 
Reviewed-by: Christoph Hellwig 
---
 drivers/scsi/hptiop.c | 11 ---
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/drivers/scsi/hptiop.c b/drivers/scsi/hptiop.c
index 7226226..2fad7f0 100644
--- a/drivers/scsi/hptiop.c
+++ b/drivers/scsi/hptiop.c
@@ -1106,12 +1106,10 @@ static int hptiop_reset_hba(struct hptiop_hba *hba)
 
 static int hptiop_reset(struct scsi_cmnd *scp)
 {
-   struct Scsi_Host * host = scp->device->host;
-   struct hptiop_hba * hba = (struct hptiop_hba *)host->hostdata;
+   struct hptiop_hba * hba = (struct hptiop_hba 
*)scp->device->host->hostdata;
 
-   printk(KERN_WARNING "hptiop_reset(%d/%d/%d) scp=%p\n",
-   scp->device->host->host_no, scp->device->channel,
-   scp->device->id, scp);
+   printk(KERN_WARNING "hptiop_reset(%d/%d/%d)\n",
+  scp->device->host->host_no, -1, -1);
 
return hptiop_reset_hba(hba)? FAILED : SUCCESS;
 }
@@ -1179,8 +1177,7 @@ static int hptiop_slave_config(struct scsi_device *sdev)
.module = THIS_MODULE,
.name   = driver_name,
.queuecommand   = hptiop_queuecommand,
-   .eh_device_reset_handler= hptiop_reset,
-   .eh_bus_reset_handler   = hptiop_reset,
+   .eh_host_reset_handler  = hptiop_reset,
.info   = hptiop_info,
.emulated   = 0,
.use_clustering = ENABLE_CLUSTERING,
-- 
1.8.5.6