Re: [PATCH 1/3] scsi_transport_iscsi: Declare portal type string macros for generic use

2013-04-11 Thread James Bottomley 
On Mon, 2013-03-25 at 20:37 -0500, Mike Christie wrote:
 Patches 1 - 3 look ok to me.

it looks like we're missing a patch 3/3?

James

--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/3] scsi_transport_iscsi: Declare portal type string macros for generic use

2013-03-25 Thread vikas . chaudhary 
From: Adheer Chandravanshi adheer.chandravan...@qlogic.com

Signed-off-by: Adheer Chandravanshi adheer.chandravan...@qlogic.com
Signed-off-by: Vikas Chaudhary vikas.chaudh...@qlogic.com
---
 include/scsi/iscsi_if.h | 4 
 1 file changed, 4 insertions(+)

diff --git a/include/scsi/iscsi_if.h b/include/scsi/iscsi_if.h
index f1b0183..fe7f06c 100644
--- a/include/scsi/iscsi_if.h
+++ b/include/scsi/iscsi_if.h
@@ -504,6 +504,10 @@ enum iscsi_host_param {
ISCSI_HOST_PARAM_MAX,
 };
 
+/* portal type */
+#define PORTAL_TYPE_IPV4   ipv4
+#define PORTAL_TYPE_IPV6   ipv6
+
 /* iSCSI Flash Target params */
 enum iscsi_flashnode_param {
ISCSI_FLASHNODE_IS_FW_ASSIGNED_IPV6,
-- 
1.8.2.GIT

--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] scsi_transport_iscsi: Declare portal type string macros for generic use

2013-03-25 Thread Mike Christie 
Patches 1 - 3 look ok to me.

Reviewed-by: Mike Christie micha...@cs.wisc.edu

On 03/25/2013 07:08 AM, vikas.chaudh...@qlogic.com wrote:
 From: Adheer Chandravanshi adheer.chandravan...@qlogic.com
 
 Signed-off-by: Adheer Chandravanshi adheer.chandravan...@qlogic.com
 Signed-off-by: Vikas Chaudhary vikas.chaudh...@qlogic.com
 ---
  include/scsi/iscsi_if.h | 4 
  1 file changed, 4 insertions(+)
 
 diff --git a/include/scsi/iscsi_if.h b/include/scsi/iscsi_if.h
 index f1b0183..fe7f06c 100644
 --- a/include/scsi/iscsi_if.h
 +++ b/include/scsi/iscsi_if.h
 @@ -504,6 +504,10 @@ enum iscsi_host_param {
   ISCSI_HOST_PARAM_MAX,
  };
  
 +/* portal type */
 +#define PORTAL_TYPE_IPV4 ipv4
 +#define PORTAL_TYPE_IPV6 ipv6
 +
  /* iSCSI Flash Target params */
  enum iscsi_flashnode_param {
   ISCSI_FLASHNODE_IS_FW_ASSIGNED_IPV6,
 

--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html