RE: [PATCH 1/7] Removing the iscsi_data_pdu setting.

[Jayamohan.Kallickal]

From: Michael Christie [micha...@cs.wisc.edu]
Sent: Monday, August 13, 2012 11:41 AM
To: John, Sony
Cc: linux-scsi@vger.kernel.org; Kallickal, Jayamohan
Subject: Re: [PATCH 1/7] Removing the iscsi_data_pdu setting.

On Aug 13, 2012, at 5:29 AM, John Soni Jose  wrote:

> The setting of iscsi_data_pdu is not required anymore,
> as this was required for BE1 adapters only.
>

>Were those released and supported by the upstream kernel in previous kernels?


The BE1 cards were never supported in any previous versions of the Kernel. So, 
there is no risk here

-Jay--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/7] Removing the iscsi_data_pdu setting.

[Michael Christie]

On Aug 13, 2012, at 5:29 AM, John Soni Jose  wrote:

> The setting of iscsi_data_pdu is not required anymore,
> as this was required for BE1 adapters only.
> 

Were those released and supported by the upstream kernel in previous kernels?
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/7] Removing the iscsi_data_pdu setting.

[John Soni Jose]

 The setting of iscsi_data_pdu is not required anymore,
 as this was required for BE1 adapters only.

Signed-off-by: John Soni Jose 
Signed-off-by: Jayamohan Kallickal 
---
 drivers/scsi/be2iscsi/be_main.c |   12 
 1 files changed, 0 insertions(+), 12 deletions(-)

diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c
index 0b1d99c..2cdae08 100644
--- a/drivers/scsi/be2iscsi/be_main.c
+++ b/drivers/scsi/be2iscsi/be_main.c
@@ -3981,15 +3981,6 @@ static int beiscsi_iotask(struct iscsi_task *task, 
struct scatterlist *sg,
io_task->bhs_len = sizeof(struct be_cmd_bhs);
 
if (writedir) {
-   memset(&io_task->cmd_bhs->iscsi_data_pdu, 0, 48);
-   AMAP_SET_BITS(struct amap_pdu_data_out, itt,
- &io_task->cmd_bhs->iscsi_data_pdu,
- (unsigned int)io_task->cmd_bhs->iscsi_hdr.itt);
-   AMAP_SET_BITS(struct amap_pdu_data_out, opcode,
- &io_task->cmd_bhs->iscsi_data_pdu,
- ISCSI_OPCODE_SCSI_DATA_OUT);
-   AMAP_SET_BITS(struct amap_pdu_data_out, final_bit,
- &io_task->cmd_bhs->iscsi_data_pdu, 1);
AMAP_SET_BITS(struct amap_iscsi_wrb, type, pwrb,
  INI_WR_CMD);
AMAP_SET_BITS(struct amap_iscsi_wrb, dsp, pwrb, 1);
@@ -3998,9 +3989,6 @@ static int beiscsi_iotask(struct iscsi_task *task, struct 
scatterlist *sg,
  INI_RD_CMD);
AMAP_SET_BITS(struct amap_iscsi_wrb, dsp, pwrb, 0);
}
-   memcpy(&io_task->cmd_bhs->iscsi_data_pdu.
-  dw[offsetof(struct amap_pdu_data_out, lun) / 32],
-  &io_task->cmd_bhs->iscsi_hdr.lun, sizeof(struct scsi_lun));
 
AMAP_SET_BITS(struct amap_iscsi_wrb, lun, pwrb,
  cpu_to_be16(*(unsigned short *)
-- 
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html