Re: [PATCH 13/19] libiscsi: Fix indentation

2017-08-25 Thread Hannes Reinecke 
On 08/23/2017 11:40 PM, Bart Van Assche wrote:
> This patch avoids that smatch reports the following:
> 
> drivers/scsi/libiscsi.c:1081: iscsi_handle_reject() warn: inconsistent 
> indenting
> 
> Signed-off-by: Bart Van Assche 
> Cc: Christoph Hellwig 
> Cc: Hannes Reinecke 
> Cc: Johannes Thumshirn 
> ---
>  drivers/scsi/libiscsi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
> index 42381adf0769..bd4605a34f54 100644
> --- a/drivers/scsi/libiscsi.c
> +++ b/drivers/scsi/libiscsi.c
> @@ -1078,7 +1078,7 @@ static int iscsi_handle_reject(struct iscsi_conn *conn, 
> struct iscsi_hdr *hdr,
>   if (opcode != ISCSI_OP_NOOP_OUT)
>   return 0;
>  
> -  if (rejected_pdu.itt == cpu_to_be32(ISCSI_RESERVED_TAG)) {
> + if (rejected_pdu.itt == cpu_to_be32(ISCSI_RESERVED_TAG)) {
>   /*
>* nop-out in response to target's nop-out rejected.
>* Just resend.
> 
Reviewed-by: Hannes Reinecke 

Cheers,

Hannes
-- 
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de   +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)

Re: [PATCH 13/19] libiscsi: Fix indentation

2017-08-24 Thread Christoph Hellwig 
Looks good,

Reviewed-by: Christoph Hellwig

[PATCH 13/19] libiscsi: Fix indentation

2017-08-23 Thread Bart Van Assche 
This patch avoids that smatch reports the following:

drivers/scsi/libiscsi.c:1081: iscsi_handle_reject() warn: inconsistent indenting

Signed-off-by: Bart Van Assche 
Cc: Christoph Hellwig 
Cc: Hannes Reinecke 
Cc: Johannes Thumshirn 
---
 drivers/scsi/libiscsi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
index 42381adf0769..bd4605a34f54 100644
--- a/drivers/scsi/libiscsi.c
+++ b/drivers/scsi/libiscsi.c
@@ -1078,7 +1078,7 @@ static int iscsi_handle_reject(struct iscsi_conn *conn, 
struct iscsi_hdr *hdr,
if (opcode != ISCSI_OP_NOOP_OUT)
return 0;
 
-if (rejected_pdu.itt == cpu_to_be32(ISCSI_RESERVED_TAG)) {
+   if (rejected_pdu.itt == cpu_to_be32(ISCSI_RESERVED_TAG)) {
/*
 * nop-out in response to target's nop-out rejected.
 * Just resend.
-- 
2.14.0