Re: [PATCH 13/71] ncr5380: Remove redundant register writes

2015-11-19 Thread Hannes Reinecke 
On 11/18/2015 09:35 AM, Finn Thain wrote:
> Remove the duplicate write to the Select Enable Register that appeared
> in v1.1.38.
> 
> Also remove the redundant write to Initiator Command Register prior to
> calling do_abort().
> 
> Signed-off-by: Finn Thain 
> 
> ---
Reviewed-by: Hannes Reinecke 

Cheers,

Hannes
-- 
Dr. Hannes ReineckezSeries & Storage
h...@suse.de   +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 13/71] ncr5380: Remove redundant register writes

2015-11-18 Thread Finn Thain 
Remove the duplicate write to the Select Enable Register that appeared
in v1.1.38.

Also remove the redundant write to Initiator Command Register prior to
calling do_abort().

Signed-off-by: Finn Thain 

---
 drivers/scsi/NCR5380.c   |2 --
 drivers/scsi/atari_NCR5380.c |3 ---
 2 files changed, 5 deletions(-)

Index: linux/drivers/scsi/NCR5380.c
===
--- linux.orig/drivers/scsi/NCR5380.c   2015-11-18 19:33:18.0 +1100
+++ linux/drivers/scsi/NCR5380.c2015-11-18 19:33:19.0 +1100
@@ -1384,7 +1384,6 @@ part2:
cmd->scsi_done(cmd);
NCR5380_write(SELECT_ENABLE_REG, hostdata->id_mask);
dprintk(NDEBUG_SELECTION, "scsi%d : target did not respond 
within 250ms\n", instance->host_no);
-   NCR5380_write(SELECT_ENABLE_REG, hostdata->id_mask);
return 0;
}
hostdata->targets_present |= (1 << scmd_id(cmd));
@@ -2076,7 +2075,6 @@ static void NCR5380_information_transfer
scmd_printk(KERN_INFO, cmd,
"switching to slow 
handshake\n");
cmd->device->borken = 1;
-   
NCR5380_write(INITIATOR_COMMAND_REG, ICR_BASE | ICR_ASSERT_ATN);
sink = 1;
do_abort(instance);
cmd->result = DID_ERROR << 16;
Index: linux/drivers/scsi/atari_NCR5380.c
===
--- linux.orig/drivers/scsi/atari_NCR5380.c 2015-11-18 19:33:18.0 
+1100
+++ linux/drivers/scsi/atari_NCR5380.c  2015-11-18 19:33:19.0 +1100
@@ -1640,7 +1640,6 @@ static int NCR5380_select(struct Scsi_Ho
cmd->scsi_done(cmd);
NCR5380_write(SELECT_ENABLE_REG, hostdata->id_mask);
dprintk(NDEBUG_SELECTION, "scsi%d: target did not respond 
within 250ms\n", HOSTNO);
-   NCR5380_write(SELECT_ENABLE_REG, hostdata->id_mask);
return 0;
}
 
@@ -2192,8 +2191,6 @@ static void NCR5380_information_transfer
scmd_printk(KERN_INFO, cmd,
"switching to slow 
handshake\n");
cmd->device->borken = 1;
-   
NCR5380_write(INITIATOR_COMMAND_REG, ICR_BASE |
-   ICR_ASSERT_ATN);
sink = 1;
do_abort(instance);
cmd->result = DID_ERROR << 16;


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html