Re: [PATCH 14/32] target: Remove extra percpu_ref_init

2013-12-16 Thread Nicholas A. Bellinger 
On Fri, 2013-12-13 at 15:59 -0800, Andy Grover wrote:
 lun-lun_ref is also initialized in core_tpg_post_addlun, so it doesn't
 need to be done in core_tpg_setup_virtual_lun0.
 
 Signed-off-by: Andy Grover agro...@redhat.com
 ---
  drivers/target/target_core_tpg.c |4 
  1 files changed, 0 insertions(+), 4 deletions(-)
 
 diff --git a/drivers/target/target_core_tpg.c 
 b/drivers/target/target_core_tpg.c
 index 8771b23..2f6df57 100644
 --- a/drivers/target/target_core_tpg.c
 +++ b/drivers/target/target_core_tpg.c
 @@ -658,10 +658,6 @@ static int core_tpg_setup_virtual_lun0(struct 
 se_portal_group *se_tpg)
   spin_lock_init(lun-lun_sep_lock);
   init_completion(lun-lun_ref_comp);
  
 - ret = percpu_ref_init(lun-lun_ref, core_tpg_lun_ref_release);
 - if (ret  0)
 - return ret;
 -
   ret = core_tpg_post_addlun(se_tpg, lun, lun_access, dev);
   if (ret  0) {
   percpu_ref_cancel_init(lun-lun_ref);

Applied to target-pending/queue, and will be including in the next -rc5
PULL request.

--nab

--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 14/32] target: Remove extra percpu_ref_init

2013-12-13 Thread Andy Grover 
lun-lun_ref is also initialized in core_tpg_post_addlun, so it doesn't
need to be done in core_tpg_setup_virtual_lun0.

Signed-off-by: Andy Grover agro...@redhat.com
---
 drivers/target/target_core_tpg.c |4 
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/drivers/target/target_core_tpg.c b/drivers/target/target_core_tpg.c
index 8771b23..2f6df57 100644
--- a/drivers/target/target_core_tpg.c
+++ b/drivers/target/target_core_tpg.c
@@ -658,10 +658,6 @@ static int core_tpg_setup_virtual_lun0(struct 
se_portal_group *se_tpg)
spin_lock_init(lun-lun_sep_lock);
init_completion(lun-lun_ref_comp);
 
-   ret = percpu_ref_init(lun-lun_ref, core_tpg_lun_ref_release);
-   if (ret  0)
-   return ret;
-
ret = core_tpg_post_addlun(se_tpg, lun, lun_access, dev);
if (ret  0) {
percpu_ref_cancel_init(lun-lun_ref);
-- 
1.7.1

--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html