[PATCH 15/32] target: Refer to u32 luns as unpacked_lun

2013-12-13 Thread Andy Grover 
It's clearer to refer to pointers to the struct se_lun as "lun" and the
actual number itself as "unpacked_lun".

Signed-off-by: Andy Grover 
---
 drivers/target/target_core_device.c |   16 
 1 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/target/target_core_device.c 
b/drivers/target/target_core_device.c
index 7b5697a..da290f6 100644
--- a/drivers/target/target_core_device.c
+++ b/drivers/target/target_core_device.c
@@ -1096,23 +1096,23 @@ int se_dev_set_block_size(struct se_device *dev, u32 
block_size)
 struct se_lun *core_dev_add_lun(
struct se_portal_group *tpg,
struct se_device *dev,
-   u32 lun)
+   u32 unpacked_lun)
 {
-   struct se_lun *lun_p;
+   struct se_lun *lun;
int rc;
 
-   lun_p = core_tpg_pre_addlun(tpg, lun);
-   if (IS_ERR(lun_p))
-   return lun_p;
+   lun = core_tpg_pre_addlun(tpg, unpacked_lun);
+   if (IS_ERR(lun))
+   return lun;
 
-   rc = core_tpg_post_addlun(tpg, lun_p,
+   rc = core_tpg_post_addlun(tpg, lun,
TRANSPORT_LUNFLAGS_READ_WRITE, dev);
if (rc < 0)
return ERR_PTR(rc);
 
pr_debug("%s_TPG[%u]_LUN[%u] - Activated %s Logical Unit from"
" CORE HBA: %u\n", tpg->se_tpg_tfo->get_fabric_name(),
-   tpg->se_tpg_tfo->tpg_get_tag(tpg), lun_p->unpacked_lun,
+   tpg->se_tpg_tfo->tpg_get_tag(tpg), lun->unpacked_lun,
tpg->se_tpg_tfo->get_fabric_name(), dev->se_hba->hba_id);
/*
 * Update LUN maps for dynamically added initiators when
@@ -1133,7 +1133,7 @@ struct se_lun *core_dev_add_lun(
spin_unlock_irq(&tpg->acl_node_lock);
}
 
-   return lun_p;
+   return lun;
 }
 
 /*  core_dev_del_lun():
-- 
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 15/32] target: Refer to u32 luns as unpacked_lun

2013-12-16 Thread Nicholas A. Bellinger 
On Fri, 2013-12-13 at 15:59 -0800, Andy Grover wrote:
> It's clearer to refer to pointers to the struct se_lun as "lun" and the
> actual number itself as "unpacked_lun".
> 
> Signed-off-by: Andy Grover 
> ---
>  drivers/target/target_core_device.c |   16 
>  1 files changed, 8 insertions(+), 8 deletions(-)
> 

Applied to target-pending/for-next.

--nab

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html