Re: [PATCH 2/2] qedi: Remove WARN_ON from clear task context.

[Lee Duncan]

On 06/15/2017 12:10 AM, Manish Rangankar wrote:
> Signed-off-by: Manish Rangankar 
> ---
>  drivers/scsi/qedi/qedi_main.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c
> index 09a2946..879d3b7 100644
> --- a/drivers/scsi/qedi/qedi_main.c
> +++ b/drivers/scsi/qedi/qedi_main.c
> @@ -1499,11 +1499,9 @@ int qedi_get_task_idx(struct qedi_ctx *qedi)
>  
>  void qedi_clear_task_idx(struct qedi_ctx *qedi, int idx)
>  {
> - if (!test_and_clear_bit(idx, qedi->task_idx_map)) {
> + if (!test_and_clear_bit(idx, qedi->task_idx_map))
>   QEDI_ERR(&qedi->dbg_ctx,
>"FW task context, already cleared, tid=0x%x\n", idx);
> - WARN_ON(1);
> - }
>  }
>  
>  void qedi_update_itt_map(struct qedi_ctx *qedi, u32 tid, u32 proto_itt,
> 

Reviewed-by: Lee Duncan 

[PATCH 2/2] qedi: Remove WARN_ON from clear task context.

[Manish Rangankar]

Signed-off-by: Manish Rangankar 
---
 drivers/scsi/qedi/qedi_main.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c
index 09a2946..879d3b7 100644
--- a/drivers/scsi/qedi/qedi_main.c
+++ b/drivers/scsi/qedi/qedi_main.c
@@ -1499,11 +1499,9 @@ int qedi_get_task_idx(struct qedi_ctx *qedi)
 
 void qedi_clear_task_idx(struct qedi_ctx *qedi, int idx)
 {
-   if (!test_and_clear_bit(idx, qedi->task_idx_map)) {
+   if (!test_and_clear_bit(idx, qedi->task_idx_map))
QEDI_ERR(&qedi->dbg_ctx,
 "FW task context, already cleared, tid=0x%x\n", idx);
-   WARN_ON(1);
-   }
 }
 
 void qedi_update_itt_map(struct qedi_ctx *qedi, u32 tid, u32 proto_itt,
-- 
1.8.3.1