Re: [PATCH 2/3] hpsa: change SAS transport devices to bus 0.

2015-12-18 Thread Matthew R. Ochs 
> On Dec 15, 2015, at 9:25 AM, Don Brace  wrote:
> 
> On 12/09/2015 05:21 PM, Matthew R. Ochs wrote:
>>> On Dec 9, 2015, at 3:18 PM, Don Brace  wrote:
>>> 
>>> sas transport places devices on bus 0 but driver was setting
>>> the bus to 3.
>>> 
>>> Reviewed-by: Justin Lindley 
>>> Reviewed-by: Kevin Barnett 
>>> Reviewed-by: Scott Teel 
>>> Signed-off-by: Don Brace 
>>> ---
>>> drivers/scsi/hpsa.h |2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>> 
>>> diff --git a/drivers/scsi/hpsa.h b/drivers/scsi/hpsa.h
>>> index ae5beda..fdd39fc 100644
>>> --- a/drivers/scsi/hpsa.h
>>> +++ b/drivers/scsi/hpsa.h
>>> @@ -400,7 +400,7 @@ struct offline_device_entry {
>>> #define HPSA_PHYSICAL_DEVICE_BUS0
>>> #define HPSA_RAID_VOLUME_BUS1
>>> #define HPSA_EXTERNAL_RAID_VOLUME_BUS   2
>>> -#define HPSA_HBA_BUS   3
>>> +#define HPSA_HBA_BUS   0
>> Is this not the same as using HPSA_PHYSICAL_DEVICE_BUS?
> I was just trying to minimize the changes. I can update the driver
> is necessary.

Understandable.

Reviewed-by: Matthew R. Ochs 

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3] hpsa: change SAS transport devices to bus 0.

2015-12-15 Thread Don Brace 

On 12/09/2015 05:21 PM, Matthew R. Ochs wrote:

On Dec 9, 2015, at 3:18 PM, Don Brace  wrote:

sas transport places devices on bus 0 but driver was setting
the bus to 3.

Reviewed-by: Justin Lindley 
Reviewed-by: Kevin Barnett 
Reviewed-by: Scott Teel 
Signed-off-by: Don Brace 
---
drivers/scsi/hpsa.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/hpsa.h b/drivers/scsi/hpsa.h
index ae5beda..fdd39fc 100644
--- a/drivers/scsi/hpsa.h
+++ b/drivers/scsi/hpsa.h
@@ -400,7 +400,7 @@ struct offline_device_entry {
#define HPSA_PHYSICAL_DEVICE_BUS0
#define HPSA_RAID_VOLUME_BUS1
#define HPSA_EXTERNAL_RAID_VOLUME_BUS   2
-#define HPSA_HBA_BUS   3
+#define HPSA_HBA_BUS   0

Is this not the same as using HPSA_PHYSICAL_DEVICE_BUS?

I was just trying to minimize the changes. I can update the driver
is necessary.

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3] hpsa: change SAS transport devices to bus 0.

2015-12-09 Thread Matthew R. Ochs 
> On Dec 9, 2015, at 3:18 PM, Don Brace  wrote:
> 
> sas transport places devices on bus 0 but driver was setting
> the bus to 3.
> 
> Reviewed-by: Justin Lindley 
> Reviewed-by: Kevin Barnett 
> Reviewed-by: Scott Teel 
> Signed-off-by: Don Brace 
> ---
> drivers/scsi/hpsa.h |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/hpsa.h b/drivers/scsi/hpsa.h
> index ae5beda..fdd39fc 100644
> --- a/drivers/scsi/hpsa.h
> +++ b/drivers/scsi/hpsa.h
> @@ -400,7 +400,7 @@ struct offline_device_entry {
> #define HPSA_PHYSICAL_DEVICE_BUS  0
> #define HPSA_RAID_VOLUME_BUS  1
> #define HPSA_EXTERNAL_RAID_VOLUME_BUS 2
> -#define HPSA_HBA_BUS 3
> +#define HPSA_HBA_BUS 0

Is this not the same as using HPSA_PHYSICAL_DEVICE_BUS?

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 2/3] hpsa: change SAS transport devices to bus 0.

2015-12-09 Thread Don Brace 
sas transport places devices on bus 0 but driver was setting
the bus to 3.

Reviewed-by: Justin Lindley 
Reviewed-by: Kevin Barnett 
Reviewed-by: Scott Teel 
Signed-off-by: Don Brace 
---
 drivers/scsi/hpsa.h |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/hpsa.h b/drivers/scsi/hpsa.h
index ae5beda..fdd39fc 100644
--- a/drivers/scsi/hpsa.h
+++ b/drivers/scsi/hpsa.h
@@ -400,7 +400,7 @@ struct offline_device_entry {
 #define HPSA_PHYSICAL_DEVICE_BUS   0
 #define HPSA_RAID_VOLUME_BUS   1
 #define HPSA_EXTERNAL_RAID_VOLUME_BUS  2
-#define HPSA_HBA_BUS   3
+#define HPSA_HBA_BUS   0
 
 /*
Send the command to the hardware

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html