Re: [PATCH 2/4] hpsa: remove the smp_handler stub

[Johannes Thumshirn]

Looks good,
Reviewed-by: Johannes Thumshirn 
-- 
Johannes Thumshirn  Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

RE: [PATCH 2/4] hpsa: remove the smp_handler stub

[Don Brace]

From: linux-scsi-ow...@vger.kernel.org [linux-scsi-ow...@vger.kernel.org] on 
behalf of Christoph Hellwig [h...@lst.de]
Sent: Friday, August 25, 2017 8:37 AM
To: Chaitra Basappa; linux-scsi@vger.kernel.org
Cc: Bart Van Assche
Subject: [PATCH 2/4] hpsa: remove the smp_handler stub

EXTERNAL EMAIL


The SAS transport class will do the right thing and not register the BSG
node if now smp_handler method is present.

Signed-off-by: Christoph Hellwig <h...@lst.de>

Acked-by: Don Brace <don.br...@microsemi.com>

[PATCH 2/4] hpsa: remove the smp_handler stub

[Christoph Hellwig]

The SAS transport class will do the right thing and not register the BSG
node if now smp_handler method is present.

Signed-off-by: Christoph Hellwig 
---
 drivers/scsi/hpsa.c | 9 -
 1 file changed, 9 deletions(-)

diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 4f7cdb28bd38..a8778bd725c5 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -9443,14 +9443,6 @@ hpsa_sas_phy_speed(struct sas_phy *phy, struct 
sas_phy_linkrates *rates)
return -EINVAL;
 }
 
-/* SMP = Serial Management Protocol */
-static int
-hpsa_sas_smp_handler(struct Scsi_Host *shost, struct sas_rphy *rphy,
-struct request *req)
-{
-   return -EINVAL;
-}
-
 static struct sas_function_template hpsa_sas_transport_functions = {
.get_linkerrors = hpsa_sas_get_linkerrors,
.get_enclosure_identifier = hpsa_sas_get_enclosure_identifier,
@@ -9460,7 +9452,6 @@ static struct sas_function_template 
hpsa_sas_transport_functions = {
.phy_setup = hpsa_sas_phy_setup,
.phy_release = hpsa_sas_phy_release,
.set_phy_speed = hpsa_sas_phy_speed,
-   .smp_handler = hpsa_sas_smp_handler,
 };
 
 /*
-- 
2.11.0