Re: [PATCH 20/35] qla2xxx: Unload of qla2xxx driver crashes the machine.
>On Thu, Sep 25, 2014 at 08:57:18AM +, Saurav Kashyap wrote: >> Hi Christoph, >> I will rebase and send an updated patch set soon. > >Thanks. Did you verify the target side series sits nicely on top of this >one as well? I'd like to slurp in the qla2xxx patches as well if Nick >is fine with them, although I'd prefer to leave the target core changes >for his target tree. As far as I can tell there is no hard dependency >of the qla2xxx changes on those two, right? Next time it might be good >idea to send them as two separate series. Hi, I will check, if there are any conflicts, I will resend that patch set. Thanks, ~Saurav <>
Re: [PATCH 20/35] qla2xxx: Unload of qla2xxx driver crashes the machine.
On Thu, Sep 25, 2014 at 08:57:18AM +, Saurav Kashyap wrote: > Hi Christoph, > I will rebase and send an updated patch set soon. Thanks. Did you verify the target side series sits nicely on top of this one as well? I'd like to slurp in the qla2xxx patches as well if Nick is fine with them, although I'd prefer to leave the target core changes for his target tree. As far as I can tell there is no hard dependency of the qla2xxx changes on those two, right? Next time it might be good idea to send them as two separate series. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 20/35] qla2xxx: Unload of qla2xxx driver crashes the machine.
Hi Christoph, I will rebase and send an updated patch set soon. Thanks, ~Saurav >On Wed, Sep 24, 2014 at 09:41:25AM -0400, Joe Lawrence wrote: >> Hi Saurav, >> >> Will these changes conflict with those submitted in August [1] to >> Christoph's drivers-for-3.18 branch? > >It does cause conflicts when applying the patch at least. Chad, can you >please resend the series against the drivers-for-3.18 branch of >git://git.infradead.org/users/hch/scsi-queue.git ? Please do so today >so that we don't miss the merge window. > <>
Re: [PATCH 20/35] qla2xxx: Unload of qla2xxx driver crashes the machine.
On Wed, Sep 24, 2014 at 09:41:25AM -0400, Joe Lawrence wrote: > Hi Saurav, > > Will these changes conflict with those submitted in August [1] to > Christoph's drivers-for-3.18 branch? It does cause conflicts when applying the patch at least. Chad, can you please resend the series against the drivers-for-3.18 branch of git://git.infradead.org/users/hch/scsi-queue.git ? Please do so today so that we don't miss the merge window. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 20/35] qla2xxx: Unload of qla2xxx driver crashes the machine.
Hi Saurav,
Will these changes conflict with those submitted in August [1] to
Christoph's drivers-for-3.18 branch?
In particular, "qla2xxx: Fix shost use-after-free on device
removal" [2] fixed this same driver unload issue in a slightly
different manner. That change was marked for stable as the bug was
introduced by fe1b806f4f71 ("qla2xxx: Refactor shutdown code so some
functionality can be reused") in previous releases.
Regards,
-- Joe
[1] http://thread.gmane.org/gmane.linux.scsi/93859
[2]
http://git.infradead.org/users/hch/scsi-queue.git/commitdiff/db7157d4cfce6edf052452fb1d327d4d11b67f4c
On Wed, 24 Sep 2014 03:08:23 -0400
Saurav Kashyap wrote:
> From: Arun Easi
>
> Signed-off-by: Arun Easi
> Signed-off-by: Saurav Kashyap
> ---
> drivers/scsi/qla2xxx/qla_os.c |4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
> index 8846883..6539513 100644
> --- a/drivers/scsi/qla2xxx/qla_os.c
> +++ b/drivers/scsi/qla2xxx/qla_os.c
> @@ -3190,10 +3190,10 @@ qla2x00_remove_one(struct pci_dev *pdev)
>
> qla2x00_free_device(base_vha);
>
> - scsi_host_put(base_vha->host);
> -
> qla2x00_clear_drv_active(base_vha);
>
> + scsi_host_put(base_vha->host);
> +
> qla2x00_unmap_iobases(ha);
>
> pci_release_selected_regions(ha->pdev, ha->bars);
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 20/35] qla2xxx: Unload of qla2xxx driver crashes the machine.
From: Arun Easi Signed-off-by: Arun Easi Signed-off-by: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_os.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c index 8846883..6539513 100644 --- a/drivers/scsi/qla2xxx/qla_os.c +++ b/drivers/scsi/qla2xxx/qla_os.c @@ -3190,10 +3190,10 @@ qla2x00_remove_one(struct pci_dev *pdev) qla2x00_free_device(base_vha); - scsi_host_put(base_vha->host); - qla2x00_clear_drv_active(base_vha); + scsi_host_put(base_vha->host); + qla2x00_unmap_iobases(ha); pci_release_selected_regions(ha->pdev, ha->bars); -- 1.7.7 -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
