Re: [PATCH 3/5] lpfc 10.2.8001.0: Removed obsolete PCI IDs from the driver
On 05/19/2014 07:39 PM, James Smart wrote: :) for those distros, that want to pull only upstream'd patches, and where customers expect someone to take phone calls on any hardware recognized by the distro... the patch is to remove the hardware Emulex/the distro won't answer any questions for anymore. true - the hardware, if you can find it lying around somewhere, may still function. It won't get firmware updates, nor any mindshare. I'm not sure where the policy is for upstream - is it truly once known, can never be taken away ? Problem is, no-one does. But I've proposed a micro-conf at LPC in October to discuss exactly this. You're welcomed to join :-) It would be good to have a mechanism which would retain the functionality, but at the same time indicating that for any errors you might be on your own. Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3/5] lpfc 10.2.8001.0: Removed obsolete PCI IDs from the driver
On Mon, May 19, 2014 at 01:39:50PM -0400, James Smart wrote: > :) > > for those distros, that want to pull only upstream'd patches, and > where customers expect someone to take phone calls on any hardware > recognized by the distro... the patch is to remove the hardware > Emulex/the distro won't answer any questions for anymore. > > true - the hardware, if you can find it lying around somewhere, may > still function. It won't get firmware updates, nor any mindshare. > I'm not sure where the policy is for upstream - is it truly once > known, can never be taken away ? The policy is to leave it in even if unsupported, and let it it slowly bitrot. In some cases users will step up and maintain it, in most cases we will be able to recycle it after a few years. How about you stick in a printk that Emulex doesn't support the driver for these cards anymore? -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3/5] lpfc 10.2.8001.0: Removed obsolete PCI IDs from the driver
:) for those distros, that want to pull only upstream'd patches, and where customers expect someone to take phone calls on any hardware recognized by the distro... the patch is to remove the hardware Emulex/the distro won't answer any questions for anymore. true - the hardware, if you can find it lying around somewhere, may still function. It won't get firmware updates, nor any mindshare. I'm not sure where the policy is for upstream - is it truly once known, can never be taken away ? -- james s On 5/19/2014 1:19 PM, Christoph Hellwig wrote: On Mon, May 12, 2014 at 11:53:27AM -0400, James Smart wrote: Removed obsolete PCI IDs from the driver. How are these obsolete? -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3/5] lpfc 10.2.8001.0: Removed obsolete PCI IDs from the driver
On Mon, May 12, 2014 at 11:53:27AM -0400, James Smart wrote: > Removed obsolete PCI IDs from the driver. How are these obsolete? -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 3/5] lpfc 10.2.8001.0: Removed obsolete PCI IDs from the driver
Removed obsolete PCI IDs from the driver.
Signed-off-by: James Smart
---
lpfc_els.c |9 ---
lpfc_hw.h | 54 +---
lpfc_init.c | 161
lpfc_sli.c |4 -
4 files changed, 6 insertions(+), 222 deletions(-)
diff -upNr a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c
--- a/drivers/scsi/lpfc/lpfc_els.c 2014-05-12 09:45:19.950082858 -0400
+++ b/drivers/scsi/lpfc/lpfc_els.c 2014-05-12 09:49:36.958095803 -0400
@@ -3164,15 +3164,6 @@ lpfc_els_retry(struct lpfc_hba *phba, st
case IOSTAT_LOCAL_REJECT:
switch ((irsp->un.ulpWord[4] & IOERR_PARAM_MASK)) {
case IOERR_LOOP_OPEN_FAILURE:
- if (cmd == ELS_CMD_FLOGI) {
- if (PCI_DEVICE_ID_HORNET ==
- phba->pcidev->device) {
- phba->fc_topology = LPFC_TOPOLOGY_LOOP;
- phba->pport->fc_myDID = 0;
- phba->alpa_map[0] = 0;
- phba->alpa_map[1] = 0;
- }
- }
if (cmd == ELS_CMD_PLOGI && cmdiocb->retry == 0)
delay = 1000;
retry = 1;
diff -upNr a/drivers/scsi/lpfc/lpfc_hw.h b/drivers/scsi/lpfc/lpfc_hw.h
--- a/drivers/scsi/lpfc/lpfc_hw.h 2014-05-12 09:45:34.365083584 -0400
+++ b/drivers/scsi/lpfc/lpfc_hw.h 2014-05-12 09:49:36.962095803 -0400
@@ -1208,47 +1208,20 @@ typedef struct {
/* Start FireFly Register definitions */
#define PCI_VENDOR_ID_EMULEX0x10df
-#define PCI_DEVICE_ID_FIREFLY 0x1ae5
-#define PCI_DEVICE_ID_PROTEUS_VF0xe100
-#define PCI_DEVICE_ID_BALIUS0xe131
-#define PCI_DEVICE_ID_PROTEUS_PF0xe180
#define PCI_DEVICE_ID_LANCER_FC 0xe200
-#define PCI_DEVICE_ID_LANCER_FC_VF 0xe208
#define PCI_DEVICE_ID_LANCER_FCOE 0xe260
-#define PCI_DEVICE_ID_LANCER_FCOE_VF 0xe268
#define PCI_DEVICE_ID_SAT_SMB 0xf011
#define PCI_DEVICE_ID_SAT_MID 0xf015
-#define PCI_DEVICE_ID_RFLY 0xf095
-#define PCI_DEVICE_ID_PFLY 0xf098
-#define PCI_DEVICE_ID_LP101 0xf0a1
-#define PCI_DEVICE_ID_TFLY 0xf0a5
-#define PCI_DEVICE_ID_BSMB 0xf0d1
#define PCI_DEVICE_ID_BMID 0xf0d5
#define PCI_DEVICE_ID_ZSMB 0xf0e1
#define PCI_DEVICE_ID_ZMID 0xf0e5
-#define PCI_DEVICE_ID_NEPTUNE 0xf0f5
-#define PCI_DEVICE_ID_NEPTUNE_SCSP 0xf0f6
-#define PCI_DEVICE_ID_NEPTUNE_DCSP 0xf0f7
#define PCI_DEVICE_ID_SAT 0xf100
#define PCI_DEVICE_ID_SAT_SCSP 0xf111
#define PCI_DEVICE_ID_SAT_DCSP 0xf112
#define PCI_DEVICE_ID_FALCON0xf180
-#define PCI_DEVICE_ID_SUPERFLY 0xf700
-#define PCI_DEVICE_ID_DRAGONFLY 0xf800
-#define PCI_DEVICE_ID_CENTAUR 0xf900
-#define PCI_DEVICE_ID_PEGASUS 0xf980
-#define PCI_DEVICE_ID_THOR 0xfa00
-#define PCI_DEVICE_ID_VIPER 0xfb00
-#define PCI_DEVICE_ID_LP1S 0xfc00
-#define PCI_DEVICE_ID_LP11000S 0xfc10
#define PCI_DEVICE_ID_LPE11000S 0xfc20
#define PCI_DEVICE_ID_SAT_S 0xfc40
-#define PCI_DEVICE_ID_PROTEUS_S 0xfc50
-#define PCI_DEVICE_ID_HELIOS0xfd00
-#define PCI_DEVICE_ID_HELIOS_SCSP 0xfd11
-#define PCI_DEVICE_ID_HELIOS_DCSP 0xfd12
#define PCI_DEVICE_ID_ZEPHYR0xfe00
-#define PCI_DEVICE_ID_HORNET0xfe05
#define PCI_DEVICE_ID_ZEPHYR_SCSP 0xfe11
#define PCI_DEVICE_ID_ZEPHYR_DCSP 0xfe12
#define PCI_VENDOR_ID_SERVERENGINE 0x19a2
@@ -1258,20 +1231,8 @@ typedef struct {
#define PCI_DEVICE_ID_SKYHAWK_VF0x072c
#define JEDEC_ID_ADDRESS0x0080001c
-#define FIREFLY_JEDEC_ID0x1ACC
-#define SUPERFLY_JEDEC_ID 0x0020
-#define DRAGONFLY_JEDEC_ID 0x0021
-#define DRAGONFLY_V2_JEDEC_ID 0x0025
-#define CENTAUR_2G_JEDEC_ID 0x0026
-#define CENTAUR_1G_JEDEC_ID 0x0028
-#define PEGASUS_ORION_JEDEC_ID 0x0036
-#define PEGASUS_JEDEC_ID0x0038
-#define THOR_JEDEC_ID 0x0012
-#define HELIOS_JEDEC_ID 0x0364
#define ZEPHYR_JEDEC_ID 0x0577
-#define VIPER_JEDEC_ID 0x4838
#define SATURN_JEDEC_ID 0x1004
-#define HORNET_JDEC_ID 0x2057706D
#define JEDEC_ID_MASK 0x0000
#define JEDEC_ID_SHIFT 12
@@ -3808,16 +3769,11 @@ struct lpfc_sli2_slim {
static inline int
lpfc_is_LC_HBA(unsigned short device)
{
- if ((device == PCI_DEVICE_ID_TFLY) ||
- (device == PCI_DEVICE_ID_PFLY) ||
- (device == PCI_DEVICE_ID_LP101) ||
- (device == PCI_DEVICE_ID_BMID) ||
- (device == PCI_DEVICE_ID_BSMB) ||
- (device == PCI_DEVICE_ID_ZMID) ||
- (device == PCI_DEVICE_ID_ZSMB) ||
- (device == PCI_DEVICE
