Re: [PATCH 5/6] qla2xxx: Use FC-NMVe FC4 type for FDMI registration

[James Smart]

On 6/16/2017 3:47 PM, Himanshu Madhani wrote:

From: Duane Grigsby 

Signed-off-by: Duane Grigsby 
Signed-off-by: Darren Trapp 
Signed-off-by: Anil Gurumurthy 
Signed-off-by: Giridhar Malavali 
Signed-off-by: Himanshu Madhani 
---



Reviewed-by: James Smart 

Re: [PATCH 5/6] qla2xxx: Use FC-NMVe FC4 type for FDMI registration

[Johannes Thumshirn]

On Fri, Jun 16, 2017 at 03:47:43PM -0700, Himanshu Madhani wrote:
> From: Duane Grigsby 
> 
> Signed-off-by: Duane Grigsby 
> Signed-off-by: Darren Trapp 
> Signed-off-by: Anil Gurumurthy 
> Signed-off-by: Giridhar Malavali 
> Signed-off-by: Himanshu Madhani 
> ---

A bit more of a change log would be highly apprechiated.

Other than that,
Reviewed-by: Johannes Thumshirn 
-- 
Johannes Thumshirn  Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

[PATCH 5/6] qla2xxx: Use FC-NMVe FC4 type for FDMI registration

[Himanshu Madhani]

From: Duane Grigsby 

Signed-off-by: Duane Grigsby 
Signed-off-by: Darren Trapp 
Signed-off-by: Anil Gurumurthy 
Signed-off-by: Giridhar Malavali 
Signed-off-by: Himanshu Madhani 
---
 drivers/scsi/qla2xxx/qla_gs.c | 16 
 1 file changed, 16 insertions(+)

diff --git a/drivers/scsi/qla2xxx/qla_gs.c b/drivers/scsi/qla2xxx/qla_gs.c
index c91478529b51..b323a7c71eda 100644
--- a/drivers/scsi/qla2xxx/qla_gs.c
+++ b/drivers/scsi/qla2xxx/qla_gs.c
@@ -2166,6 +2166,13 @@ qla2x00_fdmiv2_rpa(scsi_qla_host_t *vha)
eiter->a.fc4_types[2],
eiter->a.fc4_types[1]);
 
+   if (vha->flags.nvme_enabled) {
+   eiter->a.fc4_types[6] = 1;  /* NVMe type 28h */
+   ql_dbg(ql_dbg_disc, vha, 0x211f,
+   "NVME FC4 Type = %02x 0x0 0x0 0x0 0x0 0x0.\n",
+   eiter->a.fc4_types[6]);
+   }
+
/* Supported speed. */
eiter = entries + size;
eiter->type = cpu_to_be16(FDMI_PORT_SUPPORT_SPEED);
@@ -2363,6 +2370,15 @@ qla2x00_fdmiv2_rpa(scsi_qla_host_t *vha)
"Port Active FC4 Type = %02x %02x.\n",
eiter->a.port_fc4_type[2], eiter->a.port_fc4_type[1]);
 
+   if (vha->flags.nvme_enabled) {
+   eiter->a.port_fc4_type[4] = 0;
+   eiter->a.port_fc4_type[5] = 0;
+   eiter->a.port_fc4_type[6] = 1;  /* NVMe type 28h */
+   ql_dbg(ql_dbg_disc, vha, 0x2120,
+   "NVME Port Active FC4 Type = %02x 0x0 0x0 0x0 0x0 0x0.\n",
+   eiter->a.port_fc4_type[6]);
+   }
+
/* Port State */
eiter = entries + size;
eiter->type = cpu_to_be16(FDMI_PORT_STATE);
-- 
2.12.0