Re: [PATCH 6/6] scsi: ufs: just use sizeof() for snprintf()

[Subhash Jadavani]

On 2017-03-28 06:49, kusumi.tomoh...@gmail.com wrote:

From: Tomohiro Kusumi 

Not much reason to use ARRAY_SIZE() when we know it's for a C string.

Signed-off-by: Tomohiro Kusumi 
---
 drivers/scsi/ufs/ufshcd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 109a762..790c19c 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -7880,7 +7880,7 @@ int ufshcd_init(struct ufs_hba *hba, void
__iomem *mmio_base, unsigned int irq)
INIT_WORK(>clk_scaling.resume_work,
  ufshcd_clk_scaling_resume_work);

-   snprintf(wq_name, ARRAY_SIZE(wq_name), "ufs_clkscaling_%d",
+   snprintf(wq_name, sizeof(wq_name), "ufs_clkscaling_%d",
 host->host_no);
hba->clk_scaling.workq = create_singlethread_workqueue(wq_name);



Looks good to me.
Reviewed-by: Subhash Jadavani 

--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

[PATCH 6/6] scsi: ufs: just use sizeof() for snprintf()

[kusumi . tomohiro]

From: Tomohiro Kusumi 

Not much reason to use ARRAY_SIZE() when we know it's for a C string.

Signed-off-by: Tomohiro Kusumi 
---
 drivers/scsi/ufs/ufshcd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 109a762..790c19c 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -7880,7 +7880,7 @@ int ufshcd_init(struct ufs_hba *hba, void __iomem 
*mmio_base, unsigned int irq)
INIT_WORK(>clk_scaling.resume_work,
  ufshcd_clk_scaling_resume_work);
 
-   snprintf(wq_name, ARRAY_SIZE(wq_name), "ufs_clkscaling_%d",
+   snprintf(wq_name, sizeof(wq_name), "ufs_clkscaling_%d",
 host->host_no);
hba->clk_scaling.workq = create_singlethread_workqueue(wq_name);
 
-- 
2.9.3