[PATCH RESEND 0/6] hpsa: support legacy boards
(Resend to include linux-scsi) Hi all, this patch adds support for legacy boards, ie for boards previously supported by cciss only. With this patchset the hpsa driver should work with all Smart Array boards if the 'hpsa_allow_any' module option is set, rendering the cciss driver obsolete. Hannes Reinecke (5): hpsa: consolidate status variables hpsa: add support for legacy boards hpsa: disable volume status check for older controller hpsa: Ignore errors for unsupported LV_DEVICE_ID VPD page hpsa: do not print errors for unsupported report luns format Jeff Mahoney (1): hpsa: handle unsupported devices more gracefully drivers/scsi/hpsa.c | 131 drivers/scsi/hpsa.h | 57 --- 2 files changed, 162 insertions(+), 26 deletions(-) -- 1.8.5.6
RE: [PATCH RESEND 0/6] hpsa: support legacy boards
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Tuesday, August 08, 2017 3:35 AM > To: Martin K. Petersen > Cc: Don Brace ; Christoph Hellwig > ; James Bottomley > ; Meelis Roos > ; linux-scsi@vger.kernel.org; Hannes Reinecke > > Subject: [PATCH RESEND 0/6] hpsa: support legacy boards > > EXTERNAL EMAIL > > > (Resend to include linux-scsi) > > Hi all, > > this patch adds support for legacy boards, ie for boards previously > supported by cciss only. > With this patchset the hpsa driver should work with all Smart Array > boards if the 'hpsa_allow_any' module option is set, rendering the > cciss driver obsolete. > > Hannes Reinecke (5): > hpsa: consolidate status variables > hpsa: add support for legacy boards > hpsa: disable volume status check for older controller > hpsa: Ignore errors for unsupported LV_DEVICE_ID VPD page > hpsa: do not print errors for unsupported report luns format > > Jeff Mahoney (1): > hpsa: handle unsupported devices more gracefully > > drivers/scsi/hpsa.c | 131 > > drivers/scsi/hpsa.h | 57 --- > 2 files changed, 162 insertions(+), 26 deletions(-) > > -- > 1.8.5.6 NACK this series We do not want to support these older controllers in the hpsa driver. While the driver may load and manage requests under healthy conditions many features will not be supported. Customers will not have support for any issues involving these controllers. We would need to track these changes in our OOB driver adding more confusion. For more information please see: http://cciss.sourceforge.net Thanks, Don Brace ESC - Smart Storage Microsemi Corporation
Re: [PATCH RESEND 0/6] hpsa: support legacy boards
On 08/10/2017 12:08 AM, Don Brace wrote: >> -Original Message- >> From: Hannes Reinecke [mailto:h...@suse.de] >> Sent: Tuesday, August 08, 2017 3:35 AM >> To: Martin K. Petersen >> Cc: Don Brace ; Christoph Hellwig >> ; James Bottomley >> ; Meelis Roos >> ; linux-scsi@vger.kernel.org; Hannes Reinecke >> >> Subject: [PATCH RESEND 0/6] hpsa: support legacy boards >> >> EXTERNAL EMAIL >> >> >> (Resend to include linux-scsi) >> >> Hi all, >> >> this patch adds support for legacy boards, ie for boards previously >> supported by cciss only. >> With this patchset the hpsa driver should work with all Smart Array >> boards if the 'hpsa_allow_any' module option is set, rendering the >> cciss driver obsolete. >> >> Hannes Reinecke (5): >> hpsa: consolidate status variables >> hpsa: add support for legacy boards >> hpsa: disable volume status check for older controller >> hpsa: Ignore errors for unsupported LV_DEVICE_ID VPD page >> hpsa: do not print errors for unsupported report luns format >> >> Jeff Mahoney (1): >> hpsa: handle unsupported devices more gracefully >> >> drivers/scsi/hpsa.c | 131 >> >> drivers/scsi/hpsa.h | 57 --- >> 2 files changed, 162 insertions(+), 26 deletions(-) >> >> -- >> 1.8.5.6 > > NACK this series > > We do not want to support these older controllers in the hpsa driver. > > While the driver may load and manage requests under healthy conditions > many features will not be supported. Customers will not have support > for any issues involving these controllers. > > We would need to track these changes in our OOB driver adding > more confusion. > Weelll ... that is _precisely_ why I introduced the 'unsupported' flag to the hba structure; once this is set we have encountered an unsupported board, and things might not work as expected. More importantly, you don't have to support that board. We can even add a stronger wording if you like, eg printing out a big fat warning in dmesg 'This board is unsupported, some features might not work'. So where's the bother here? Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)
Re: [PATCH RESEND 0/6] hpsa: support legacy boards
No device support in Linux is unsupported, sorry. I think we're getting into the corporate bullshit game a little too much here.
Re: [PATCH RESEND 0/6] hpsa: support legacy boards
On 08/10/2017 09:09 AM, Christoph Hellwig wrote: > No device support in Linux is unsupported, sorry. I think we're > getting into the corporate bullshit game a little too much here. > Well, yes and no. My intention with the 'unsupported' flag was to differentiate legit errors / warnings from known / expected failures. Modern (or 'supported' as Don puts it) boards have quite some features built in, and any failure to activate these features should be debugged. Older (or 'unsupported') boards might not necessarily have these features, so a failure here is actually to be expected, seeing that a firmware update for these boards is not likely to happen. And this was precisely the meaning of the 'unsupported' flag; if that is set we'll blank out some known warnings or short-circuit feature detections which are known not to be present. Plus we have a marker (and, with the latest patch, even a dmesg warning) letting us differentiate between legit errors and unsupported/unimplemented features. Personally I'm happy to support the legacy side of things (ie blanking out errors from unsupported controllers), if that is of any help ... Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)
Re: [PATCH RESEND 0/6] hpsa: support legacy boards
On Thu, 2017-08-10 at 09:09 +0200, Christoph Hellwig wrote: > No device support in Linux is unsupported, sorry. I think we're > getting into the corporate bullshit game a little too much here. I think there are two different definitions of supported here. To us, any device to which the driver attaches is "supported". However, if it's never been tested before it may not work very well. In the Linux way, we'll try to fix the bugs when they're reported and in that sense we support the device until nothing in the kernel attaches to its ids anymore. In the corporate world "supported" means we'll sell you a contract giving you certain rights to report bugs and have us fix them. There are definite reasons why corporations only support a small range of new devices, even though devices not on this list may still be attached to by the driver and thus we (Linux Community) would try to fix the bug reports for. I think what you're basically asking for is a different name for the flag, which is fine? how about 'legacy' instead? James
Re: [PATCH RESEND 0/6] hpsa: support legacy boards
On 08/10/2017 04:06 PM, James Bottomley wrote: > On Thu, 2017-08-10 at 09:09 +0200, Christoph Hellwig wrote: >> No device support in Linux is unsupported, sorry. I think we're >> getting into the corporate bullshit game a little too much here. > > I think there are two different definitions of supported here. To us, > any device to which the driver attaches is "supported". However, if > it's never been tested before it may not work very well. In the Linux > way, we'll try to fix the bugs when they're reported and in that sense > we support the device until nothing in the kernel attaches to its ids > anymore. > > In the corporate world "supported" means we'll sell you a contract > giving you certain rights to report bugs and have us fix them. There > are definite reasons why corporations only support a small range of new > devices, even though devices not on this list may still be attached to > by the driver and thus we (Linux Community) would try to fix the bug > reports for. > > I think what you're basically asking for is a different name for the > flag, which is fine? how about 'legacy' instead? > Sure, no problem with that. Don? Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)
RE: [PATCH RESEND 0/6] hpsa: support legacy boards
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Thursday, August 10, 2017 9:11 AM > To: James Bottomley ; > Christoph Hellwig > Cc: Don Brace ; Martin K. Petersen > ; Meelis Roos ; linux- > s...@vger.kernel.org > Subject: Re: [PATCH RESEND 0/6] hpsa: support legacy boards > > EXTERNAL EMAIL > > > On 08/10/2017 04:06 PM, James Bottomley wrote: > > On Thu, 2017-08-10 at 09:09 +0200, Christoph Hellwig wrote: > >> No device support in Linux is unsupported, sorry. I think we're > >> getting into the corporate bullshit game a little too much here. > > > > I think there are two different definitions of supported here. To us, > > any device to which the driver attaches is "supported". However, if > > it's never been tested before it may not work very well. In the Linux > > way, we'll try to fix the bugs when they're reported and in that sense > > we support the device until nothing in the kernel attaches to its ids > > anymore. > > > > In the corporate world "supported" means we'll sell you a contract > > giving you certain rights to report bugs and have us fix them. There > > are definite reasons why corporations only support a small range of new > > devices, even though devices not on this list may still be attached to > > by the driver and thus we (Linux Community) would try to fix the bug > > reports for. > > > > I think what you're basically asking for is a different name for the > > flag, which is fine? how about 'legacy' instead? > > > Sure, no problem with that. > > Don? > > Cheers, > > Hannes > -- > Dr. Hannes ReineckeTeamlead Storage & Networking > h...@suse.de +49 911 74053 688 > SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg > GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton > HRB 21284 (AG Nürnberg) Ok, but to clarify... * Will the cciss driver be removed when these patches are applied? Otherwise what will prevent the cciss driver from loading over these devices? i.e. how often will users need to be reminded to add cciss.cciss_allow_hpsa flag?
Re: [PATCH RESEND 0/6] hpsa: support legacy boards
On 08/10/2017 09:15 PM, Don Brace wrote: >> -Original Message- >> From: Hannes Reinecke [mailto:h...@suse.de] >> Sent: Thursday, August 10, 2017 9:11 AM >> To: James Bottomley ; >> Christoph Hellwig >> Cc: Don Brace ; Martin K. Petersen >> ; Meelis Roos ; linux- >> s...@vger.kernel.org >> Subject: Re: [PATCH RESEND 0/6] hpsa: support legacy boards >> >> EXTERNAL EMAIL >> >> >> On 08/10/2017 04:06 PM, James Bottomley wrote: >>> On Thu, 2017-08-10 at 09:09 +0200, Christoph Hellwig wrote: >>>> No device support in Linux is unsupported, sorry. I think we're >>>> getting into the corporate bullshit game a little too much here. >>> >>> I think there are two different definitions of supported here. To us, >>> any device to which the driver attaches is "supported". However, if >>> it's never been tested before it may not work very well. In the Linux >>> way, we'll try to fix the bugs when they're reported and in that sense >>> we support the device until nothing in the kernel attaches to its ids >>> anymore. >>> >>> In the corporate world "supported" means we'll sell you a contract >>> giving you certain rights to report bugs and have us fix them. There >>> are definite reasons why corporations only support a small range of new >>> devices, even though devices not on this list may still be attached to >>> by the driver and thus we (Linux Community) would try to fix the bug >>> reports for. >>> >>> I think what you're basically asking for is a different name for the >>> flag, which is fine? how about 'legacy' instead? >>> >> Sure, no problem with that. >> >> Don? >> >> Cheers, >> >> Hannes >> -- >> Dr. Hannes ReineckeTeamlead Storage & Networking >> h...@suse.de +49 911 74053 688 >> SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg >> GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton >> HRB 21284 (AG Nürnberg) > > Ok, but to clarify... > * Will the cciss driver be removed when these patches are applied? Otherwise > what will prevent the cciss driver from loading over these devices? > i.e. how often will users need to be reminded to add > cciss.cciss_allow_hpsa flag? > > The idea is to remove the cciss driver completely once these changes are in. Preferably with the same patchset to avoid any timing issues. Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)
RE: [PATCH RESEND 0/6] hpsa: support legacy boards
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Friday, August 11, 2017 1:43 AM > To: Don Brace ; James Bottomley > ; Christoph Hellwig > > Cc: Martin K. Petersen ; Meelis Roos > ; linux-scsi@vger.kernel.org > Subject: Re: [PATCH RESEND 0/6] hpsa: support legacy boards > > EXTERNAL EMAIL ... > > > > Ok, but to clarify... > > * Will the cciss driver be removed when these patches are applied? > Otherwise > > what will prevent the cciss driver from loading over these devices? > > i.e. how often will users need to be reminded to add > cciss.cciss_allow_hpsa flag? > > > > > The idea is to remove the cciss driver completely once these changes are > in. Preferably with the same patchset to avoid any timing issues. > > Cheers, > > Hannes > -- > Dr. Hannes ReineckeTeamlead Storage & Networking > h...@suse.de +49 911 74053 688 > SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg > GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton > HRB 21284 (AG Nürnberg) OK, then I ACK the series once the reviews by others have been resolved. Thank-you and everyone else for your patches and attention to this issue. And thanks to everyone for your input. Acked-by: Don Brace
