Re: [PATCH V2 1/4] scsi_transport_iscsi: Exporting new attrs for iscsi session and connection in sysfs

[Mike Christie]

The V2 of this patchset looks ok now. I did a quick compile test to
verify they apply and compile against the current scsi misc code that
has Eddie's changes in it.

James, sorry about the mismatch on the V1. I forgot Eddie's patches were
getting merged and would conflict with Vikas's patches in this set.

Reviewed-by: Mike Christie 



On 07/01/2013 04:54 AM, vikas.chaudh...@qlogic.com wrote:
> From: Adheer Chandravanshi 
> 
> Exporting new iSCSI Session and Connection parameters to sysfs
> 
> Signed-off-by: Adheer Chandravanshi 
> Signed-off-by: Vikas Chaudhary 
> ---

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH V2 1/4] scsi_transport_iscsi: Exporting new attrs for iscsi session and connection in sysfs

[vikas.chaudhary]

From: Adheer Chandravanshi 

Exporting new iSCSI Session and Connection parameters to sysfs

Signed-off-by: Adheer Chandravanshi 
Signed-off-by: Vikas Chaudhary 
---
 drivers/scsi/scsi_transport_iscsi.c |  123 ++-
 include/scsi/iscsi_if.h |   32 +
 2 files changed, 154 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/scsi_transport_iscsi.c 
b/drivers/scsi/scsi_transport_iscsi.c
index abf7c40..e4a989f 100644
--- a/drivers/scsi/scsi_transport_iscsi.c
+++ b/drivers/scsi/scsi_transport_iscsi.c
@@ -25,7 +25,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -3327,6 +3326,23 @@ iscsi_conn_attr(exp_statsn, ISCSI_PARAM_EXP_STATSN);
 iscsi_conn_attr(persistent_address, ISCSI_PARAM_PERSISTENT_ADDRESS);
 iscsi_conn_attr(ping_tmo, ISCSI_PARAM_PING_TMO);
 iscsi_conn_attr(recv_tmo, ISCSI_PARAM_RECV_TMO);
+iscsi_conn_attr(local_port, ISCSI_PARAM_LOCAL_PORT);
+iscsi_conn_attr(statsn, ISCSI_PARAM_STATSN);
+iscsi_conn_attr(keepalive_tmo, ISCSI_PARAM_KEEPALIVE_TMO);
+iscsi_conn_attr(max_segment_size, ISCSI_PARAM_MAX_SEGMENT_SIZE);
+iscsi_conn_attr(tcp_timestamp_stat, ISCSI_PARAM_TCP_TIMESTAMP_STAT);
+iscsi_conn_attr(tcp_wsf_disable, ISCSI_PARAM_TCP_WSF_DISABLE);
+iscsi_conn_attr(tcp_nagle_disable, ISCSI_PARAM_TCP_NAGLE_DISABLE);
+iscsi_conn_attr(tcp_timer_scale, ISCSI_PARAM_TCP_TIMER_SCALE);
+iscsi_conn_attr(tcp_timestamp_enable, ISCSI_PARAM_TCP_TIMESTAMP_EN);
+iscsi_conn_attr(fragment_disable, ISCSI_PARAM_IP_FRAGMENT_DISABLE);
+iscsi_conn_attr(ipv4_tos, ISCSI_PARAM_IPV4_TOS);
+iscsi_conn_attr(ipv6_traffic_class, ISCSI_PARAM_IPV6_TC);
+iscsi_conn_attr(ipv6_flow_label, ISCSI_PARAM_IPV6_FLOW_LABEL);
+iscsi_conn_attr(is_fw_assigned_ipv6, ISCSI_PARAM_IS_FW_ASSIGNED_IPV6);
+iscsi_conn_attr(tcp_xmit_wsf, ISCSI_PARAM_TCP_XMIT_WSF);
+iscsi_conn_attr(tcp_recv_wsf, ISCSI_PARAM_TCP_RECV_WSF);
+
 
 #define iscsi_conn_ep_attr_show(param) \
 static ssize_t show_conn_ep_param_##param(struct device *dev,  \
@@ -3379,6 +3395,22 @@ static struct attribute *iscsi_conn_attrs[] = {
&dev_attr_conn_persistent_port.attr,
&dev_attr_conn_ping_tmo.attr,
&dev_attr_conn_recv_tmo.attr,
+   &dev_attr_conn_local_port.attr,
+   &dev_attr_conn_statsn.attr,
+   &dev_attr_conn_keepalive_tmo.attr,
+   &dev_attr_conn_max_segment_size.attr,
+   &dev_attr_conn_tcp_timestamp_stat.attr,
+   &dev_attr_conn_tcp_wsf_disable.attr,
+   &dev_attr_conn_tcp_nagle_disable.attr,
+   &dev_attr_conn_tcp_timer_scale.attr,
+   &dev_attr_conn_tcp_timestamp_enable.attr,
+   &dev_attr_conn_fragment_disable.attr,
+   &dev_attr_conn_ipv4_tos.attr,
+   &dev_attr_conn_ipv6_traffic_class.attr,
+   &dev_attr_conn_ipv6_flow_label.attr,
+   &dev_attr_conn_is_fw_assigned_ipv6.attr,
+   &dev_attr_conn_tcp_xmit_wsf.attr,
+   &dev_attr_conn_tcp_recv_wsf.attr,
NULL,
 };
 
@@ -3416,6 +3448,38 @@ static umode_t iscsi_conn_attr_is_visible(struct kobject 
*kobj,
param = ISCSI_PARAM_PING_TMO;
else if (attr == &dev_attr_conn_recv_tmo.attr)
param = ISCSI_PARAM_RECV_TMO;
+   else if (attr == &dev_attr_conn_local_port.attr)
+   param = ISCSI_PARAM_LOCAL_PORT;
+   else if (attr == &dev_attr_conn_statsn.attr)
+   param = ISCSI_PARAM_STATSN;
+   else if (attr == &dev_attr_conn_keepalive_tmo.attr)
+   param = ISCSI_PARAM_KEEPALIVE_TMO;
+   else if (attr == &dev_attr_conn_max_segment_size.attr)
+   param = ISCSI_PARAM_MAX_SEGMENT_SIZE;
+   else if (attr == &dev_attr_conn_tcp_timestamp_stat.attr)
+   param = ISCSI_PARAM_TCP_TIMESTAMP_STAT;
+   else if (attr == &dev_attr_conn_tcp_wsf_disable.attr)
+   param = ISCSI_PARAM_TCP_WSF_DISABLE;
+   else if (attr == &dev_attr_conn_tcp_nagle_disable.attr)
+   param = ISCSI_PARAM_TCP_NAGLE_DISABLE;
+   else if (attr == &dev_attr_conn_tcp_timer_scale.attr)
+   param = ISCSI_PARAM_TCP_TIMER_SCALE;
+   else if (attr == &dev_attr_conn_tcp_timestamp_enable.attr)
+   param = ISCSI_PARAM_TCP_TIMESTAMP_EN;
+   else if (attr == &dev_attr_conn_fragment_disable.attr)
+   param = ISCSI_PARAM_IP_FRAGMENT_DISABLE;
+   else if (attr == &dev_attr_conn_ipv4_tos.attr)
+   param = ISCSI_PARAM_IPV4_TOS;
+   else if (attr == &dev_attr_conn_ipv6_traffic_class.attr)
+   param = ISCSI_PARAM_IPV6_TC;
+   else if (attr == &dev_attr_conn_ipv6_flow_label.attr)
+   param = ISCSI_PARAM_IPV6_FLOW_LABEL;
+   else if (attr == &dev_attr_conn_is_fw_assigned_ipv6.attr)
+   param = ISCSI_PARAM_IS_FW_ASSIGNED_IPV6;
+   else if (attr == &dev_attr_conn_tcp_xmit_wsf.attr)
+   param = ISCSI_PARAM_TCP_XMIT_WSF;
+   else if (attr == &dev_attr_conn_tcp_recv_wsf.attr)
+   param = ISCSI_PARAM_TCP_RECV