[PATCH v2 3/5] aic7xxx: remove rules for shipped files
There are Kbuild rules for that already. Signed-off-by: Michał Mirosław --- drivers/scsi/aic7xxx/Makefile | 4 1 file changed, 4 deletions(-) diff --git a/drivers/scsi/aic7xxx/Makefile b/drivers/scsi/aic7xxx/Makefile index b03ba0df7a83..1a5509d40f8a 100644 --- a/drivers/scsi/aic7xxx/Makefile +++ b/drivers/scsi/aic7xxx/Makefile @@ -61,8 +61,6 @@ $(obj)/aic7xxx_seq.h: $(src)/aic7xxx.seq $(src)/aic7xxx.reg $(obj)/aicasm/aicasm $(aic7xxx-gen-y): $(objtree)/$(obj)/aic7xxx_seq.h @true -else -$(obj)/aic7xxx_reg_print.c: $(src)/aic7xxx_reg_print.c_shipped endif aic79xx-gen-$(CONFIG_AIC79XX_BUILD_FIRMWARE) := $(obj)/aic79xx_reg.h @@ -79,8 +77,6 @@ $(obj)/aic79xx_seq.h: $(src)/aic79xx.seq $(src)/aic79xx.reg $(obj)/aicasm/aicasm $(aic79xx-gen-y): $(objtree)/$(obj)/aic79xx_seq.h @true -else -$(obj)/aic79xx_reg_print.c: $(src)/aic79xx_reg_print.c_shipped endif $(obj)/aicasm/aicasm: $(srctree)/$(src)/aicasm/*.[chyl] -- 2.11.0
Re: [PATCH v2 3/5] aic7xxx: remove rules for shipped files
On 08/04/2017 01:28 AM, Michał Mirosław wrote: > There are Kbuild rules for that already. > > Signed-off-by: Michał Mirosław > --- > drivers/scsi/aic7xxx/Makefile | 4 > 1 file changed, 4 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)
Re: [PATCH v2 3/5] aic7xxx: remove rules for shipped files
On Fri, Aug 04, 2017 at 01:28:09AM +0200, Michał Mirosław wrote: [...] > --- a/drivers/scsi/aic7xxx/Makefile > +++ b/drivers/scsi/aic7xxx/Makefile > @@ -61,8 +61,6 @@ $(obj)/aic7xxx_seq.h: $(src)/aic7xxx.seq $(src)/aic7xxx.reg > $(obj)/aicasm/aicasm [...] > -else > -$(obj)/aic7xxx_reg_print.c: $(src)/aic7xxx_reg_print.c_shipped [...] Hi, Please drop this patch (only this one). I didn't notice, that the file is needed by modpost: Building modules, stage 2. MODPOST 785 modules WARNING: could not open drivers/scsi/aic7xxx/aic79xx_reg_print.c: No such file or directory LD [M] drivers/scsi/aic7xxx/aic79xx.ko Best Regards, Michał Mirosław
Re: [PATCH v2 3/5] aic7xxx: remove rules for shipped files
Michał, > Please drop this patch (only this one). I didn't notice, that the file > is needed by modpost: OK, done. -- Martin K. Petersen Oracle Linux Engineering