Re: [PATCH v2 6/8] qla2xxx: disable scsi_transport_fc registration in target mode

[Hannes Reinecke]

On 07/14/2015 10:00 PM, Himanshu Madhani wrote:
> From: Alexei Potashnik 
> 
> There are multiple reasons for disabling this:
> 
> 1. It provides no functional benefit. We pretty much only get a few more
> sysfs entries for each port, but all that information is already
> available from /sys/kernel/debug/target/qla-session-X
> 
> 2. It already only works in private-loop mode. By disabling we'll be
> getting more uniform behavior with fabric mode.
> 
> 3. It creates complications for the new PLOGI handling mechanism:
> scsi_transport_fc port deletion timer could race with new session
> from initiator and cause logout after successful login.
> 
> Cc: 
> Signed-off-by: Alexei Potashnik 
> Signed-off-by: Himanshu Madhani 
> ---
Reviewed-by: Hannes Reinecke 

Cheers,

Hannes
-- 
Dr. Hannes ReineckezSeries & Storage
h...@suse.de   +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 6/8] qla2xxx: disable scsi_transport_fc registration in target mode

[Himanshu Madhani]

From: Alexei Potashnik 

There are multiple reasons for disabling this:

1. It provides no functional benefit. We pretty much only get a few more
sysfs entries for each port, but all that information is already
available from /sys/kernel/debug/target/qla-session-X

2. It already only works in private-loop mode. By disabling we'll be
getting more uniform behavior with fabric mode.

3. It creates complications for the new PLOGI handling mechanism:
scsi_transport_fc port deletion timer could race with new session
from initiator and cause logout after successful login.

Cc: 
Signed-off-by: Alexei Potashnik 
Signed-off-by: Himanshu Madhani 
---
 drivers/scsi/qla2xxx/qla_init.c |   14 +++---
 drivers/scsi/qla2xxx/qla_os.c   |3 ++-
 2 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c
index 3f3cdbf..5ba5851 100644
--- a/drivers/scsi/qla2xxx/qla_init.c
+++ b/drivers/scsi/qla2xxx/qla_init.c
@@ -3338,8 +3338,7 @@ qla2x00_update_fcport(scsi_qla_host_t *vha, fc_port_t 
*fcport)
 
if (IS_QLAFX00(vha->hw)) {
qla2x00_set_fcport_state(fcport, FCS_ONLINE);
-   qla2x00_reg_remote_port(vha, fcport);
-   return;
+   goto reg_port;
}
fcport->login_retry = 0;
fcport->flags &= ~(FCF_LOGIN_NEEDED | FCF_ASYNC_SENT);
@@ -3347,7 +3346,16 @@ qla2x00_update_fcport(scsi_qla_host_t *vha, fc_port_t 
*fcport)
qla2x00_set_fcport_state(fcport, FCS_ONLINE);
qla2x00_iidma_fcport(vha, fcport);
qla24xx_update_fcport_fcp_prio(vha, fcport);
-   qla2x00_reg_remote_port(vha, fcport);
+
+reg_port:
+   if (qla_ini_mode_enabled(vha))
+   qla2x00_reg_remote_port(vha, fcport);
+   else {
+   /*
+* Create target mode FC NEXUS in qla_target.c
+*/
+   qlt_fc_port_added(vha, fcport);
+   }
 }
 
 /*
diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
index be6de2a..8a5cac8 100644
--- a/drivers/scsi/qla2xxx/qla_os.c
+++ b/drivers/scsi/qla2xxx/qla_os.c
@@ -3235,7 +3235,8 @@ qla2x00_schedule_rport_del(struct scsi_qla_host *vha, 
fc_port_t *fcport,
qla2xxx_wake_dpc(base_vha);
} else {
int now;
-   fc_remote_port_delete(rport);
+   if (rport)
+   fc_remote_port_delete(rport);
qlt_do_generation_tick(vha, &now);
qlt_fc_port_deleted(vha, fcport, now);
}
-- 
1.7.7

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html