RE: [PATCH v2 8/8] scsi: ufs: connect to RPMB subsystem
> > On 4/7/2016 10:15 PM, Winkler, Tomas wrote: > > On Wed, 2016-04-06 at 09:51 +0100, Joao Pinto wrote: > >> Hi! > >> > >> On 4/4/2016 12:11 PM, Tomas Winkler wrote: > >>> Register UFS RPMB LUN with the RPMB subsystem and provide > >>> implementation for the RPMB access operations. RPMB partition is > >>> accessed via a sequence of security protocol in and security > >>> protocol out commands with UFS specific parameters. This multi step > >>> process is abstracted into 4 basic RPMB commands. > >> > >> [snip] > >> > >>>* "UFS device" W-LU. > >>>*/ > >>> struct scsi_device *sdev_ufs_device; > >>> + struct scsi_device *sdev_ufs_rpmb; > >>> > >>> enum ufs_dev_pwr_mode curr_dev_pwr_mode; > >>> enum uic_link_state uic_link_state; > >>> > >> > >> I have a UFS device emulator that has the RPMB capability. What are > >> the expected good results for me to validate? > > > > Hi Joao, thanks for that. I'm attaching an archive with few basic > > samples via user space interface. > > You should run the program key first (program-key.sh), just don't do > > it on a real device it's one in life time operation. > > > > Managed to cross-compile to ARC and execute your test app in my platform. > I made it in Buildroot, so I have the patches to enable the tool cross- > compilation if necessary in the future. > Sounds like fun :) I've just tried to follow the standard under tools, though this it's not something really generic which was surpising to me as this is in the kernel tree. > The tool execution gives no errors, but also no info. I suggest you had > success > info and maybe some statistic (e.g. bytes read or written). It did have some verbose print outs on both ends, but I've cleaned it out. It was meant to be an example rather than unit testing tool, but we can repurpose it. Thanks Toma Thanks Tomas
Re: [PATCH v2 8/8] scsi: ufs: connect to RPMB subsystem
Hi, On 4/7/2016 10:15 PM, Winkler, Tomas wrote: > On Wed, 2016-04-06 at 09:51 +0100, Joao Pinto wrote: >> Hi! >> >> On 4/4/2016 12:11 PM, Tomas Winkler wrote: >>> Register UFS RPMB LUN with the RPMB subsystem and provide >>> implementation for the RPMB access operations. RPMB partition is >>> accessed via a sequence of security protocol in and security >>> protocol >>> out commands with UFS specific parameters. This multi step process >>> is >>> abstracted into 4 basic RPMB commands. >> >> [snip] >> >>> * "UFS device" W-LU. >>> */ >>> struct scsi_device *sdev_ufs_device; >>> + struct scsi_device *sdev_ufs_rpmb; >>> >>> enum ufs_dev_pwr_mode curr_dev_pwr_mode; >>> enum uic_link_state uic_link_state; >>> >> >> I have a UFS device emulator that has the RPMB capability. What are >> the expected >> good results for me to validate? > > Hi Joao, thanks for that. I'm attaching an archive with few basic > samples via user space interface. > You should run the program key first (program-key.sh), just don't do it > on a real device it's one in life time operation. > Managed to cross-compile to ARC and execute your test app in my platform. I made it in Buildroot, so I have the patches to enable the tool cross-compilation if necessary in the future. The tool execution gives no errors, but also no info. I suggest you had success info and maybe some statistic (e.g. bytes read or written). > Thanks > Tomas > Thanks, Joao -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 8/8] scsi: ufs: connect to RPMB subsystem
On 4/7/2016 10:15 PM, Winkler, Tomas wrote: > On Wed, 2016-04-06 at 09:51 +0100, Joao Pinto wrote: >> Hi! >> >> On 4/4/2016 12:11 PM, Tomas Winkler wrote: >>> Register UFS RPMB LUN with the RPMB subsystem and provide >>> implementation for the RPMB access operations. RPMB partition is >>> accessed via a sequence of security protocol in and security >>> protocol >>> out commands with UFS specific parameters. This multi step process >>> is >>> abstracted into 4 basic RPMB commands. >> >> [snip] >> >>> * "UFS device" W-LU. >>> */ >>> struct scsi_device *sdev_ufs_device; >>> + struct scsi_device *sdev_ufs_rpmb; >>> >>> enum ufs_dev_pwr_mode curr_dev_pwr_mode; >>> enum uic_link_state uic_link_state; >>> >> >> I have a UFS device emulator that has the RPMB capability. What are >> the expected >> good results for me to validate? > > Hi Joao, thanks for that. I'm attaching an archive with few basic > samples via user space interface. > You should run the program key first (program-key.sh), just don't do it > on a real device it's one in life time operation. Sorry, I have received the attachment. Going to explore it now. > > Thanks > Tomas > Joao -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 8/8] scsi: ufs: connect to RPMB subsystem
Hi, On 4/7/2016 10:15 PM, Winkler, Tomas wrote: > On Wed, 2016-04-06 at 09:51 +0100, Joao Pinto wrote: >> Hi! >> >> On 4/4/2016 12:11 PM, Tomas Winkler wrote: >>> Register UFS RPMB LUN with the RPMB subsystem and provide >>> implementation for the RPMB access operations. RPMB partition is >>> accessed via a sequence of security protocol in and security >>> protocol >>> out commands with UFS specific parameters. This multi step process >>> is >>> abstracted into 4 basic RPMB commands. >> >> [snip] >> >>> * "UFS device" W-LU. >>> */ >>> struct scsi_device *sdev_ufs_device; >>> + struct scsi_device *sdev_ufs_rpmb; >>> >>> enum ufs_dev_pwr_mode curr_dev_pwr_mode; >>> enum uic_link_state uic_link_state; >>> >> >> I have a UFS device emulator that has the RPMB capability. What are >> the expected >> good results for me to validate? > > Hi Joao, thanks for that. I'm attaching an archive with few basic > samples via user space interface. > You should run the program key first (program-key.sh), just don't do it > on a real device it's one in life time operation. > > Thanks > Tomas > I have tested your patch set the following way: Patches applied: - Got 4.7-queue from the SCSI repo - Applied the patch set for DW UFS support - Applied your patch set for RPMB support Platform (UFS IP Prototyping Kit): - CPU: ARC CPU 32-bit - UFS 2.0 Core running in FPGA Results: Kernel Build without RPMB configured: OK Kernel Build with RPMB configured: OK UFS Device partitions shown in UFS Host without RPMB configured: Yes UFS Device partitions shown in UFS Host with RPMB configured: Yes I would like to run more verifications regarding RPMB. Could you tell me what is the procedure you suggest? Thanks, Joao -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 8/8] scsi: ufs: connect to RPMB subsystem
Hi! On 4/7/2016 10:15 PM, Winkler, Tomas wrote: > On Wed, 2016-04-06 at 09:51 +0100, Joao Pinto wrote: >> Hi! >> >> On 4/4/2016 12:11 PM, Tomas Winkler wrote: >>> Register UFS RPMB LUN with the RPMB subsystem and provide >>> implementation for the RPMB access operations. RPMB partition is >>> accessed via a sequence of security protocol in and security >>> protocol >>> out commands with UFS specific parameters. This multi step process >>> is >>> abstracted into 4 basic RPMB commands. >> >> [snip] >> >>> * "UFS device" W-LU. >>> */ >>> struct scsi_device *sdev_ufs_device; >>> + struct scsi_device *sdev_ufs_rpmb; >>> >>> enum ufs_dev_pwr_mode curr_dev_pwr_mode; >>> enum uic_link_state uic_link_state; >>> >> >> I have a UFS device emulator that has the RPMB capability. What are >> the expected >> good results for me to validate? > > Hi Joao, thanks for that. I'm attaching an archive with few basic > samples via user space interface. > You should run the program key first (program-key.sh), just don't do it > on a real device it's one in life time operation. No attachment received. > > Thanks > Tomas > Thanks, Joao -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 8/8] scsi: ufs: connect to RPMB subsystem
On Wed, 2016-04-06 at 09:51 +0100, Joao Pinto wrote: > Hi! > > On 4/4/2016 12:11 PM, Tomas Winkler wrote: > > Register UFS RPMB LUN with the RPMB subsystem and provide > > implementation for the RPMB access operations. RPMB partition is > > accessed via a sequence of security protocol in and security > > protocol > > out commands with UFS specific parameters. This multi step process > > is > > abstracted into 4 basic RPMB commands. > > [snip] > > > * "UFS device" W-LU. > > */ > > struct scsi_device *sdev_ufs_device; > > + struct scsi_device *sdev_ufs_rpmb; > > > > enum ufs_dev_pwr_mode curr_dev_pwr_mode; > > enum uic_link_state uic_link_state; > > > > I have a UFS device emulator that has the RPMB capability. What are > the expected > good results for me to validate? Hi Joao, thanks for that. I'm attaching an archive with few basic samples via user space interface. You should run the program key first (program-key.sh), just don't do it on a real device it's one in life time operation. Thanks Tomas rpmb-scripts.tar.bz2 Description: rpmb-scripts.tar.bz2
Re: [PATCH v2 8/8] scsi: ufs: connect to RPMB subsystem
Hi! On 4/4/2016 12:11 PM, Tomas Winkler wrote: > Register UFS RPMB LUN with the RPMB subsystem and provide > implementation for the RPMB access operations. RPMB partition is > accessed via a sequence of security protocol in and security protocol > out commands with UFS specific parameters. This multi step process is > abstracted into 4 basic RPMB commands. [snip] >* "UFS device" W-LU. >*/ > struct scsi_device *sdev_ufs_device; > + struct scsi_device *sdev_ufs_rpmb; > > enum ufs_dev_pwr_mode curr_dev_pwr_mode; > enum uic_link_state uic_link_state; > I have a UFS device emulator that has the RPMB capability. What are the expected good results for me to validate? Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v2 8/8] scsi: ufs: connect to RPMB subsystem
Register UFS RPMB LUN with the RPMB subsystem and provide
implementation for the RPMB access operations. RPMB partition is
accessed via a sequence of security protocol in and security protocol
out commands with UFS specific parameters. This multi step process is
abstracted into 4 basic RPMB commands.
Signed-off-by: Alexander Usyskin
Signed-off-by: Tomas Winkler
---
V2: resend
drivers/scsi/ufs/ufshcd.c | 219 ++
drivers/scsi/ufs/ufshcd.h | 2 +
2 files changed, 221 insertions(+)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index f8fa72c31a9d..c087e9713db3 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -37,10 +37,13 @@
* license terms, and distributes only under these terms.
*/
+#include
#include
#include
#include
#include
+#include
+
#include "ufshcd.h"
#include "ufs_quirks.h"
#include "unipro.h"
@@ -4744,6 +4747,214 @@ static void ufshcd_init_icc_levels(struct ufs_hba *hba)
}
+#define SEC_PROTOCOL_UFS 0xEC
+#define SEC_SPECIFIC_UFS_RPMB 0x0001
+
+#define SEC_PROTOCOL_CMD_SIZE 12
+#define SEC_PROTOCOL_RETRIES 3
+#define SEC_PROTOCOL_RETRIES_ON_RESET 10
+#define SEC_PROTOCOL_TIMEOUT msecs_to_jiffies(1000)
+
+static int
+ufshcd_rpmb_security_out(struct scsi_device *sdev,
+struct rpmb_frame *frames, u32 cnt)
+{
+ struct scsi_sense_hdr sshdr;
+ u32 trans_len = cnt * sizeof(struct rpmb_frame);
+ int reset_retries = SEC_PROTOCOL_RETRIES_ON_RESET;
+ int ret;
+ u8 cmd[SEC_PROTOCOL_CMD_SIZE];
+
+retry:
+ memset(cmd, 0, SEC_PROTOCOL_CMD_SIZE);
+ cmd[0] = SECURITY_PROTOCOL_OUT;
+ cmd[1] = SEC_PROTOCOL_UFS;
+ put_unaligned_be16(SEC_SPECIFIC_UFS_RPMB, cmd + 2);
+ cmd[4] = 0; /* inc_512 bit 7 set to 0 */
+ put_unaligned_be32(trans_len, cmd + 6); /* transfer length */
+
+ ret = scsi_execute_req_flags(sdev, cmd, DMA_TO_DEVICE,
+frames, trans_len, &sshdr,
+SEC_PROTOCOL_TIMEOUT, SEC_PROTOCOL_RETRIES,
+NULL, 0);
+ if (ret && scsi_sense_valid(&sshdr) &&
+ sshdr.sense_key == UNIT_ATTENTION &&
+ sshdr.asc == 0x29 && sshdr.ascq == 0x00)
+ /* Device reset might occur several times,
+* give it one more chance
+*/
+ if (--reset_retries > 0)
+ goto retry;
+
+ if (ret)
+ pr_err("%s: failed with err %0x\n", __func__, ret);
+
+ if (driver_byte(ret) & DRIVER_SENSE)
+ scsi_print_sense_hdr(sdev, "rpmb: security out", &sshdr);
+
+ return ret;
+}
+
+static int
+ufshcd_rpmb_security_in(struct scsi_device *sdev,
+ struct rpmb_frame *frames, u32 cnt)
+{
+ struct scsi_sense_hdr sshdr;
+ u32 alloc_len = cnt * sizeof(struct rpmb_frame);
+ int reset_retries = SEC_PROTOCOL_RETRIES_ON_RESET;
+ int ret;
+ u8 cmd[SEC_PROTOCOL_CMD_SIZE];
+
+retry:
+ memset(cmd, 0, SEC_PROTOCOL_CMD_SIZE);
+ cmd[0] = SECURITY_PROTOCOL_IN;
+ cmd[1] = SEC_PROTOCOL_UFS;
+ put_unaligned_be16(SEC_SPECIFIC_UFS_RPMB, cmd + 2);
+ cmd[4] = 0; /* inc_512 bit 7 set to 0 */
+ put_unaligned_be32(alloc_len, cmd + 6); /* allocation length */
+
+ ret = scsi_execute_req_flags(sdev, cmd, DMA_FROM_DEVICE,
+frames, alloc_len, &sshdr,
+SEC_PROTOCOL_TIMEOUT, SEC_PROTOCOL_RETRIES,
+NULL, 0);
+ if (ret && scsi_sense_valid(&sshdr) &&
+ sshdr.sense_key == UNIT_ATTENTION &&
+ sshdr.asc == 0x29 && sshdr.ascq == 0x00)
+ /* Device reset might occur several times,
+* give it one more chance
+*/
+ if (--reset_retries > 0)
+ goto retry;
+
+ if (ret)
+ pr_err("%s: failed with err %0x\n", __func__, ret);
+
+ if (driver_byte(ret) & DRIVER_SENSE)
+ scsi_print_sense_hdr(sdev, "rpmb: security in", &sshdr);
+
+ return ret;
+}
+
+
+static int ufshcd_rpmb_send_req(struct device *dev, struct rpmb_data *rpmbd)
+{
+ unsigned long flags;
+ struct ufs_hba *hba = dev_get_drvdata(dev);
+ struct scsi_device *sdev;
+ struct rpmb_frame *in_frames, *out_frames;
+ u16 blks;
+ u16 type;
+ int ret;
+
+ in_frames = rpmbd->in_frames;
+ out_frames = rpmbd->out_frames;
+
+ type = rpmbd->req_type;
+ blks = be16_to_cpu(in_frames[0].block_count);
+
+ dev_dbg(hba->dev, "RPMB : type = %d, blocks = %d\n", type, blks);
+
+ spin_lock_irqsave(hba->host->host_lock, flags);
+ sdev = hba->sdev_ufs_rpmb;
+ if (sdev) {
+ ret = scsi_device_get(sdev);
+
