Re: [PATCH v2 RESEND 15/23] mpt2sas: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-08-11 Thread Tomas Henzl 
On 07/16/2014 08:05 PM, Alexander Gordeev wrote:
 As result of deprecation of MSI-X/MSI enablement functions
 pci_enable_msix() and pci_enable_msi_block() all drivers
 using these two interfaces need to be updated to use the
 new pci_enable_msi_range()  or pci_enable_msi_exact()
 and pci_enable_msix_range() or pci_enable_msix_exact()
 interfaces.

 Signed-off-by: Alexander Gordeev agord...@redhat.com
 Cc: Nagalakshmi Nandigama nagalakshmi.nandig...@lsi.com
 Cc: Sreekanth Reddy sreekanth.re...@lsi.com
 Cc: supp...@lsi.com
 Cc: dl-mptfusionli...@lsi.com
 Cc: linux-scsi@vger.kernel.org
 Cc: linux-...@vger.kernel.org

Looks good

Reviewed-by: Tomas Henzl the...@redhat.com

 ---
  drivers/scsi/mpt2sas/mpt2sas_base.c |6 +++---
  1 files changed, 3 insertions(+), 3 deletions(-)

 diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.c 
 b/drivers/scsi/mpt2sas/mpt2sas_base.c
 index 8b88118..6aca369 100644
 --- a/drivers/scsi/mpt2sas/mpt2sas_base.c
 +++ b/drivers/scsi/mpt2sas/mpt2sas_base.c
 @@ -1432,10 +1432,10 @@ _base_enable_msix(struct MPT2SAS_ADAPTER *ioc)
   for (i = 0, a = entries; i  ioc-reply_queue_count; i++, a++)
   a-entry = i;
  
 - r = pci_enable_msix(ioc-pdev, entries, ioc-reply_queue_count);
 + r = pci_enable_msix_exact(ioc-pdev, entries, ioc-reply_queue_count);
   if (r) {
 - dfailprintk(ioc, printk(MPT2SAS_INFO_FMT pci_enable_msix 
 - failed (r=%d) !!!\n, ioc-name, r));
 + dfailprintk(ioc, printk(MPT2SAS_INFO_FMT
 + pci_enable_msix_exact failed (r=%d) !!!\n, ioc-name, r));
   kfree(entries);
   goto try_ioapic;
   }

--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 RESEND 15/23] mpt2sas: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-07-26 Thread Alexander Gordeev 
On Wed, Jul 16, 2014 at 08:05:19PM +0200, Alexander Gordeev wrote:
 As result of deprecation of MSI-X/MSI enablement functions
 pci_enable_msix() and pci_enable_msi_block() all drivers
 using these two interfaces need to be updated to use the
 new pci_enable_msi_range()  or pci_enable_msi_exact()
 and pci_enable_msix_range() or pci_enable_msix_exact()
 interfaces.

Hi Nagalakshmi, Sreekanth,

Could you please review mpt patches in this series?

Thanks!

 Signed-off-by: Alexander Gordeev agord...@redhat.com
 Cc: Nagalakshmi Nandigama nagalakshmi.nandig...@lsi.com
 Cc: Sreekanth Reddy sreekanth.re...@lsi.com
 Cc: supp...@lsi.com
 Cc: dl-mptfusionli...@lsi.com
 Cc: linux-scsi@vger.kernel.org
 Cc: linux-...@vger.kernel.org
 ---
  drivers/scsi/mpt2sas/mpt2sas_base.c |6 +++---
  1 files changed, 3 insertions(+), 3 deletions(-)
 
 diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.c 
 b/drivers/scsi/mpt2sas/mpt2sas_base.c
 index 8b88118..6aca369 100644
 --- a/drivers/scsi/mpt2sas/mpt2sas_base.c
 +++ b/drivers/scsi/mpt2sas/mpt2sas_base.c
 @@ -1432,10 +1432,10 @@ _base_enable_msix(struct MPT2SAS_ADAPTER *ioc)
   for (i = 0, a = entries; i  ioc-reply_queue_count; i++, a++)
   a-entry = i;
  
 - r = pci_enable_msix(ioc-pdev, entries, ioc-reply_queue_count);
 + r = pci_enable_msix_exact(ioc-pdev, entries, ioc-reply_queue_count);
   if (r) {
 - dfailprintk(ioc, printk(MPT2SAS_INFO_FMT pci_enable_msix 
 - failed (r=%d) !!!\n, ioc-name, r));
 + dfailprintk(ioc, printk(MPT2SAS_INFO_FMT
 + pci_enable_msix_exact failed (r=%d) !!!\n, ioc-name, r));
   kfree(entries);
   goto try_ioapic;
   }
 -- 
 1.7.7.6
 

-- 
Regards,
Alexander Gordeev
agord...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 RESEND 15/23] mpt2sas: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-07-16 Thread Alexander Gordeev 
As result of deprecation of MSI-X/MSI enablement functions
pci_enable_msix() and pci_enable_msi_block() all drivers
using these two interfaces need to be updated to use the
new pci_enable_msi_range()  or pci_enable_msi_exact()
and pci_enable_msix_range() or pci_enable_msix_exact()
interfaces.

Signed-off-by: Alexander Gordeev agord...@redhat.com
Cc: Nagalakshmi Nandigama nagalakshmi.nandig...@lsi.com
Cc: Sreekanth Reddy sreekanth.re...@lsi.com
Cc: supp...@lsi.com
Cc: dl-mptfusionli...@lsi.com
Cc: linux-scsi@vger.kernel.org
Cc: linux-...@vger.kernel.org
---
 drivers/scsi/mpt2sas/mpt2sas_base.c |6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.c 
b/drivers/scsi/mpt2sas/mpt2sas_base.c
index 8b88118..6aca369 100644
--- a/drivers/scsi/mpt2sas/mpt2sas_base.c
+++ b/drivers/scsi/mpt2sas/mpt2sas_base.c
@@ -1432,10 +1432,10 @@ _base_enable_msix(struct MPT2SAS_ADAPTER *ioc)
for (i = 0, a = entries; i  ioc-reply_queue_count; i++, a++)
a-entry = i;
 
-   r = pci_enable_msix(ioc-pdev, entries, ioc-reply_queue_count);
+   r = pci_enable_msix_exact(ioc-pdev, entries, ioc-reply_queue_count);
if (r) {
-   dfailprintk(ioc, printk(MPT2SAS_INFO_FMT pci_enable_msix 
-   failed (r=%d) !!!\n, ioc-name, r));
+   dfailprintk(ioc, printk(MPT2SAS_INFO_FMT
+   pci_enable_msix_exact failed (r=%d) !!!\n, ioc-name, r));
kfree(entries);
goto try_ioapic;
}
-- 
1.7.7.6

--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 RESEND 15/23] mpt2sas: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-04-14 Thread Alexander Gordeev 
As result of deprecation of MSI-X/MSI enablement functions
pci_enable_msix() and pci_enable_msi_block() all drivers
using these two interfaces need to be updated to use the
new pci_enable_msi_range()  or pci_enable_msi_exact()
and pci_enable_msix_range() or pci_enable_msix_exact()
interfaces.

Signed-off-by: Alexander Gordeev agord...@redhat.com
Cc: Nagalakshmi Nandigama nagalakshmi.nandig...@lsi.com
Cc: Sreekanth Reddy sreekanth.re...@lsi.com
Cc: supp...@lsi.com
Cc: dl-mptfusionli...@lsi.com
Cc: linux-scsi@vger.kernel.org
Cc: linux-...@vger.kernel.org
---
 drivers/scsi/mpt2sas/mpt2sas_base.c |6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.c 
b/drivers/scsi/mpt2sas/mpt2sas_base.c
index bde63f7..984b605 100644
--- a/drivers/scsi/mpt2sas/mpt2sas_base.c
+++ b/drivers/scsi/mpt2sas/mpt2sas_base.c
@@ -1432,10 +1432,10 @@ _base_enable_msix(struct MPT2SAS_ADAPTER *ioc)
for (i = 0, a = entries; i  ioc-reply_queue_count; i++, a++)
a-entry = i;
 
-   r = pci_enable_msix(ioc-pdev, entries, ioc-reply_queue_count);
+   r = pci_enable_msix_exact(ioc-pdev, entries, ioc-reply_queue_count);
if (r) {
-   dfailprintk(ioc, printk(MPT2SAS_INFO_FMT pci_enable_msix 
-   failed (r=%d) !!!\n, ioc-name, r));
+   dfailprintk(ioc, printk(MPT2SAS_INFO_FMT
+   pci_enable_msix_exact failed (r=%d) !!!\n, ioc-name, r));
kfree(entries);
goto try_ioapic;
}
-- 
1.7.7.6

--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html