[PATCH v4 5/5] target: Return ABORTED_COMMAND sense key for PI errors

2015-07-08 Thread Sagi Grimberg
PI errors were reported with ILLEGAL_REQUEST sense key but
there was actually no problem with the request. Target
detected PI errors should be reported with aborted command
sense key.

Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
 drivers/target/target_core_transport.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/target/target_core_transport.c 
b/drivers/target/target_core_transport.c
index 923e69d..1847fdc 100644
--- a/drivers/target/target_core_transport.c
+++ b/drivers/target/target_core_transport.c
@@ -2705,19 +2705,19 @@ static const struct sense_info sense_info_table[] = {
.ascq = 0x00,
},
[TCM_LOGICAL_BLOCK_GUARD_CHECK_FAILED] = {
-   .key = ILLEGAL_REQUEST,
+   .key = ABORTED_COMMAND,
.asc = 0x10,
.ascq = 0x01, /* LOGICAL BLOCK GUARD CHECK FAILED */
.add_sector_info = true,
},
[TCM_LOGICAL_BLOCK_APP_TAG_CHECK_FAILED] = {
-   .key = ILLEGAL_REQUEST,
+   .key = ABORTED_COMMAND,
.asc = 0x10,
.ascq = 0x02, /* LOGICAL BLOCK APPLICATION TAG CHECK FAILED */
.add_sector_info = true,
},
[TCM_LOGICAL_BLOCK_REF_TAG_CHECK_FAILED] = {
-   .key = ILLEGAL_REQUEST,
+   .key = ABORTED_COMMAND,
.asc = 0x10,
.ascq = 0x03, /* LOGICAL BLOCK REFERENCE TAG CHECK FAILED */
.add_sector_info = true,
-- 
1.8.4.3

--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH v4 5/5] target: Return ABORTED_COMMAND sense key for PI errors

2015-07-08 Thread Hannes Reinecke
On 07/08/2015 04:58 PM, Sagi Grimberg wrote:
 PI errors were reported with ILLEGAL_REQUEST sense key but
 there was actually no problem with the request. Target
 detected PI errors should be reported with aborted command
 sense key.
 
 Signed-off-by: Sagi Grimberg sa...@mellanox.com
 ---
  drivers/target/target_core_transport.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
 
 diff --git a/drivers/target/target_core_transport.c 
 b/drivers/target/target_core_transport.c
 index 923e69d..1847fdc 100644
 --- a/drivers/target/target_core_transport.c
 +++ b/drivers/target/target_core_transport.c
 @@ -2705,19 +2705,19 @@ static const struct sense_info sense_info_table[] = {
   .ascq = 0x00,
   },
   [TCM_LOGICAL_BLOCK_GUARD_CHECK_FAILED] = {
 - .key = ILLEGAL_REQUEST,
 + .key = ABORTED_COMMAND,
   .asc = 0x10,
   .ascq = 0x01, /* LOGICAL BLOCK GUARD CHECK FAILED */
   .add_sector_info = true,
   },
   [TCM_LOGICAL_BLOCK_APP_TAG_CHECK_FAILED] = {
 - .key = ILLEGAL_REQUEST,
 + .key = ABORTED_COMMAND,
   .asc = 0x10,
   .ascq = 0x02, /* LOGICAL BLOCK APPLICATION TAG CHECK FAILED */
   .add_sector_info = true,
   },
   [TCM_LOGICAL_BLOCK_REF_TAG_CHECK_FAILED] = {
 - .key = ILLEGAL_REQUEST,
 + .key = ABORTED_COMMAND,
   .asc = 0x10,
   .ascq = 0x03, /* LOGICAL BLOCK REFERENCE TAG CHECK FAILED */
   .add_sector_info = true,
 
Reviewed-by: Hannes Reinecke h...@suse.de

Cheers,

Hannes
-- 
Dr. Hannes ReineckezSeries  Storage
h...@suse.de   +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html