Re: [patch 09/28] SCSI: Fix obvious typo "spin_lock_irqrestore()" in gdth.c

[James Bottomley]

On Thu, 2007-05-10 at 23:00 -0700, [EMAIL PROTECTED] wrote:
> From: "Robert P. J. Day" <[EMAIL PROTECTED]>
> 
> Fix misspelled "spin_lock_irqrestore" to read "spin_unlock_irqrestore"
> instead.
> 
> Presumably, GDTH_RTC doesn't get used a lot.

I can't actually find a way to get the driver compiled with GDTH_RTC.

Achim, Is it dead code and therefore can it be removed?

James


-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[patch 09/28] SCSI: Fix obvious typo "spin_lock_irqrestore()" in gdth.c

[akpm]

From: "Robert P. J. Day" <[EMAIL PROTECTED]>

Fix misspelled "spin_lock_irqrestore" to read "spin_unlock_irqrestore"
instead.

Presumably, GDTH_RTC doesn't get used a lot.

Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
Cc: <[EMAIL PROTECTED]>
Cc: James Bottomley <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
---

 drivers/scsi/gdth.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN 
drivers/scsi/gdth.c~scsi-fix-obvious-typo-spin_lock_irqrestore-in-gdthc 
drivers/scsi/gdth.c
--- a/drivers/scsi/gdth.c~scsi-fix-obvious-typo-spin_lock_irqrestore-in-gdthc
+++ a/drivers/scsi/gdth.c
@@ -1955,7 +1955,7 @@ static int __init gdth_search_drives(int
 for (j = 0; j < 12; ++j) 
 rtc[j] = CMOS_READ(j);
 } while (rtc[0] != CMOS_READ(0));
-spin_lock_irqrestore(&rtc_lock, flags);
+spin_unlock_irqrestore(&rtc_lock, flags);
 TRACE2(("gdth_search_drives(): RTC: %x/%x/%x\n",*(ulong32 *)&rtc[0],
 *(ulong32 *)&rtc[4], *(ulong32 *)&rtc[8]));
 /* 3. send to controller firmware */
_
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html