RE: [PATCH 4/6] mpt fusion: Creation of mptsas.h header file

2007-08-14 Thread Moore, Eric
On Tuesday, August 14, 2007 12:50 PM, Matthew Wilcox wrote:  
> On Tue, Aug 14, 2007 at 04:15:38PM +0530, Prakash, Sathya wrote:
> > The data structure definitions from mptsas.c are moved to a 
> new header file mptsas.h
> 
> Why?  Are they used outside mptsas.c in some future patch?
> 

Having rougly 10 data structures, and nearly 100 lines of code, Id
prefer it to have it in a seperate header so our sources files is not so
cluttered with a bunch of structs and defines..   In our internal
sources, we do need this broken out into a seperate header due to its
inclusion in our IOCTLS sources.  
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 4/6] mpt fusion: Creation of mptsas.h header file

2007-08-14 Thread Matthew Wilcox
On Tue, Aug 14, 2007 at 04:15:38PM +0530, Prakash, Sathya wrote:
> The data structure definitions from mptsas.c are moved to a new header file 
> mptsas.h

Why?  Are they used outside mptsas.c in some future patch?

-- 
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


RE: [PATCH 4/6] mpt fusion: Creation of mptsas.h header file

2007-08-14 Thread Moore, Eric
On Tuesday, August 14, 2007 4:46 AM,  Prakash, Sathya wrote:

> The data structure definitions from mptsas.c are moved to a 
> new header file mptsas.h
> 
> signed-off-by: Sathya Prakash <[EMAIL PROTECTED]>
> ---

ACK
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html