Re: [PATCH RESEND] bfa: deinline __bfa_trc() and __bfa_trc32()
> "Denys" == Denys Vlasenko writes: Denys> __bfa_trc() compiles to 115 bytes of machine code. With this Denys> .config: http://busybox.net/~vda/kernel_config there are 1494 Denys> calls of __bfa_trc(). Applied to 4.6/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH RESEND] bfa: deinline __bfa_trc() and __bfa_trc32()
You could remove the __bfa_trc32() routine Thanks, Acked-by: Anil Gurumurthy -Original Message- From: Martin K. Petersen [mailto:martin.peter...@oracle.com] Sent: 10 February 2016 22:59 To: Denys Vlasenko Cc: James Bottomley ; Fabian Frederick ; Anil Gurumurthy ; Christoph Hellwig ; Guenter Roeck ; Ben Hutchings ; linux-kernel ; linux-scsi Subject: Re: [PATCH RESEND] bfa: deinline __bfa_trc() and __bfa_trc32() >>>>> "Denys" == Denys Vlasenko writes: Denys> __bfa_trc32() is very similar, so it is uninlined too. However, Denys> it appears to be unused, therefore this patch ifdefs it out. Why don't we just drop it? -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH RESEND] bfa: deinline __bfa_trc() and __bfa_trc32()
> "Denys" == Denys Vlasenko writes: Denys> __bfa_trc32() is very similar, so it is uninlined too. However, Denys> it appears to be unused, therefore this patch ifdefs it out. Why don't we just drop it? -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
