RE: [PATCH net-next] qed: Utilize FW 8.20.0.0

2017-05-18 Thread Mintz, Yuval 
> >> This pushes qed [and as result, all qed* drivers] into using 8.20.0.0
> >> firmware. The changes are mostly contained in qed with minor changes
> >> to qedi due to some HSI changes.
> >>
> >> Content-wise, the firmware contains fixes to various issues exposed
> >> since the release of the previous firmware, including:
> >>  - Corrects iSCSI fast retransmit when data digest is enabled.
> >>  - Stop draining packets when receiving several consecutive PFCs.
> >>  - Prevent possible assertion when consecutively opening/closing
> >>many connections.
> >>  - Prevent possible assertion due to too long BDQ fetch time.
> >>
> >> In addition, the new firmware would allow us to later add iWARP
> >> support in qed and qedr.
> >>
> >> Signed-off-by: Chad Dupuis 
> >> Signed-off-by: Ram Amrani 
> >> Signed-off-by: Tomer Tayar 
> >> Signed-off-by: Manish Rangankar 
> >> Signed-off-by: Yuval Mintz 
> >
> > Applied.
> 
> Actually I had to revert.  Please look at the compiler output before
> submitting changes:
> 
> drivers/net/ethernet/qlogic/qed/qed_debug.c: In function ‘qed_grc_dump’:
> drivers/net/ethernet/qlogic/qed/qed_debug.c:2425:6: warning: ‘addr’ may
> be used uninitialized in this function [-Wmaybe-uninitialized]
>   u32 byte_addr = DWORDS_TO_BYTES(addr), offset = 0, i;
>   ^
> drivers/net/ethernet/qlogic/qed/qed_debug.c:3534:7: note: ‘addr’ was
> declared here
>u32 addr, size = RSS_REG_RSS_RAM_DATA_SIZE;
>^
> 
> 'addr' is never, ever, assigned a value, yet it is passed into a function as 
> an
> argument.

Sorry about that. Will send v2 [hopefully] later today.

Re: [PATCH net-next] qed: Utilize FW 8.20.0.0

2017-05-18 Thread David Miller 
From: David Miller 
Date: Thu, 18 May 2017 10:34:28 -0400 (EDT)

> From: Yuval Mintz 
> Date: Wed, 17 May 2017 22:38:40 +0300
> 
>> This pushes qed [and as result, all qed* drivers] into using 8.20.0.0
>> firmware. The changes are mostly contained in qed with minor changes
>> to qedi due to some HSI changes.
>> 
>> Content-wise, the firmware contains fixes to various issues exposed
>> since the release of the previous firmware, including:
>>  - Corrects iSCSI fast retransmit when data digest is enabled.
>>  - Stop draining packets when receiving several consecutive PFCs.
>>  - Prevent possible assertion when consecutively opening/closing
>>many connections.
>>  - Prevent possible assertion due to too long BDQ fetch time.
>> 
>> In addition, the new firmware would allow us to later add iWARP support
>> in qed and qedr.
>> 
>> Signed-off-by: Chad Dupuis 
>> Signed-off-by: Ram Amrani 
>> Signed-off-by: Tomer Tayar 
>> Signed-off-by: Manish Rangankar 
>> Signed-off-by: Yuval Mintz 
> 
> Applied.

Actually I had to revert.  Please look at the compiler output before
submitting changes:

drivers/net/ethernet/qlogic/qed/qed_debug.c: In function ‘qed_grc_dump’:
drivers/net/ethernet/qlogic/qed/qed_debug.c:2425:6: warning: ‘addr’ may be used 
uninitialized in this function [-Wmaybe-uninitialized]
  u32 byte_addr = DWORDS_TO_BYTES(addr), offset = 0, i;
  ^
drivers/net/ethernet/qlogic/qed/qed_debug.c:3534:7: note: ‘addr’ was declared 
here
   u32 addr, size = RSS_REG_RSS_RAM_DATA_SIZE;
   ^

'addr' is never, ever, assigned a value, yet it is passed into a function as an
argument.

Re: [PATCH net-next] qed: Utilize FW 8.20.0.0

2017-05-18 Thread David Miller 
From: Yuval Mintz 
Date: Wed, 17 May 2017 22:38:40 +0300

> This pushes qed [and as result, all qed* drivers] into using 8.20.0.0
> firmware. The changes are mostly contained in qed with minor changes
> to qedi due to some HSI changes.
> 
> Content-wise, the firmware contains fixes to various issues exposed
> since the release of the previous firmware, including:
>  - Corrects iSCSI fast retransmit when data digest is enabled.
>  - Stop draining packets when receiving several consecutive PFCs.
>  - Prevent possible assertion when consecutively opening/closing
>many connections.
>  - Prevent possible assertion due to too long BDQ fetch time.
> 
> In addition, the new firmware would allow us to later add iWARP support
> in qed and qedr.
> 
> Signed-off-by: Chad Dupuis 
> Signed-off-by: Ram Amrani 
> Signed-off-by: Tomer Tayar 
> Signed-off-by: Manish Rangankar 
> Signed-off-by: Yuval Mintz 

Applied.