Re: [PATCH] bfa: do not dereference port before it is null checked

2016-08-31 Thread Johannes Thumshirn
On Tue, Aug 30, 2016 at 05:36:16PM +0100, Colin King wrote:
> From: Colin Ian King 
> 
> port is deferenced before it is null sanity checked, hence
> we potentially have a null pointer dereference bug. Instead,
> initialise trl_enabled from port->fcs->bfa after we are sure
> port is not null.
> 
> Signed-off-by: Colin Ian King 
> ---

Reviewed-by: Johannes Thumshirn 

-- 
Johannes Thumshirn  Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] bfa: do not dereference port before it is null checked

2016-09-02 Thread Martin K. Petersen
> "Colin" == Colin King  writes:

Colin> port is deferenced before it is null sanity checked, hence we
Colin> potentially have a null pointer dereference bug. Instead,
Colin> initialise trl_enabled from port->fcs->bfa after we are sure port
Colin> is not null.

Applied to 4.9/scsi-queue.

-- 
Martin K. Petersen  Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html