Re: [PATCH] scsi: cxlflash: fix assignment of the backend operations

2018-07-10 Thread Martin K. Petersen


Cédric,

> commit cd43c221bb5e ("scsi: cxlflash: Isolate external module
> dependencies") introduced the use of ifdefs to avoid compilation
> errors when one of the possible backend driver, CXL or OCXL, is not
> compiled.
>
> Unfortunately, the wrong defines are used and the backend ops are
> never assigned, leading to a kernel crash in any case when the
> cxlflash module is loaded.

Applied to 4.18/scsi-fixes, thank you!

-- 
Martin K. Petersen  Oracle Linux Engineering


Re: [PATCH] scsi: cxlflash: fix assignment of the backend operations

2018-07-05 Thread Matthew R. Ochs
On Thu, Jul 05, 2018 at 07:26:23AM +0200, Cédric Le Goater wrote:
> commit cd43c221bb5e ("scsi: cxlflash: Isolate external module
> dependencies") introduced the use of ifdefs to avoid compilation
> errors when one of the possible backend driver, CXL or OCXL, is not
> compiled.
> 
> Unfortunately, the wrong defines are used and the backend ops are
> never assigned, leading to a kernel crash in any case when the
> cxlflash module is loaded.
> 
> Signed-off-by: Cédric Le Goater 

Odd, I know Uma tested this but perhaps not with a clean build...

Thanks for catching this Cedric!

Acked-by: Matthew R. Ochs