Re: [PATCH] scsi: ufs-qcom: Fix module autoload

[Martin K. Petersen]

> "Javier" == Javier Martinez Canillas  writes:

Javier> If the driver is built as a module, autoload won't work because
Javier> the module alias information is not filled. So user-space can't
Javier> match the registered device with the corresponding module.

Javier> Export the module alias information using the
Javier> MODULE_DEVICE_TABLE() macro.

Applied to 4.11/scsi-queue.

-- 
Martin K. Petersen  Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] scsi: ufs-qcom: Fix module autoload

[Subhash Jadavani]

On 2017-01-02 06:04, Javier Martinez Canillas wrote:
If the driver is built as a module, autoload won't work because the 
module
alias information is not filled. So user-space can't match the 
registered

device with the corresponding module.

Export the module alias information using the MODULE_DEVICE_TABLE() 
macro.


Before this patch:

$ modinfo drivers/scsi/ufs/ufs-qcom.ko | grep alias
$

After this patch:

$ modinfo drivers/scsi/ufs/ufs-qcom.ko | grep alias
alias:  of:N*T*Cqcom,ufshcC*
alias:  of:N*T*Cqcom,ufshc

Signed-off-by: Javier Martinez Canillas 
---

 drivers/scsi/ufs/ufs-qcom.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c
index abe617372661..5ff8a6bf6fd3 100644
--- a/drivers/scsi/ufs/ufs-qcom.c
+++ b/drivers/scsi/ufs/ufs-qcom.c
@@ -1692,6 +1692,7 @@ static const struct of_device_id 
ufs_qcom_of_match[] = {

{ .compatible = "qcom,ufshc"},
{},
 };
+MODULE_DEVICE_TABLE(of, ufs_qcom_of_match);

 static const struct dev_pm_ops ufs_qcom_pm_ops = {
.suspend= ufshcd_pltfrm_suspend,


Looks good to me.
Reviewed-by: Subhash Jadavani 

--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html