Re: [PATCH] unexport sg v3 helper functions

2007-07-24 Thread Jens Axboe
On Mon, Jul 23 2007, Douglas Gilbert wrote:
 Jens Axboe wrote:
  On Sun, Jul 22 2007, FUJITA Tomonori wrote:
  blk_fill_sghdr_rq, blk_unmap_sghdr_rq, and blk_complete_sghdr_rq were
  exported for bsg, however bsg was changed to support only sg v4.
 
  Signed-off-by: FUJITA Tomonori [EMAIL PROTECTED]
  
  Acked-by: Jens Axboe [EMAIL PROTECTED]
 
 Why?

The reasoning is right there, a few lines up - bsg doesn't support sg v3
commands.

-- 
Jens Axboe

-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] unexport sg v3 helper functions

2007-07-24 Thread Douglas Gilbert
Jens Axboe wrote:
 On Mon, Jul 23 2007, Douglas Gilbert wrote:
 Jens Axboe wrote:
 On Sun, Jul 22 2007, FUJITA Tomonori wrote:
 blk_fill_sghdr_rq, blk_unmap_sghdr_rq, and blk_complete_sghdr_rq were
 exported for bsg, however bsg was changed to support only sg v4.

 Signed-off-by: FUJITA Tomonori [EMAIL PROTECTED]
 Acked-by: Jens Axboe [EMAIL PROTECTED]
 Why?
 
 The reasoning is right there, a few lines up - bsg doesn't support sg v3
 commands.

I can read.

Why doesn't bsg support sg v3 commands?
-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] unexport sg v3 helper functions

2007-07-24 Thread Jens Axboe
On Tue, Jul 24 2007, Douglas Gilbert wrote:
 Jens Axboe wrote:
  On Mon, Jul 23 2007, Douglas Gilbert wrote:
  Jens Axboe wrote:
  On Sun, Jul 22 2007, FUJITA Tomonori wrote:
  blk_fill_sghdr_rq, blk_unmap_sghdr_rq, and blk_complete_sghdr_rq were
  exported for bsg, however bsg was changed to support only sg v4.
 
  Signed-off-by: FUJITA Tomonori [EMAIL PROTECTED]
  Acked-by: Jens Axboe [EMAIL PROTECTED]
  Why?
  
  The reasoning is right there, a few lines up - bsg doesn't support sg v3
  commands.
 
 I can read.

Then write better questions Why? isn't very useful.

 Why doesn't bsg support sg v3 commands?

You should know, the discussion on that happened at the storage summit
and on linux-scsi. It was decided to drop sg v3 support from bsg, and
only focus on making bsg the driver for sg v4 commands.

As you know, we already have dual paths for sg v3. For sg v4 we can get
rid of that pain, and just have a single driver for handling that.

-- 
Jens Axboe

-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] unexport sg v3 helper functions

2007-07-23 Thread Jens Axboe
On Sun, Jul 22 2007, FUJITA Tomonori wrote:
 blk_fill_sghdr_rq, blk_unmap_sghdr_rq, and blk_complete_sghdr_rq were
 exported for bsg, however bsg was changed to support only sg v4.
 
 Signed-off-by: FUJITA Tomonori [EMAIL PROTECTED]

Acked-by: Jens Axboe [EMAIL PROTECTED]

-- 
Jens Axboe

-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] unexport sg v3 helper functions

2007-07-23 Thread Douglas Gilbert
Jens Axboe wrote:
 On Sun, Jul 22 2007, FUJITA Tomonori wrote:
 blk_fill_sghdr_rq, blk_unmap_sghdr_rq, and blk_complete_sghdr_rq were
 exported for bsg, however bsg was changed to support only sg v4.

 Signed-off-by: FUJITA Tomonori [EMAIL PROTECTED]
 
 Acked-by: Jens Axboe [EMAIL PROTECTED]

Why?


-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html