Re: [PATCH 0/3] debloat aic7xxx and aic79xx drivers
Hi Andrew, James, On Monday 15 October 2007 14:53, Gabriel C wrote: > >> Compile tested and applies cleanly to 2.6.23. > >> I don't have this hardware anymore and cannot run test these patches. > > > > I can test these patches on an aic7892 controller later on today if you > > want. > > Works fine for me tested on : > > 03:0e.0 SCSI storage controller [0100]: Adaptec AIC-7892P U160/m [9005:008f] > (rev 02) I hope this is enough for these patches to be accepted. If it is not, please let me know what do I need to do more. -- vda - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/3] debloat aic7xxx and aic79xx drivers
Denys Vlasenko wrote: > On Sunday 14 October 2007 18:47, Gabriel C wrote: >>> Compile tested and applies cleanly to 2.6.23. >>> I don't have this hardware anymore and cannot run test these patches. >> I can test these patches on an aic7892 controller later on today if you want. > > I'd appreciate that. > > Do you, by any chance, use aic94xx driver too (drivers/scsi/aic94xx/*)? > After i'm done with aic7xxx, I may attack this one. Sorry I don't have any box uses this one , but I'll ask some friends maybe someone has :) > >> BTW while you seems to care about this driver could you have a look at : >> >> http://bugzilla.kernel.org/show_bug.cgi?id=3062 ?!? > > I am a desktop Linux user, so far I don't use suspend at all. Sorry. Ok , no problem maybe one 'day' the SCSI folks cares ( where the 'day' may be never ), I dunno :( > -- > vda > Gabriel - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/3] debloat aic7xxx and aic79xx drivers
>> Compile tested and applies cleanly to 2.6.23. >> I don't have this hardware anymore and cannot run test these patches. > > I can test these patches on an aic7892 controller later on today if you want. Works fine for me tested on : 03:0e.0 SCSI storage controller [0100]: Adaptec AIC-7892P U160/m [9005:008f] (rev 02) Gabriel - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/3] debloat aic7xxx and aic79xx drivers
On Sunday 14 October 2007 18:47, Gabriel C wrote: > > Compile tested and applies cleanly to 2.6.23. > > I don't have this hardware anymore and cannot run test these patches. > > I can test these patches on an aic7892 controller later on today if you want. I'd appreciate that. Do you, by any chance, use aic94xx driver too (drivers/scsi/aic94xx/*)? After i'm done with aic7xxx, I may attack this one. > BTW while you seems to care about this driver could you have a look at : > > http://bugzilla.kernel.org/show_bug.cgi?id=3062 ?!? I am a desktop Linux user, so far I don't use suspend at all. Sorry. -- vda - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/3] debloat aic7xxx and aic79xx drivers
Denys Vlasenko wrote: > Hi, Hi, > Compile tested and applies cleanly to 2.6.23. > I don't have this hardware anymore and cannot run test these patches. I can test these patches on an aic7892 controller later on today if you want. BTW while you seems to care about this driver could you have a look at : http://bugzilla.kernel.org/show_bug.cgi?id=3062 ?!? Regards, Gabriel C - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/3] debloat aic7xxx and aic79xx drivers
On Friday 31 August 2007 17:27, [EMAIL PROTECTED] wrote: > On Fri, 31 Aug 2007 16:13:59 BST, Denys Vlasenko said: > > > >textdata bss dec hex filename > > 261433 500181172 312623 4c52f > > linux-2.6.23-rc1.org.t/drivers/scsi/aic7xxx/built-in.o > > 199654 500181172 250844 3d3dc > > linux-2.6.23-rc1.aic.t/drivers/scsi/aic7xxx/built-in.o > > 184014 213141172 206500 326a4 > > linux-2.6.23-rc1.aic1.t/drivers/scsi/aic7xxx/built-in.o > > 20237828501172 206400 32640 > > linux-2.6.23-rc1.aic2.t/drivers/scsi/aic7xxx/built-in.o > > > > 1-debloat.patchdeinlines a lot of functions > > 2-addstatic.patch adds statics, #ifdefs out huge amount of unused code, > > adds consts > > 3-addconst.patch adds more consts > > Yowza. Looking at aic1->aic2, it looks like 20K became 'const', and only > 3K *wasn't* 'const'? Exactly. There are firmware images/patches and a lot of structures with char* members pointing to text/messages. Btw, aic94xx driver needs the same treatment. -- vda - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/3] debloat aic7xxx and aic79xx drivers
On Fri, 31 Aug 2007 16:13:59 BST, Denys Vlasenko said: > >textdata bss dec hex filename > 261433 500181172 312623 4c52f > linux-2.6.23-rc1.org.t/drivers/scsi/aic7xxx/built-in.o > 199654 500181172 250844 3d3dc > linux-2.6.23-rc1.aic.t/drivers/scsi/aic7xxx/built-in.o > 184014 213141172 206500 326a4 > linux-2.6.23-rc1.aic1.t/drivers/scsi/aic7xxx/built-in.o > 20237828501172 206400 32640 > linux-2.6.23-rc1.aic2.t/drivers/scsi/aic7xxx/built-in.o > > 1-debloat.patchdeinlines a lot of functions > 2-addstatic.patch adds statics, #ifdefs out huge amount of unused code, adds > consts > 3-addconst.patch adds more consts Yowza. Looking at aic1->aic2, it looks like 20K became 'const', and only 3K *wasn't* 'const'? pgpAnWeUyBl9V.pgp Description: PGP signature
