Re: [PATCH 19/21] advansys: Remove a couple of uses of bus_to_virt
On Tue, Oct 02, 2007 at 10:13:07PM -0400, Jeff Garzik wrote: check dma_map_single for error It's on the todo list. Since so many other drivers don't check dma_map_single for error, I feel comfortable with leaving it for later. -- Intel are signing my paycheques ... these opinions are still mine Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step. - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 19/21] advansys: Remove a couple of uses of bus_to_virt
Matthew Wilcox wrote: On Tue, Oct 02, 2007 at 10:13:07PM -0400, Jeff Garzik wrote: check dma_map_single for error It's on the todo list. Since so many other drivers don't check dma_map_single for error, I feel comfortable with leaving it for later. The issue became more urgent with x86-64 and its smaller IOMMU area. Jeff - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 19/21] advansys: Remove a couple of uses of bus_to_virt
On Wed, Oct 03, 2007 at 10:28:31AM -0400, Jeff Garzik wrote: Matthew Wilcox wrote: On Tue, Oct 02, 2007 at 10:13:07PM -0400, Jeff Garzik wrote: check dma_map_single for error It's on the todo list. Since so many other drivers don't check dma_map_single for error, I feel comfortable with leaving it for later. The issue became more urgent with x86-64 and its smaller IOMMU area. I'll bump up the priority of fixing it then. I don't think this should block the series from going in (since it wasn't even compilable on x86-64 before this point). -- Intel are signing my paycheques ... these opinions are still mine Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step. - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 19/21] advansys: Remove a couple of uses of bus_to_virt
Matthew Wilcox wrote: On Wed, Oct 03, 2007 at 10:28:31AM -0400, Jeff Garzik wrote: Matthew Wilcox wrote: On Tue, Oct 02, 2007 at 10:13:07PM -0400, Jeff Garzik wrote: check dma_map_single for error It's on the todo list. Since so many other drivers don't check dma_map_single for error, I feel comfortable with leaving it for later. The issue became more urgent with x86-64 and its smaller IOMMU area. I'll bump up the priority of fixing it then. I don't think this should block the series from going in (since it wasn't even compilable on x86-64 before this point). Oh, certainly agreed... I never used the word NAK. Jeff - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 19/21] advansys: Remove a couple of uses of bus_to_virt
Matthew Wilcox wrote: Replace ASC_VADDR_TO_U32 and ASC_U32_TO_VADDR with an auto-expanding array that maps pointers to 32-bit IDs and back. One of the uses of ASC_VADDR_TO_U32 was in error; it should have been using ADV_VADDR_TO_U32. Also replace the use of virt_to_bus when setting the sense_address with a call to dma_map_single() followed by dma_cache_sync. This part cribbed from the 53c700 driver. Signed-off-by: Matthew Wilcox [EMAIL PROTECTED] check dma_map_single for error - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
