Re: [PATCH 4/4] sd: Optionally attach to ZBC devices

2014-07-30 Thread Christoph Hellwig
On Wed, Jul 30, 2014 at 08:41:55AM +0200, Hannes Reinecke wrote:
> Yes, eventually. But can't we defer that to a next patchset?
> I'd really like to have this one in, as it makes dealing with ZAC devices
> _so much_ easier ...

I'm happy to put the sd patch in if I can get another review for it.

But even if you want me to carry the libata bits I will need a clear
ACK from Tejun.  And I really think it would belong into the libata
tree.

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 4/4] sd: Optionally attach to ZBC devices

2014-07-29 Thread Hannes Reinecke

On 07/29/2014 07:14 PM, Christoph Hellwig wrote:

On Tue, Jul 29, 2014 at 04:45:17PM +0200, Hannes Reinecke wrote:

ZBC drives are close to disk devices, so sd.c is well
suited as a testbed for ZBC devices.
This patch introduces a module option 'attach_zbc' to
sd which will make the sd driver accept ZBC
devices as normal disk drives.

Signed-off-by: Hannes Reinecke 


Looks reasonable to me.

I'd also really like a sysfs file that tells us if we're dealing
with a host aware device, as those report as TYPE_SBC.


Yes, eventually. But can't we defer that to a next patchset?
I'd really like to have this one in, as it makes dealing with ZAC 
devices _so much_ easier ...


Cheers,

Hannes
--
Dr. Hannes Reinecke   zSeries & Storage
h...@suse.de  +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 4/4] sd: Optionally attach to ZBC devices

2014-07-29 Thread Christoph Hellwig
On Tue, Jul 29, 2014 at 04:45:17PM +0200, Hannes Reinecke wrote:
> ZBC drives are close to disk devices, so sd.c is well
> suited as a testbed for ZBC devices.
> This patch introduces a module option 'attach_zbc' to
> sd which will make the sd driver accept ZBC
> devices as normal disk drives.
> 
> Signed-off-by: Hannes Reinecke 

Looks reasonable to me.

I'd also really like a sysfs file that tells us if we're dealing
with a host aware device, as those report as TYPE_SBC. 

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html