Re: [PATCH 5/9] srpt: use the new CQ API
On Tue, Nov 17, 2015 at 11:38:48AM -0800, Bart Van Assche wrote: > On 11/13/2015 05:46 AM, Christoph Hellwig wrote: >> [ ... ] > > This patch contains two logical changes: > - Conversion to the new CQ API. > - Removal of the ib_srpt_compl thread. > > Had it been considered to implement these changes as two separate patches ? It's intentional. I want the new style completions to happen from a controlled environment, so I don't want to allow calling them from random context. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 5/9] srpt: use the new CQ API
On 11/13/2015 05:46 AM, Christoph Hellwig wrote: > [ ... ] The previous patch and this patch look like great work to me. However, this patch not only reworks the SRP target driver but also prevents users to move the SRP completion thread to another CPU core than the CPU core that processes the completion interrupts (with the help of e.g. the taskset command). Hence my request to make that CPU core configurable in the second patch of this patch series. Bart. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 5/9] srpt: use the new CQ API
On 11/13/2015 05:46 AM, Christoph Hellwig wrote: [ ... ] This patch contains two logical changes: - Conversion to the new CQ API. - Removal of the ib_srpt_compl thread. Had it been considered to implement these changes as two separate patches ? Thanks, Bart. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
