Re: [SCSI] mpt2sas T10 DIF fixes
Pasi == Pasi Kärkkäinen pa...@iki.fi writes: 2 of the patches are absolutely trivial and should just be applied. However, LSI objects to patch #3 which tweaks an incorrect NVDATA flag from within the driver. Instead LSI has promised to revert to the original behavior in their firmware/NVDATA updates. Eric, can you give us an update? There was another bug report on linux-scsi just a couple of weeks ago. Pasi Hopefully these T10 patches can go in during the 3.7 merge window! The 2 trivial patches are queued for 3.7, yes. LSI are still working the bad NVDATA default issue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [SCSI] mpt2sas T10 DIF fixes
On Fri, Aug 17, 2012 at 12:00:55PM -0400, Martin K. Petersen wrote: Ankit == Ankit Jain jan...@suse.com writes: Ankit Will these patches be merged? Or have they been superseded by Ankit some other patchset? Sorry, I've been out on vacation. 2 of the patches are absolutely trivial and should just be applied. However, LSI objects to patch #3 which tweaks an incorrect NVDATA flag from within the driver. Instead LSI has promised to revert to the original behavior in their firmware/NVDATA updates. Eric, can you give us an update? There was another bug report on linux-scsi just a couple of weeks ago. Hello, Hopefully these T10 patches can go in during the 3.7 merge window! Thanks, -- Pasi -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [SCSI] mpt2sas T10 DIF fixes
dj == Jiang, Dave dave.ji...@intel.com writes: Yes. The only thing that doesn't work is RAID5/6. dj Just curious, has any work been done on this? Wondering what the dj roadblocks are to get this support in Nobody has done the work, that's all. And it's not entirely trivial. The 8 bytes of metadata for a parity sector is not valid T10 protection information, for instance. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [SCSI] mpt2sas T10 DIF fixes
On Mon, Aug 20, 2012 at 08:43:49PM -0400, Martin K. Petersen wrote: Pasi == Pasi Kärkkäinen pa...@iki.fi writes: Pasi .. and I probably need to sg_format the backing devices to enable Pasi PI Yes. Unless the drive is already formatted with PI. The latter is becoming increasingly common as a PI-drive will work just fine in a legacy setup. Many current drives provide the same LBA count regardless of whether PI is enabled or not. So there isn't much point in not enabling it. Makes sense, thanks! -- Pasi -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [SCSI] mpt2sas T10 DIF fixes
-Original Message-
From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-
ow...@vger.kernel.org] On Behalf Of Martin K. Petersen
Sent: Monday, August 20, 2012 5:40 PM
To: Pasi Kärkkäinen
Cc: Martin K. Petersen; Ankit Jain; linux-scsi@vger.kernel.org;
james.bottom...@hansenpartnership.com; eric.mo...@lsi.com
Subject: Re: [SCSI] mpt2sas T10 DIF fixes
Pasi == Pasi Kärkkäinen pa...@iki.fi writes:
Pasi Btw do you know the current status of T10 PI support in md/dm
Pasi raid? If I understood correctly there's some support for
Pasi raid0/raid1 implemented..
Yes. The only thing that doesn't work is RAID5/6.
Just curious, has any work been done on this? Wondering what the roadblocks are
to get this support in
N�r��yb�X��ǧv�^�){.n�+{{ay� ʇڙ�,j��f���h���z� �w���
���j:+v���w�j�mzZ+�ݢj��!�i
Re: [SCSI] mpt2sas T10 DIF fixes
On Sun, Aug 19, 2012 at 12:38:43PM -0400, Martin K. Petersen wrote:
Pasi == Pasi Kärkkäinen pa...@iki.fi writes:
Pasi So physically the disk is using 520 bytes/sector (and needs to
Pasi support that), but logically the HBA presents 512 bytes/sector +
Pasi PI.. is that correct?
Yep. The beauty of PI is that we can store the extra stuff without
having to deal with weird block sizes.
Pasi I guess what I'm asking is: Can I use sg_format to enable
Pasi checksums/protection on any disk that physically supports 520
Pasi bytes/sector, or does the disk need to have special T10 data
Pasi protection support aswell?
The disk needs to support T10 PI (PROTECT=1 in the Standard Inquiry VPD
page). We don't support driving the HBA in PI mode with a non-PI target.
Btw do you know the current status of T10 PI support in md/dm raid?
If I understood correctly there's some support for raid0/raid1 implemented..
Are there any docs how to enable/disable/configure T10 PI for md/dm raid?
Perhaps the bdev/integrite/{write_enable|read_verify} work directly for the
md/dm device?
Thanks a lot!
-- Pasi
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [SCSI] mpt2sas T10 DIF fixes
On Mon, Aug 20, 2012 at 01:48:19PM +0300, Pasi Kärkkäinen wrote:
On Sun, Aug 19, 2012 at 12:38:43PM -0400, Martin K. Petersen wrote:
Pasi == Pasi Kärkkäinen pa...@iki.fi writes:
Pasi So physically the disk is using 520 bytes/sector (and needs to
Pasi support that), but logically the HBA presents 512 bytes/sector +
Pasi PI.. is that correct?
Yep. The beauty of PI is that we can store the extra stuff without
having to deal with weird block sizes.
Pasi I guess what I'm asking is: Can I use sg_format to enable
Pasi checksums/protection on any disk that physically supports 520
Pasi bytes/sector, or does the disk need to have special T10 data
Pasi protection support aswell?
The disk needs to support T10 PI (PROTECT=1 in the Standard Inquiry VPD
page). We don't support driving the HBA in PI mode with a non-PI target.
Btw do you know the current status of T10 PI support in md/dm raid?
If I understood correctly there's some support for raid0/raid1 implemented..
Are there any docs how to enable/disable/configure T10 PI for md/dm raid?
Perhaps the bdev/integrite/{write_enable|read_verify} work directly for the
md/dm device?
.. and I probably need to sg_format the backing devices to enable PI before
enabling PI for the md/dm device?
-- Pasi
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [SCSI] mpt2sas T10 DIF fixes
Pasi == Pasi Kärkkäinen pa...@iki.fi writes:
Pasi Btw do you know the current status of T10 PI support in md/dm
Pasi raid? If I understood correctly there's some support for
Pasi raid0/raid1 implemented..
Yes. The only thing that doesn't work is RAID5/6.
Pasi Are there any docs how to enable/disable/configure T10 PI for
Pasi md/dm raid? Perhaps the
Pasi bdev/integrite/{write_enable|read_verify} work directly for the
Pasi md/dm device?
You don't have to configure anything. If all component devices are
capable the md/dm device will register a suitable integrity profile.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [SCSI] mpt2sas T10 DIF fixes
Pasi == Pasi Kärkkäinen pa...@iki.fi writes: Pasi .. and I probably need to sg_format the backing devices to enable Pasi PI Yes. Unless the drive is already formatted with PI. The latter is becoming increasingly common as a PI-drive will work just fine in a legacy setup. Many current drives provide the same LBA count regardless of whether PI is enabled or not. So there isn't much point in not enabling it. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [SCSI] mpt2sas T10 DIF fixes
On Fri, Aug 17, 2012 at 12:00:55PM -0400, Martin K. Petersen wrote: Ankit == Ankit Jain jan...@suse.com writes: Ankit Will these patches be merged? Or have they been superseded by Ankit some other patchset? Sorry, I've been out on vacation. 2 of the patches are absolutely trivial and should just be applied. However, LSI objects to patch #3 which tweaks an incorrect NVDATA flag from within the driver. Instead LSI has promised to revert to the original behavior in their firmware/NVDATA updates. Eric, can you give us an update? There was another bug report on linux-scsi just a couple of weeks ago. Btw do you know which LSI mpt2sas HBAs support T10 DIF stuff? (using 520 or 528 bytes/sector drives with checkums). LSI SAS2008 based? SAS2308 based? Thanks, -- Pasi -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [SCSI] mpt2sas T10 DIF fixes
Pasi == Pasi Kärkkäinen pa...@iki.fi writes: Pasi Btw do you know which LSI mpt2sas HBAs support T10 DIF stuff? Pasi (using 520 or 528 bytes/sector drives with checkums). Pasi LSI SAS2008 based? SAS2308 based? SAS2008 and beyond. 512-byte logical blocks + 8 bytes of PI. Linux does not support logical block sizes that are not powers of two. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [SCSI] mpt2sas T10 DIF fixes
On Sun, Aug 19, 2012 at 11:18:57AM -0400, Martin K. Petersen wrote: Pasi == Pasi Kärkkäinen pa...@iki.fi writes: Pasi Btw do you know which LSI mpt2sas HBAs support T10 DIF stuff? Pasi (using 520 or 528 bytes/sector drives with checkums). Pasi LSI SAS2008 based? SAS2308 based? SAS2008 and beyond. Ok, good. 512-byte logical blocks + 8 bytes of PI. So physically the disk is using 520 bytes/sector (and needs to support that), but logically the HBA presents 512 bytes/sector + PI.. is that correct? I guess what I'm asking is: Can I use sg_format to enable checksums/protection on any disk that physically supports 520 bytes/sector, or does the disk need to have special T10 data protection support aswell? Linux does not support logical block sizes that are not powers of two. Yep. Thanks, -- Pasi -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [SCSI] mpt2sas T10 DIF fixes
Pasi == Pasi Kärkkäinen pa...@iki.fi writes: Pasi So physically the disk is using 520 bytes/sector (and needs to Pasi support that), but logically the HBA presents 512 bytes/sector + Pasi PI.. is that correct? Yep. The beauty of PI is that we can store the extra stuff without having to deal with weird block sizes. Pasi I guess what I'm asking is: Can I use sg_format to enable Pasi checksums/protection on any disk that physically supports 520 Pasi bytes/sector, or does the disk need to have special T10 data Pasi protection support aswell? The disk needs to support T10 PI (PROTECT=1 in the Standard Inquiry VPD page). We don't support driving the HBA in PI mode with a non-PI target. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [SCSI] mpt2sas T10 DIF fixes
On Sun, Aug 19, 2012 at 12:38:43PM -0400, Martin K. Petersen wrote: Pasi == Pasi Kärkkäinen pa...@iki.fi writes: Pasi So physically the disk is using 520 bytes/sector (and needs to Pasi support that), but logically the HBA presents 512 bytes/sector + Pasi PI.. is that correct? Yep. The beauty of PI is that we can store the extra stuff without having to deal with weird block sizes. Yep. Pasi I guess what I'm asking is: Can I use sg_format to enable Pasi checksums/protection on any disk that physically supports 520 Pasi bytes/sector, or does the disk need to have special T10 data Pasi protection support aswell? The disk needs to support T10 PI (PROTECT=1 in the Standard Inquiry VPD page). We don't support driving the HBA in PI mode with a non-PI target. Ok, good to know. Thanks! -- Pasi -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [SCSI] mpt2sas T10 DIF fixes
Ankit == Ankit Jain jan...@suse.com writes: Ankit Will these patches be merged? Or have they been superseded by Ankit some other patchset? Sorry, I've been out on vacation. 2 of the patches are absolutely trivial and should just be applied. However, LSI objects to patch #3 which tweaks an incorrect NVDATA flag from within the driver. Instead LSI has promised to revert to the original behavior in their firmware/NVDATA updates. Eric, can you give us an update? There was another bug report on linux-scsi just a couple of weeks ago. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [SCSI] mpt2sas T10 DIF fixes
On 02/21/2012 07:06 AM, Martin K. Petersen wrote: This is a repost of the T10 DIF patches against mpt2sas that I posted a while back: Will these patches be merged? Or have they been superseded by some other patchset? Thanks, -- Ankit Jain SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
