Re: cciss CSMI via sysfs for 2.6

[Greg KH]

On Fri, Feb 18, 2005 at 07:46:28PM +, Christoph Hellwig wrote:
   /*
  + * sysfs stuff
  + * this should be moved to it's own file, maybe cciss_sysfs.h
  + */
  +
  +static ssize_t cciss_firmver_show(struct device *dev, char *buf)
  +{
  +   ctlr_info_t *h = dev-driver_data;
  +return sprintf(buf,%c%c%c%c\n, h-firm_ver[0], h-firm_ver[1],
  +h-firm_ver[2], h-firm_ver[3]);
  +}
 
 I really wish we had a common firmver release attribut in the driver
 core, as mentioned in the fc transport class thread.  Greg?

For a device?  It seems a huge overkill to add this attribute for
_every_ device in the system, when only a small minority can actually
use it.  Just put it as a default scsi or transport class attribute
instead.

thanks,

greg k-h
-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: cciss CSMI via sysfs for 2.6

[James Bottomley]

On Fri, 2005-02-18 at 12:05 -0800, Greg KH wrote:
 For a device?  It seems a huge overkill to add this attribute for
 _every_ device in the system, when only a small minority can actually
 use it.  Just put it as a default scsi or transport class attribute
 instead.

Actually, we might be able to do this as a simple attribute container
rather than a transport class, but I agree, it's not a generic property
of every device.

James


-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html