self assignment bug in aix94xx

2013-10-24 Thread Dave Jones
2908d778(James Bottomley2006-08-29 09:22:51 -0500   515)
scb-ssp_task.retry_count = scb-ssp_task.retry_count;

Is this supposed to maybe be..

scb-ssp_task.retry_count = task-ssp_task.retry_count;

?

(This and a whole bunch of similar bugs found with Coverity.)

Dave

--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: self assignment bug in aix94xx

2013-10-24 Thread James Bottomley
On Thu, 2013-10-24 at 04:55 -0400, Dave Jones wrote:
 2908d778(James Bottomley2006-08-29 09:22:51 -0500   515)  
   scb-ssp_task.retry_count = scb-ssp_task.retry_count;
 
 Is this supposed to maybe be..
 
   scb-ssp_task.retry_count = task-ssp_task.retry_count;
 
 ?

Oh, boy, this was the master commit for aic94xx (so it's not me it was a
bunch of people working on the driver).  I'll see if I can analyse the
logic flow to find out what should have been going on, but it will take
a couple of weeks.

 (This and a whole bunch of similar bugs found with Coverity.)

May as well send them along and I'll look at them too.

James

   Dave
 
 --
 To unsubscribe from this list: send the line unsubscribe linux-scsi in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html



--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html