Re: [PATCH 15/20] dt-bindings: usb: meson-g12a-usb: Validate DWC2/DWC3 sub-nodes
On Wed, Oct 14, 2020 at 12:14 PM Serge Semin wrote: > > Amlogic G12A USB DT sub-nodes are supposed to be compatible with the > generic DWC USB2 and USB3 devices. Since now we've got DT schemas for > both of the later IP cores let's make sure that the Amlogic G12A USB > DT nodes are fully evaluated including the DWC sub-nodes. > > Signed-off-by: Serge Semin > Reviewed-by: Neil Armstrong Reviewed-by: Martin Blumenstingl ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [PATCH 14/20] dt-bindings: usb: meson-g12a-usb: Fix FL-adj property value
On Wed, Oct 14, 2020 at 12:14 PM Serge Semin wrote: > > An empty snps,quirk-frame-length-adjustment won't cause any change > performed by the driver. Moreover the DT schema validation will fail, > since it expects the property being assigned with some value. So set > fix the example by setting a valid FL-adj value in accordance with > Neil Armstrong comment. > > Link: > https://lore.kernel.org/linux-usb/20201010224121.12672-16-sergey.se...@baikalelectronics.ru/ > Signed-off-by: Serge Semin > Acked-by: Neil Armstrong Reviewed-by: Martin Blumenstingl ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [PATCH 15/20] dt-bindings: usb: meson-g12a-usb: Validate DWC2/DWC3 sub-nodes
On Wed, 14 Oct 2020 13:13:57 +0300, Serge Semin wrote: > Amlogic G12A USB DT sub-nodes are supposed to be compatible with the > generic DWC USB2 and USB3 devices. Since now we've got DT schemas for > both of the later IP cores let's make sure that the Amlogic G12A USB > DT nodes are fully evaluated including the DWC sub-nodes. > > Signed-off-by: Serge Semin > Reviewed-by: Neil Armstrong > > --- > > Changelog v2: > - Use "oneOf: [dwc2.yaml#, snps,dwc3.yaml#]" instead of the bulky "if: > properties: compatibe: ..." statement. > --- > .../devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Reviewed-by: Rob Herring ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [PATCH 17/20] dt-bindings: usb: qcom, dwc3: Validate DWC3 sub-node
On Wed, 14 Oct 2020 13:13:59 +0300, Serge Semin wrote:
> Qualcomm msm8996/sc7180/sdm845 DWC3 compatible DT nodes are supposed to
> have a DWC USB3 compatible sub-node to describe a fully functioning USB
> interface. Let's use the available DWC USB3 DT schema to validate the
> Qualcomm DWC3 sub-nodes.
>
> Note since the generic DWC USB3 DT node is supposed to be named as generic
> USB HCD ("^usb(@.*)?") one we have to accordingly fix the sub-nodes name
> regexp and fix the DT node example.
>
> Signed-off-by: Serge Semin
>
> ---
>
> Changelog v2:
> - Discard the "^dwc3@[0-9a-f]+$" nodes from being acceptable as sub-nodes.
> ---
> Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 9 +++--
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
Reviewed-by: Rob Herring
___
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [PATCH 16/20] dt-bindings: usb: keystone-dwc3: Validate DWC3 sub-node
On Wed, 14 Oct 2020 13:13:58 +0300, Serge Semin wrote: > TI Keystone DWC3 compatible DT node is supposed to have a DWC USB3 > compatible sub-node to describe a fully functioning USB interface. > Since DWC USB3 has now got a DT schema describing its DT node, let's make > sure the TI Keystone DWC3 sub-node passes validation against it. > > Signed-off-by: Serge Semin > > --- > > Changelog v2: > - Grammar fix: "s/it'/its" > --- > Documentation/devicetree/bindings/usb/ti,keystone-dwc3.yaml | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > Reviewed-by: Rob Herring ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [PATCH 14/20] dt-bindings: usb: meson-g12a-usb: Fix FL-adj property value
On Wed, 14 Oct 2020 13:13:56 +0300, Serge Semin wrote: > An empty snps,quirk-frame-length-adjustment won't cause any change > performed by the driver. Moreover the DT schema validation will fail, > since it expects the property being assigned with some value. So set > fix the example by setting a valid FL-adj value in accordance with > Neil Armstrong comment. > > Link: > https://lore.kernel.org/linux-usb/20201010224121.12672-16-sergey.se...@baikalelectronics.ru/ > Signed-off-by: Serge Semin > Acked-by: Neil Armstrong > > --- > > Note the same problem is in the DT source file > arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi . > --- > .../devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml| 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Rob Herring ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [PATCH 13/20] dt-bindings: usb: dwc3: Add Frame Length Adj restrictions
On Wed, 14 Oct 2020 13:13:55 +0300, Serge Semin wrote: > In accordance with the IP core databook the > snps,quirk-frame-length-adjustment property can be set within [0, 0x3F]. > Let's make sure the DT schema applies a correct restriction on the > property. > > Signed-off-by: Serge Semin > --- > Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 2 ++ > 1 file changed, 2 insertions(+) > Reviewed-by: Rob Herring ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [PATCH 12/20] dt-bindings: usb: dwc3: Add Tx De-emphasis restrictions
On Wed, 14 Oct 2020 13:13:54 +0300, Serge Semin wrote: > In accordance with the driver comments the PIPE3 de-emphasis can be tuned > to be either -6dB, -2.5dB or disabled. Let's add the de-emphasis > property restriction so the DT schema would make sure the controller DT > node is equipped with correct value. > > Signed-off-by: Serge Semin > > --- > > Changelog v2: > - Grammar fix: "s/tunned/tuned" > - Grammar fix: remove redundant "or" conjunction. > --- > Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 4 > 1 file changed, 4 insertions(+) > Reviewed-by: Rob Herring ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [PATCH 11/20] dt-bindings: usb: dwc3: Add synopsys,dwc3 compatible string
On Thu, Oct 15, 2020 at 12:35:54AM +0300, Serge Semin wrote: > On Wed, Oct 14, 2020 at 10:18:18PM +0200, Krzysztof Kozlowski wrote: > > On Wed, Oct 14, 2020 at 01:13:53PM +0300, Serge Semin wrote: > > > The DWC USB3 driver and some DTS files like Exynos 5250, Keystone k2e, etc > > > expects the DWC USB3 DT node to have the compatible string with the > > > "synopsys" vendor prefix. Let's add the corresponding compatible string to > > > the controller DT schema, but mark it as deprecated seeing the Synopsys, > > > Inc. is presented with just "snps" vendor prefix. > > > > > Instead of adding deprecated schema just correct the DTSes to use snps. > > The "synopsys" is not even in vendor prefixes. > > Yeah, it's not, but the driver and some dts'es use it this way. I am not sure > that the solution suggested by you is much better than mine. So let's hear the > Rob'es opinion out in this matter. @Rob, what do you think? I think we should fix the dts files given there's only 5. Rob ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [PATCH 10/20] dt-bindings: usb: dwc3: Add interrupt-names property support
On Wed, 14 Oct 2020 13:13:52 +0300, Serge Semin wrote: > The controller driver supports two types of DWC USB3 devices: with a > common interrupt lane and with individual interrupts for each mode. Add > support for both these cases to the DWC USB3 DT schema. > > Signed-off-by: Serge Semin > > --- > > Changelog v2: > - Grammar fix: "s/both of these cases support/support for both these cases" > - Drop quotes from around the string constants. > --- > Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 11 +++ > 1 file changed, 11 insertions(+) > Reviewed-by: Rob Herring ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [PATCH 08/20] dt-bindings: usb: renesas-xhci: Refer to the usb-xhci.yaml file
On Wed, 14 Oct 2020 13:13:50 +0300, Serge Semin wrote: > With minor peculiarities (like uploading some vendor-specific firmware) > these are just Generic xHCI controllers fully compatible with its > properties. Make sure the Renesas USB xHCI DT nodes are also validated > against the Generic xHCI DT schema. > > Signed-off-by: Serge Semin > --- > Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Reviewed-by: Rob Herring ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [PATCH 06/20] dt-bindings: usb: Convert xHCI bindings to DT schema
On Wed, 14 Oct 2020 13:13:48 +0300, Serge Semin wrote: > Currently the DT bindings of Generic xHCI Controllers are described by means > of the legacy text file. Since such format is deprecated in favor of the > DT schema, let's convert the Generic xHCI Controllers bindings file to the > corresponding yaml files. There will be two of them: a DT schema for the > xHCI controllers on a generic platform and a DT schema validating a generic > xHCI controllers properties. The later will be used to validate the xHCI > controllers, which aside from some vendor-specific features support the > basic xHCI functionality. > > An xHCI-compatible DT node shall support the standard USB HCD properties > and custom ones like: usb2-lpm-disable, usb3-lpm-capable, > quirk-broken-port-ped and imod-interval-ns. In addition if a generic xHCI > controller is being validated against the DT schema it is also supposed to > be equipped with mandatory compatible string, single registers range, > single interrupts source, and is supposed to optionally contain up to two > reference clocks for the controller core and CSRs. > > Signed-off-by: Serge Semin > > --- > > Changelog v2: > - Add explicit "additionalProperties: true" to the usb-xhci.yaml schema, > since additionalProperties/unevaluatedProperties are going to be mandary > for each binding. > --- > .../devicetree/bindings/usb/generic-xhci.yaml | 63 +++ > .../devicetree/bindings/usb/usb-xhci.txt | 41 > .../devicetree/bindings/usb/usb-xhci.yaml | 42 + > 3 files changed, 105 insertions(+), 41 deletions(-) > create mode 100644 Documentation/devicetree/bindings/usb/generic-xhci.yaml > delete mode 100644 Documentation/devicetree/bindings/usb/usb-xhci.txt > create mode 100644 Documentation/devicetree/bindings/usb/usb-xhci.yaml > Reviewed-by: Rob Herring ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [PATCH 07/20] dt-bindings: usb: xhci: Add Broadcom STB v2 compatible device
On Wed, 14 Oct 2020 13:13:49 +0300, Serge Semin wrote: > For some reason the "brcm,xhci-brcm-v2" compatible string has been missing > in the original bindings file. Add it to the Generic xHCI Controllers DT > schema since the controller driver expects it to be supported. > > Signed-off-by: Serge Semin > --- > Documentation/devicetree/bindings/usb/generic-xhci.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Reviewed-by: Rob Herring ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [PATCH 04/20] dt-bindings: usb: usb-hcd: Add "tpl-support" property
On Wed, 14 Oct 2020 13:13:46 +0300, Serge Semin wrote: > The host controller device might be designed to work for the particular > products or applications. In that case its DT node is supposed to be > equipped with the tpl-support property. > > Signed-off-by: Serge Semin > > --- > > Changelog v2: > - Grammar fix: "s/it'/its" > - Discard '|' from the property description, since we don't need to preserve > the text formatting. > --- > Documentation/devicetree/bindings/usb/usb-hcd.yaml | 6 ++ > 1 file changed, 6 insertions(+) > Reviewed-by: Rob Herring ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [PATCH 05/20] dt-bindings: usb: usb-hcd: Add generic "usb-phy" property
On Wed, 14 Oct 2020 13:13:47 +0300, Serge Semin wrote: > Even though the Generic PHY framework is the more preferable way of > setting the USB PHY up, there are still many dts-files and DT bindings > which rely on having the legacy "usb-phy" specified to attach particular > USB PHYs to USB cores. Let's have the "usb-phy" property described in > the generic USB HCD binding file so it would be validated against the > nodes in which it's specified. Mark the property as deprecated to > discourage the developers from using it. > > Signed-off-by: Serge Semin > > --- > > Changelog v2: > - Discard '|' from the property description, since we don't need to preserve > the text formatting. > --- > Documentation/devicetree/bindings/usb/usb-hcd.yaml | 7 +++ > 1 file changed, 7 insertions(+) > Reviewed-by: Rob Herring ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [PATCH 03/20] dt-bindings: usb: usb-hcd: Add "ulpi/serial/hsic" PHY types
On Wed, 14 Oct 2020 13:13:45 +0300, Serge Semin wrote: > Aside from the UTMI+ there are also ULPI, Serial and HSIC PHY types > that can be specified in the phy_type HCD property. Add them to the > enumeration of the acceptable values. > > Signed-off-by: Serge Semin > > --- > > Changelog v2: > - Grammar fix: "s/PHY types can be/PHY types that can be" > - Drop quotes from around the string constants. > --- > Documentation/devicetree/bindings/usb/usb-hcd.yaml | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) > Reviewed-by: Rob Herring ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [PATCH 02/20] dt-bindings: usb: usb-hcd: Add "otg-rev" property restriction
On Wed, 14 Oct 2020 13:13:44 +0300, Serge Semin wrote: > There are only four OTG revisions are currently supported by the kernel: > 0x0100, 0x0120, 0x0130, 0x0200. Any another value is considered as > invalid. > > Signed-off-by: Serge Semin > --- > Documentation/devicetree/bindings/usb/usb-hcd.yaml | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Rob Herring ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [PATCH 01/20] dt-bindings: usb: usb-hcd: Convert generic USB properties to DT schema
On Wed, 14 Oct 2020 13:13:43 +0300, Serge Semin wrote: > The generic USB HCD properties have been described in the legacy bindings > text file: Documentation/devicetree/bindings/usb/generic.txt . Let's > convert it' content into the USB HCD DT schema properties so all USB DT > nodes would be validated to have them properly utilized. > > Signed-off-by: Serge Semin > > --- > > Changelog v2: > - Discard '|' in all the new properties, since we don't need to preserve > the text formatting. > - Convert abbreviated form of the "maximum-speed" enum restriction into > the multi-lined version of the list. > - Drop quotes from around the string constants. > --- > .../devicetree/bindings/usb/generic.txt | 57 > .../devicetree/bindings/usb/usb-hcd.yaml | 88 +++ > 2 files changed, 88 insertions(+), 57 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/usb/generic.txt > Reviewed-by: Rob Herring ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [PATCH 04/20] dt-bindings: usb: usb-hcd: Add "tpl-support" property
On Wed, Oct 14, 2020 at 08:27:10PM +0300, Serge Semin wrote: > On Wed, Oct 14, 2020 at 08:27:56AM -0500, Rob Herring wrote: > > On Wed, 14 Oct 2020 13:13:46 +0300, Serge Semin wrote: > > > The host controller device might be designed to work for the particular > > > products or applications. In that case its DT node is supposed to be > > > equipped with the tpl-support property. > > > > > > Signed-off-by: Serge Semin > > > > > > --- > > > > > > Changelog v2: > > > - Grammar fix: "s/it'/its" > > > - Discard '|' from the property description, since we don't need to > > > preserve > > > the text formatting. > > > --- > > > Documentation/devicetree/bindings/usb/usb-hcd.yaml | 6 ++ > > > 1 file changed, 6 insertions(+) > > > > > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > > > Traceback (most recent call last): > > File "/usr/local/bin/dt-extract-example", line 45, in > > binding = yaml.load(open(args.yamlfile, encoding='utf-8').read()) > > File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/main.py", line > > 343, in load > > return constructor.get_single_data() > > File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py", > > line 111, in get_single_data > > node = self.composer.get_single_node() > > File "_ruamel_yaml.pyx", line 706, in _ruamel_yaml.CParser.get_single_node > > File "_ruamel_yaml.pyx", line 724, in > > _ruamel_yaml.CParser._compose_document > > File "_ruamel_yaml.pyx", line 775, in _ruamel_yaml.CParser._compose_node > > File "_ruamel_yaml.pyx", line 891, in > > _ruamel_yaml.CParser._compose_mapping_node > > File "_ruamel_yaml.pyx", line 904, in > > _ruamel_yaml.CParser._parse_next_event > > ruamel.yaml.scanner.ScannerError: mapping values are not allowed in this > > context > > in "", line 27, column 14 > > make[1]: *** [Documentation/devicetree/bindings/Makefile:20: > > Documentation/devicetree/bindings/usb/usb-hcd.example.dts] Error 1 > > make[1]: *** Deleting file > > 'Documentation/devicetree/bindings/usb/usb-hcd.example.dts' > > make[1]: *** Waiting for unfinished jobs > > ./Documentation/devicetree/bindings/usb/usb-hcd.yaml:27:14: [error] syntax > > error: mapping values are not allowed here (syntax) > > make[1]: *** [Documentation/devicetree/bindings/Makefile:59: > > Documentation/devicetree/bindings/processed-schema-examples.json] Error 123 > > make: *** [Makefile:1366: dt_binding_check] Error 2 > > > > > > See https://patchwork.ozlabs.org/patch/1382001 > > > > If you already ran 'make dt_binding_check' and didn't see the above > > error(s), then make sure dt-schema is up to date: > > > > pip3 install git+https://github.com/devicetree-org/dt-schema.git@master > > --upgrade > > > > Please check and re-submit. > > Hm, that's weird. Of course I did the dt_binding_check before submission, but > even after the dt-schema repo update I failed to see the error: > > $ make -j8 ARCH=mips CROSS_COMPILE=mipsel-baikal-linux- dt_binding_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/usb/usb-hcd.yaml > CHKDT Documentation/devicetree/bindings/usb/usb-hcd.yaml > SCHEMA Documentation/devicetree/bindings/processed-schema-examples.yaml > DTC Documentation/devicetree/bindings/usb/usb-hcd.example.dt.yaml > CHECK Documentation/devicetree/bindings/usb/usb-hcd.example.dt.yaml > > Rob, any idea why has the bot got mad at me? Humm, I'm not sure. We'll see if it happens again when you send v2. Note that yamllint is also run now and that's the line with '[error]'. So neither yamllint nor ruamel are happy (could be the same parser code ultimately). Rob ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [PATCH 18/20] arch: dts: Fix EHCI/OHCI DT nodes name
Hello Alexandre, On Fri, Oct 16, 2020 at 09:08:23AM +0200, Alexandre Torgue wrote: > Hi Serge, > > On 10/14/20 12:14 PM, Serge Semin wrote: > > In accordance with the Generic EHCI/OHCI bindings the corresponding node > > name is suppose to comply with the Generic USB HCD DT schema, which > > requires the USB nodes to have the name acceptable by the regexp: > > "^usb(@.*)?" . Let's fix the DTS files, which have the nodes defined with > > incompatible names. > > > > Signed-off-by: Serge Semin > > > > --- > > > > Please, test the patch out to make sure it doesn't brake the dependent DTS > > files. I did only a manual grepping of the possible nodes dependencies. > > --- > > arch/arc/boot/dts/axs10x_mb.dtsi | 4 ++-- > > arch/arc/boot/dts/hsdk.dts | 4 ++-- > > arch/arc/boot/dts/vdk_axs10x_mb.dtsi | 2 +- > > arch/arm/boot/dts/bcm5301x.dtsi| 4 ++-- > > arch/arm/boot/dts/bcm53573.dtsi| 4 ++-- > > arch/arm/boot/dts/hisi-x5hd2.dtsi | 4 ++-- > > arch/arm/boot/dts/lpc18xx.dtsi | 4 ++-- > > arch/arm/boot/dts/stm32mp151.dtsi | 4 ++-- > > arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi | 4 ++-- > > arch/arm64/boot/dts/hisilicon/hip06.dtsi | 4 ++-- > > arch/arm64/boot/dts/hisilicon/hip07.dtsi | 4 ++-- > > arch/mips/boot/dts/ingenic/jz4740.dtsi | 2 +- > > arch/mips/boot/dts/ingenic/jz4770.dtsi | 2 +- > > arch/mips/boot/dts/mti/sead3.dts | 2 +- > > arch/mips/boot/dts/ralink/mt7628a.dtsi | 2 +- > > arch/powerpc/boot/dts/akebono.dts | 6 +++--- > > 16 files changed, 28 insertions(+), 28 deletions(-) > > > > I surely missed something, but we have here in the same patch modifications > for different architectures and different vendors. > > Do you plan to split this patch after getting some Acked-by / Tested-by ? Yeah, I'll split this patch and two next ones up in v3. -Sergey > > regards > Alex > > ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [PATCH 18/20] arch: dts: Fix EHCI/OHCI DT nodes name
Hi Serge,
On 10/14/20 12:14 PM, Serge Semin wrote:
In accordance with the Generic EHCI/OHCI bindings the corresponding node
name is suppose to comply with the Generic USB HCD DT schema, which
requires the USB nodes to have the name acceptable by the regexp:
"^usb(@.*)?" . Let's fix the DTS files, which have the nodes defined with
incompatible names.
Signed-off-by: Serge Semin
---
Please, test the patch out to make sure it doesn't brake the dependent DTS
files. I did only a manual grepping of the possible nodes dependencies.
---
arch/arc/boot/dts/axs10x_mb.dtsi | 4 ++--
arch/arc/boot/dts/hsdk.dts | 4 ++--
arch/arc/boot/dts/vdk_axs10x_mb.dtsi | 2 +-
arch/arm/boot/dts/bcm5301x.dtsi| 4 ++--
arch/arm/boot/dts/bcm53573.dtsi| 4 ++--
arch/arm/boot/dts/hisi-x5hd2.dtsi | 4 ++--
arch/arm/boot/dts/lpc18xx.dtsi | 4 ++--
arch/arm/boot/dts/stm32mp151.dtsi | 4 ++--
arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi | 4 ++--
arch/arm64/boot/dts/hisilicon/hip06.dtsi | 4 ++--
arch/arm64/boot/dts/hisilicon/hip07.dtsi | 4 ++--
arch/mips/boot/dts/ingenic/jz4740.dtsi | 2 +-
arch/mips/boot/dts/ingenic/jz4770.dtsi | 2 +-
arch/mips/boot/dts/mti/sead3.dts | 2 +-
arch/mips/boot/dts/ralink/mt7628a.dtsi | 2 +-
arch/powerpc/boot/dts/akebono.dts | 6 +++---
16 files changed, 28 insertions(+), 28 deletions(-)
I surely missed something, but we have here in the same patch
modifications for different architectures and different vendors.
Do you plan to split this patch after getting some Acked-by / Tested-by ?
regards
Alex
diff --git a/arch/arc/boot/dts/axs10x_mb.dtsi b/arch/arc/boot/dts/axs10x_mb.dtsi
index 99d3e7175bf7..b64435385304 100644
--- a/arch/arc/boot/dts/axs10x_mb.dtsi
+++ b/arch/arc/boot/dts/axs10x_mb.dtsi
@@ -87,13 +87,13 @@ gmac: ethernet@18000 {
mac-address = [00 00 00 00 00 00]; /* Filled in by
U-Boot */
};
- ehci@4 {
+ usb@4 {
compatible = "generic-ehci";
reg = < 0x4 0x100 >;
interrupts = < 8 >;
};
- ohci@6 {
+ usb@6 {
compatible = "generic-ohci";
reg = < 0x6 0x100 >;
interrupts = < 8 >;
diff --git a/arch/arc/boot/dts/hsdk.dts b/arch/arc/boot/dts/hsdk.dts
index dcaa44e408ac..fdd4f7f635d3 100644
--- a/arch/arc/boot/dts/hsdk.dts
+++ b/arch/arc/boot/dts/hsdk.dts
@@ -234,7 +234,7 @@ phy0: ethernet-phy@0 { /* Micrel KSZ9031 */
};
};
- ohci@6 {
+ usb@6 {
compatible = "snps,hsdk-v1.0-ohci", "generic-ohci";
reg = <0x6 0x100>;
interrupts = <15>;
@@ -242,7 +242,7 @@ ohci@6 {
dma-coherent;
};
- ehci@4 {
+ usb@4 {
compatible = "snps,hsdk-v1.0-ehci", "generic-ehci";
reg = <0x4 0x100>;
interrupts = <15>;
diff --git a/arch/arc/boot/dts/vdk_axs10x_mb.dtsi
b/arch/arc/boot/dts/vdk_axs10x_mb.dtsi
index cbb179770293..90a412026e64 100644
--- a/arch/arc/boot/dts/vdk_axs10x_mb.dtsi
+++ b/arch/arc/boot/dts/vdk_axs10x_mb.dtsi
@@ -46,7 +46,7 @@ ethernet@18000 {
clock-names = "stmmaceth";
};
- ehci@4 {
+ usb@4 {
compatible = "generic-ehci";
reg = < 0x4 0x100 >;
interrupts = < 8 >;
diff --git a/arch/arm/boot/dts/bcm5301x.dtsi b/arch/arm/boot/dts/bcm5301x.dtsi
index 0016720ce530..bf5656d79a55 100644
--- a/arch/arm/boot/dts/bcm5301x.dtsi
+++ b/arch/arm/boot/dts/bcm5301x.dtsi
@@ -261,7 +261,7 @@ usb2: usb2@21000 {
interrupt-parent = <>;
- ehci: ehci@21000 {
+ ehci: usb@21000 {
#usb-cells = <0>;
compatible = "generic-ehci";
@@ -283,7 +283,7 @@ ehci_port2: port@2 {
};
};
- ohci: ohci@22000 {
+ ohci: usb@22000 {
#usb-cells = <0>;
compatible = "generic-ohci";
diff --git a/arch/arm/boot/dts/bcm53573.dtsi b/arch/arm/boot/dts/bcm53573.dtsi
index 4af8e3293cff..51546fccc616 100644
--- a/arch/arm/boot/dts/bcm53573.dtsi
+++ b/arch/arm/boot/dts/bcm53573.dtsi
@@ -135,7 +135,7 @@ usb2: usb2@4000 {
#address-cells = <1>;
#size-cells = <1>;
- ehci: ehci@4000 {
+ ehci: usb@4000 {
compatible = "generic-ehci";
reg = <0x4000
